From: Pekka Enberg <penberg@cs.helsinki.fi>
To: David Rientjes <rientjes@google.com>
Cc: Xiaotian Feng <dfeng@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Christoph Lameter <cl@linux-foundation.org>,
Matt Mackall <mpm@selenic.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Dmitry Monakhov <dmonakhov@openvz.org>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH V2] slab: fix caller tracking on !CONFIG_DEBUG_SLAB && CONFIG_TRACING
Date: Sun, 04 Jul 2010 19:50:56 +0300 [thread overview]
Message-ID: <4C30BBF0.1030801@cs.helsinki.fi> (raw)
In-Reply-To: <alpine.DEB.2.00.1006301307001.27676@chino.kir.corp.google.com>
David Rientjes wrote:
> On Wed, 30 Jun 2010, Xiaotian Feng wrote:
>
>> In slab, all __xxx_track_caller is defined on CONFIG_DEBUG_SLAB || CONFIG_TRACING,
>> thus caller tracking function should be worked for CONFIG_TRACING. But if
>> CONFIG_DEBUG_SLAB is not set, include/linux/slab.h will define xxx_track_caller to
>> __xxx() without consideration of CONFIG_TRACING. This will break the caller tracking
>> behaviour then.
>>
>> Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
>> Cc: Christoph Lameter <cl@linux-foundation.org>
>> Cc: Pekka Enberg <penberg@cs.helsinki.fi>
>> Cc: Matt Mackall <mpm@selenic.com>
>> Cc: Vegard Nossum <vegard.nossum@gmail.com>
>> Cc: Dmitry Monakhov <dmonakhov@openvz.org>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: David Rientjes <rientjes@google.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
Applied, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: David Rientjes <rientjes@google.com>
Cc: Xiaotian Feng <dfeng@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Christoph Lameter <cl@linux-foundation.org>,
Matt Mackall <mpm@selenic.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Dmitry Monakhov <dmonakhov@openvz.org>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH V2] slab: fix caller tracking on !CONFIG_DEBUG_SLAB && CONFIG_TRACING
Date: Sun, 04 Jul 2010 19:50:56 +0300 [thread overview]
Message-ID: <4C30BBF0.1030801@cs.helsinki.fi> (raw)
In-Reply-To: <alpine.DEB.2.00.1006301307001.27676@chino.kir.corp.google.com>
David Rientjes wrote:
> On Wed, 30 Jun 2010, Xiaotian Feng wrote:
>
>> In slab, all __xxx_track_caller is defined on CONFIG_DEBUG_SLAB || CONFIG_TRACING,
>> thus caller tracking function should be worked for CONFIG_TRACING. But if
>> CONFIG_DEBUG_SLAB is not set, include/linux/slab.h will define xxx_track_caller to
>> __xxx() without consideration of CONFIG_TRACING. This will break the caller tracking
>> behaviour then.
>>
>> Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
>> Cc: Christoph Lameter <cl@linux-foundation.org>
>> Cc: Pekka Enberg <penberg@cs.helsinki.fi>
>> Cc: Matt Mackall <mpm@selenic.com>
>> Cc: Vegard Nossum <vegard.nossum@gmail.com>
>> Cc: Dmitry Monakhov <dmonakhov@openvz.org>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: David Rientjes <rientjes@google.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
Applied, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-04 16:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 10:11 [PATCH] slab: fix caller tracking on !CONFIG_DEBUG_SLAB && CONFIG_TRACING Xiaotian Feng
2010-04-08 10:11 ` Xiaotian Feng
2010-04-08 19:12 ` David Rientjes
2010-04-08 19:12 ` David Rientjes
2010-04-09 6:28 ` Xiaotian Feng
2010-04-09 6:28 ` Xiaotian Feng
2010-04-09 16:49 ` David Rientjes
2010-04-09 16:49 ` David Rientjes
2010-06-30 9:57 ` [PATCH V2] " Xiaotian Feng
2010-06-30 9:57 ` Xiaotian Feng
2010-06-30 20:07 ` David Rientjes
2010-06-30 20:07 ` David Rientjes
2010-07-04 16:50 ` Pekka Enberg [this message]
2010-07-04 16:50 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C30BBF0.1030801@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=catalin.marinas@arm.com \
--cc=cl@linux-foundation.org \
--cc=dfeng@redhat.com \
--cc=dmonakhov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=rientjes@google.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.