* [PATCH 22/25] vme_tsi148: remove casts from void*
@ 2010-06-29 10:16 ` Kulikov Vasiliy
0 siblings, 0 replies; 4+ messages in thread
From: Kulikov Vasiliy @ 2010-06-29 10:16 UTC (permalink / raw)
To: Kernel Janitors
Cc: Greg Kroah-Hartman, Martyn Welch, Julia Lawall, devel,
linux-kernel
Remove unnesessary casts from void*.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/vme/bridges/vme_tsi148.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
index abe88a3..4685a31 100644
--- a/drivers/staging/vme/bridges/vme_tsi148.c
+++ b/drivers/staging/vme/bridges/vme_tsi148.c
@@ -1649,7 +1649,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
/* Fill out source part */
switch (src->type) {
case VME_DMA_PATTERN:
- pattern_attr = (struct vme_dma_pattern *)src->private;
+ pattern_attr = src->private;
entry->descriptor.dsal = pattern_attr->pattern;
entry->descriptor.dsat = TSI148_LCSR_DSAT_TYP_PAT;
@@ -1663,7 +1663,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
break;
case VME_DMA_PCI:
- pci_attr = (struct vme_dma_pci *)src->private;
+ pci_attr = src->private;
reg_split((unsigned long long)pci_attr->address, &address_high,
&address_low);
@@ -1672,7 +1672,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
entry->descriptor.dsat = TSI148_LCSR_DSAT_TYP_PCI;
break;
case VME_DMA_VME:
- vme_attr = (struct vme_dma_vme *)src->private;
+ vme_attr = src->private;
reg_split((unsigned long long)vme_attr->address, &address_high,
&address_low);
@@ -1701,7 +1701,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
/* Fill out destination part */
switch (dest->type) {
case VME_DMA_PCI:
- pci_attr = (struct vme_dma_pci *)dest->private;
+ pci_attr = dest->private;
reg_split((unsigned long long)pci_attr->address, &address_high,
&address_low);
@@ -1710,7 +1710,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
entry->descriptor.ddat = TSI148_LCSR_DDAT_TYP_PCI;
break;
case VME_DMA_VME:
- vme_attr = (struct vme_dma_vme *)dest->private;
+ vme_attr = dest->private;
reg_split((unsigned long long)vme_attr->address, &address_high,
&address_low);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 22/25] vme_tsi148: remove casts from void*
@ 2010-06-29 10:16 ` Kulikov Vasiliy
0 siblings, 0 replies; 4+ messages in thread
From: Kulikov Vasiliy @ 2010-06-29 10:16 UTC (permalink / raw)
To: Kernel Janitors
Cc: Greg Kroah-Hartman, Martyn Welch, Julia Lawall, devel,
linux-kernel
Remove unnesessary casts from void*.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/vme/bridges/vme_tsi148.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
index abe88a3..4685a31 100644
--- a/drivers/staging/vme/bridges/vme_tsi148.c
+++ b/drivers/staging/vme/bridges/vme_tsi148.c
@@ -1649,7 +1649,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
/* Fill out source part */
switch (src->type) {
case VME_DMA_PATTERN:
- pattern_attr = (struct vme_dma_pattern *)src->private;
+ pattern_attr = src->private;
entry->descriptor.dsal = pattern_attr->pattern;
entry->descriptor.dsat = TSI148_LCSR_DSAT_TYP_PAT;
@@ -1663,7 +1663,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
break;
case VME_DMA_PCI:
- pci_attr = (struct vme_dma_pci *)src->private;
+ pci_attr = src->private;
reg_split((unsigned long long)pci_attr->address, &address_high,
&address_low);
@@ -1672,7 +1672,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
entry->descriptor.dsat = TSI148_LCSR_DSAT_TYP_PCI;
break;
case VME_DMA_VME:
- vme_attr = (struct vme_dma_vme *)src->private;
+ vme_attr = src->private;
reg_split((unsigned long long)vme_attr->address, &address_high,
&address_low);
@@ -1701,7 +1701,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
/* Fill out destination part */
switch (dest->type) {
case VME_DMA_PCI:
- pci_attr = (struct vme_dma_pci *)dest->private;
+ pci_attr = dest->private;
reg_split((unsigned long long)pci_attr->address, &address_high,
&address_low);
@@ -1710,7 +1710,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
entry->descriptor.ddat = TSI148_LCSR_DDAT_TYP_PCI;
break;
case VME_DMA_VME:
- vme_attr = (struct vme_dma_vme *)dest->private;
+ vme_attr = dest->private;
reg_split((unsigned long long)vme_attr->address, &address_high,
&address_low);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 22/25] vme_tsi148: remove casts from void*
2010-06-29 10:16 ` Kulikov Vasiliy
@ 2010-07-05 10:38 ` Martyn Welch
-1 siblings, 0 replies; 4+ messages in thread
From: Martyn Welch @ 2010-07-05 10:38 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: Kernel Janitors, Greg Kroah-Hartman, Julia Lawall, devel,
linux-kernel
Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>
Seems ok, cheers,
Signed-off-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/bridges/vme_tsi148.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
> index abe88a3..4685a31 100644
> --- a/drivers/staging/vme/bridges/vme_tsi148.c
> +++ b/drivers/staging/vme/bridges/vme_tsi148.c
> @@ -1649,7 +1649,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
> /* Fill out source part */
> switch (src->type) {
> case VME_DMA_PATTERN:
> - pattern_attr = (struct vme_dma_pattern *)src->private;
> + pattern_attr = src->private;
>
> entry->descriptor.dsal = pattern_attr->pattern;
> entry->descriptor.dsat = TSI148_LCSR_DSAT_TYP_PAT;
> @@ -1663,7 +1663,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>
> break;
> case VME_DMA_PCI:
> - pci_attr = (struct vme_dma_pci *)src->private;
> + pci_attr = src->private;
>
> reg_split((unsigned long long)pci_attr->address, &address_high,
> &address_low);
> @@ -1672,7 +1672,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
> entry->descriptor.dsat = TSI148_LCSR_DSAT_TYP_PCI;
> break;
> case VME_DMA_VME:
> - vme_attr = (struct vme_dma_vme *)src->private;
> + vme_attr = src->private;
>
> reg_split((unsigned long long)vme_attr->address, &address_high,
> &address_low);
> @@ -1701,7 +1701,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
> /* Fill out destination part */
> switch (dest->type) {
> case VME_DMA_PCI:
> - pci_attr = (struct vme_dma_pci *)dest->private;
> + pci_attr = dest->private;
>
> reg_split((unsigned long long)pci_attr->address, &address_high,
> &address_low);
> @@ -1710,7 +1710,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
> entry->descriptor.ddat = TSI148_LCSR_DDAT_TYP_PCI;
> break;
> case VME_DMA_VME:
> - vme_attr = (struct vme_dma_vme *)dest->private;
> + vme_attr = dest->private;
>
> reg_split((unsigned long long)vme_attr->address, &address_high,
> &address_low);
>
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 22/25] vme_tsi148: remove casts from void*
@ 2010-07-05 10:38 ` Martyn Welch
0 siblings, 0 replies; 4+ messages in thread
From: Martyn Welch @ 2010-07-05 10:38 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: Kernel Janitors, Greg Kroah-Hartman, Julia Lawall, devel,
linux-kernel
Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>
Seems ok, cheers,
Signed-off-by: Martyn Welch <martyn.welch@ge.com>
> ---
> drivers/staging/vme/bridges/vme_tsi148.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
> index abe88a3..4685a31 100644
> --- a/drivers/staging/vme/bridges/vme_tsi148.c
> +++ b/drivers/staging/vme/bridges/vme_tsi148.c
> @@ -1649,7 +1649,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
> /* Fill out source part */
> switch (src->type) {
> case VME_DMA_PATTERN:
> - pattern_attr = (struct vme_dma_pattern *)src->private;
> + pattern_attr = src->private;
>
> entry->descriptor.dsal = pattern_attr->pattern;
> entry->descriptor.dsat = TSI148_LCSR_DSAT_TYP_PAT;
> @@ -1663,7 +1663,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>
> break;
> case VME_DMA_PCI:
> - pci_attr = (struct vme_dma_pci *)src->private;
> + pci_attr = src->private;
>
> reg_split((unsigned long long)pci_attr->address, &address_high,
> &address_low);
> @@ -1672,7 +1672,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
> entry->descriptor.dsat = TSI148_LCSR_DSAT_TYP_PCI;
> break;
> case VME_DMA_VME:
> - vme_attr = (struct vme_dma_vme *)src->private;
> + vme_attr = src->private;
>
> reg_split((unsigned long long)vme_attr->address, &address_high,
> &address_low);
> @@ -1701,7 +1701,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
> /* Fill out destination part */
> switch (dest->type) {
> case VME_DMA_PCI:
> - pci_attr = (struct vme_dma_pci *)dest->private;
> + pci_attr = dest->private;
>
> reg_split((unsigned long long)pci_attr->address, &address_high,
> &address_low);
> @@ -1710,7 +1710,7 @@ int tsi148_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
> entry->descriptor.ddat = TSI148_LCSR_DDAT_TYP_PCI;
> break;
> case VME_DMA_VME:
> - vme_attr = (struct vme_dma_vme *)dest->private;
> + vme_attr = dest->private;
>
> reg_split((unsigned long long)vme_attr->address, &address_high,
> &address_low);
>
--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-05 10:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-29 10:16 [PATCH 22/25] vme_tsi148: remove casts from void* Kulikov Vasiliy
2010-06-29 10:16 ` Kulikov Vasiliy
2010-07-05 10:38 ` Martyn Welch
2010-07-05 10:38 ` Martyn Welch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.