Re: [Qemu-devel] [PATCH] Fix io-thread build breakage of a88790a14f

[Jan Kiszka <jan.kiszka@siemens.com>]

Anthony Liguori wrote:
> On 07/06/2010 03:49 AM, Jan Kiszka wrote:
>> Nigel Horne wrote:
>>    
>>> ./configure --enable-linux-aio --enable-io-thread --enable-kvm
>>> make
>>> ...
>>> /home/njh/src/qemu/cpus.c:532: error: ‘exit_request’ undeclared (first
>>> use in this function)
>>> /home/njh/src/qemu/cpus.c:532: error: (Each undeclared identifier is
>>> reported only once
>>> /home/njh/src/qemu/cpus.c:532: error: for each function it appears in.)
>>>
>>> Perhaps cpus.c needs to have:
>>>
>>> extern volatile sig_atomic_t exit_request;
>>>      
>> Better include the header:
>>
>> ---------->
>>
>> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>>    
> 
> Applied.  Thanks.
> 
> In the future, please try to avoid quoting in like this.  I often forget 
> to remove it from the commit message before pushing (although I did in 
> this case).

OK.

Note that there is also 'git am -c' - but I used a non-standard scissors
line here...

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux