From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, davem@davemloft.net,
jkosina@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]crypto:hifn_795x.c Fix warning: variable 'ctx' set but not used
Date: Tue, 06 Jul 2010 10:19:33 -0700 [thread overview]
Message-ID: <4C3365A5.5010605@gmail.com> (raw)
In-Reply-To: <20100706070355.GA14626@gondor.apana.org.au>
> This certainly does not look right! Returning with IRQs disabled
> is considered to be rude.
>
> I believe the right answer is to delete the line initialising ctx.
>
> Thanks,
o.k. hopefully this is correct this time, resent with the following
change. let me know if it's legit or not..
Justin P. Mattock
WARNING: multiple messages have this Message-ID (diff)
From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: linux-crypto@vger.kernel.org, davem@davemloft.net,
jkosina@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]crypto:hifn_795x.c Fix warning: variable 'ctx' set but not used
Date: Tue, 06 Jul 2010 10:19:33 -0700 [thread overview]
Message-ID: <4C3365A5.5010605@gmail.com> (raw)
In-Reply-To: <20100706070355.GA14626@gondor.apana.org.au>
> This certainly does not look right! Returning with IRQs disabled
> is considered to be rude.
>
> I believe the right answer is to delete the line initialising ctx.
>
> Thanks,
o.k. hopefully this is correct this time, resent with the following
change. let me know if it's legit or not..
Justin P. Mattock
next prev parent reply other threads:[~2010-07-06 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 6:26 [PATCH]crypto:hifn_795x.c Fix warning: variable 'ctx' set but not used Justin P. Mattock
2010-07-06 7:03 ` Herbert Xu
2010-07-06 7:03 ` Herbert Xu
2010-07-06 13:46 ` Justin P. Mattock
2010-07-06 13:46 ` Justin P. Mattock
2010-07-06 17:19 ` Justin P. Mattock [this message]
2010-07-06 17:19 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3365A5.5010605@gmail.com \
--to=justinmattock@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jkosina@suse.cz \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.