[PATCH 1/2] Voicecall gaps.

[PATCH 1/2] Voicecall gaps.

[Pekka.Pessi]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

From: Pekka Pessi <Pekka.Pessi@nokia.com>

Missing voicecall functionality pieces from tp-ring point-of-view.
---
 TODO |   27 +++++++++++++++++++++++++++
 1 files changed, 27 insertions(+), 0 deletions(-)

diff --git a/TODO b/TODO
index 470d4a6..fc539a7 100644
--- a/TODO
+++ b/TODO
@@ -265,6 +265,33 @@ Supplementary Services
   Complexity: C8
 
 
+Voicecall
+=========
+
+- Supplementary service notifications on remote party actions:
+  - call has been put on hold (+CSSU: 2)
+  - call has been retrieved (+CSSU: 3), and
+  - joining call to a multiparty conference (+CSSU: 4)
+
+  Priority: Medium
+  Complexity: C1
+  Owner: Pekka Pessi <pekka.pessi@nokia.com>
+
+- Dial strings. Include CLIR prefixes and 2nd stage dial strings in the
+  DialString call property. Add dialstring accessor method to C API.
+
+  Priority: Medium
+
+- Provide feedback of sent DTMF tones. Emit SendingTones signal if modem can
+  provide approximate starting and stopping times for DTMF tones. Signal
+  argument contains a string of DTMF tones to be sent, or empty string when
+  all tones has been sent.
+
+  Priority: Medium
+  Complexity: C2
+  Owner: Pekka Pessi <pekka.pessi@nokia.com>
+
+
 Miscellaneous
 =============
 
-- 
1.7.0.4

[PATCH 1/2] Voicecall gaps.

[Pekka.Pessi]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

From: Pekka Pessi <Pekka.Pessi@nokia.com>

Missing voicecall functionality pieces from tp-ring point-of-view.
---
 TODO |   27 +++++++++++++++++++++++++++
 1 files changed, 27 insertions(+), 0 deletions(-)

diff --git a/TODO b/TODO
index 470d4a6..fc539a7 100644
--- a/TODO
+++ b/TODO
@@ -265,6 +265,33 @@ Supplementary Services
   Complexity: C8
 
 
+Voicecall
+=========
+
+- Supplementary service notifications on remote party actions:
+  - call has been put on hold (+CSSU: 2)
+  - call has been retrieved (+CSSU: 3), and
+  - joining call to a multiparty conference (+CSSU: 4)
+
+  Priority: Medium
+  Complexity: C1
+  Owner: Pekka Pessi <pekka.pessi@nokia.com>
+
+- Dial strings. Include CLIR prefixes and 2nd stage dial strings in the
+  DialString call property. Add dialstring accessor method to C API.
+
+  Priority: Medium
+
+- Provide feedback of sent DTMF tones. Emit SendingTones signal if modem can
+  provide approximate starting and stopping times for DTMF tones. Signal
+  argument contains a string of DTMF tones to be sent, or empty string when
+  all tones has been sent.
+
+  Priority: Medium
+  Complexity: C2
+  Owner: Pekka Pessi <pekka.pessi@nokia.com>
+
+
 Miscellaneous
 =============
 
-- 
1.7.0.4

[PATCH 2/2] Clarified VoiceCallManager.SendTones documentation.

[Pekka.Pessi]

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

From: Pekka Pessi <Pekka.Pessi@nokia.com>

---
 doc/voicecallmanager-api.txt |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt
index 7877ac5..bc79fc3 100644
--- a/doc/voicecallmanager-api.txt
+++ b/doc/voicecallmanager-api.txt
@@ -108,10 +108,10 @@ Methods		dict GetProperties()
 
 		void SendTones(string tones)
 
-			Sends the DTMF tones to the network.  Under GSM the
-			tones have a fixed duration.  Tones can be one of:
-			'0' - '9', '*', '#', 'A', 'B', 'C', 'D'. The last four
-			are typically not used in normal circumstances.
+			Sends the DTMF tones to the network.  The tones have
+			a fixed duration.  Tones can be one of: '0' - '9',
+			'*', '#', 'A', 'B', 'C', 'D'.  The last four are
+			typically not used in normal circumstances.
 
 Signals		PropertyChanged(string property, variant value)
 
-- 
1.7.0.4

Re: [PATCH 2/2] Clarified VoiceCallManager.SendTones documentation.

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

Hi Pekka,

On 07/06/2010 12:17 PM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi <Pekka.Pessi@nokia.com>
> 
> ---
>  doc/voicecallmanager-api.txt |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 

I applied this patch with a slightly reworded commit header.

Regards,
-Denis

Re: [PATCH 1/2] Voicecall gaps.

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

On 07/06/2010 12:17 PM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi <Pekka.Pessi@nokia.com>
> 
> Missing voicecall functionality pieces from tp-ring point-of-view.
> ---
>  TODO |   27 +++++++++++++++++++++++++++
>  1 files changed, 27 insertions(+), 0 deletions(-)

Applied with a modified commit message.

Thanks,
-Denis