From: Yinghai Lu <yinghai@kernel.org>
To: Borislav Petkov <borislav.petkov@amd.com>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Conny Seidel <conny.seidel@amd.com>
Subject: Re: BUG: unable to handle kernel paging request at 40000000 __alloc_memory_core_early+0x147/0x1d6
Date: Fri, 09 Jul 2010 12:08:52 -0700 [thread overview]
Message-ID: <4C3773C4.1010609@kernel.org> (raw)
In-Reply-To: <20100709145415.GC11199@aftab>
On 07/09/2010 07:54 AM, Borislav Petkov wrote:
> Hi,
>
> this is something we're getting during testing on one of our boxes here,
> a dual socket Magny-Cours machine. It is oopsing on the addr variable in
> __alloc_memory_core_early() after converting it to a virtual address in
> order to clear the mem region at it. I've removed the "#if 0.. #endif"
> around the printk which dumps the ranges in the early node map for more
> info.
>
> It's latest -git, 32bit build, config is attached.
>
can not duplicate on all my setup.
but look at the code there is limit problem with 32 bit...
please check if it will fix the problem.
and we will need to rebase early_res to memblock patchset.
Thanks
Yinghai Lu
[PATCH] x86,mm: fix 32bit numa sparse vmemmp
Borislav Petkov <borislav.petkov@amd.com> reported his 32bit numa has problem:
[ 0.000000] Reserving total of 4c00 pages for numa KVA remap
[ 0.000000] kva_start_pfn ~ 32800 max_low_pfn ~ 375fe
[ 0.000000] max_pfn = 238000
[ 0.000000] 8202MB HIGHMEM available.
[ 0.000000] 885MB LOWMEM available.
[ 0.000000] mapped low ram: 0 - 375fe000
[ 0.000000] low ram: 0 - 375fe000
[ 0.000000] alloc (nid=8 100000 - 7ee00000) (1000000 - ffffffff) 1000 1000 => 34e7000
[ 0.000000] alloc (nid=8 100000 - 7ee00000) (1000000 - ffffffff) 200 40 => 34c9d80
[ 0.000000] alloc (nid=0 100000 - 7ee00000) (1000000 - ffffffffffffffff) 180 40 => 34e6140
[ 0.000000] alloc (nid=1 80000000 - c7e60000) (1000000 - ffffffffffffffff) 240 40 => 80000000
[ 0.000000] BUG: unable to handle kernel paging request at 40000000
[ 0.000000] IP: [<c2c8cff1>] __alloc_memory_core_early+0x147/0x1d6
[ 0.000000] *pdpt = 0000000000000000 *pde = f000ff53f000ff00
...
[ 0.000000] Call Trace:
[ 0.000000] [<c2c8b4f8>] ? __alloc_bootmem_node+0x216/0x22f
[ 0.000000] [<c2c90c9b>] ? sparse_early_usemaps_alloc_node+0x5a/0x10b
[ 0.000000] [<c2c9149e>] ? sparse_init+0x1dc/0x499
[ 0.000000] [<c2c79118>] ? paging_init+0x168/0x1df
[ 0.000000] [<c2c780ff>] ? native_pagetable_setup_start+0xef/0x1bb
looks like it allocate much high address for bootmem.
try to cut limit with get_max_mapped()
Reported-by: Borislav Petkov <borislav.petkov@amd.com>
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
mm/page_alloc.c | 3 +++
mm/sparse.c | 5 ++++-
2 files changed, 7 insertions(+), 1 deletion(-)
Index: linux-2.6/mm/page_alloc.c
===================================================================
--- linux-2.6.orig/mm/page_alloc.c
+++ linux-2.6/mm/page_alloc.c
@@ -3634,6 +3634,9 @@ void * __init __alloc_memory_core_early(
int i;
void *ptr;
+ if (limit > get_max_mapped())
+ limit = get_max_mapped();
+
/* need to go over early_node_map to find out good range for node */
for_each_active_range_index_in_nid(i, nid) {
u64 addr;
Index: linux-2.6/mm/sparse.c
===================================================================
--- linux-2.6.orig/mm/sparse.c
+++ linux-2.6/mm/sparse.c
@@ -363,7 +363,10 @@ static void __init sparse_early_usemaps_
return;
}
- usemap = alloc_bootmem_node(NODE_DATA(nodeid), size * usemap_count);
+ usemap = __alloc_bootmem_node_nopanic(NODE_DATA(nodeid),
+ size * usemap_count,
+ SMP_CACHE_BYTES,
+ __pa(MAX_DMA_ADDRESS));
if (usemap) {
for (pnum = pnum_begin; pnum < pnum_end; pnum++) {
if (!present_section_nr(pnum))
next prev parent reply other threads:[~2010-07-09 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 14:54 BUG: unable to handle kernel paging request at 40000000 __alloc_memory_core_early+0x147/0x1d6 Borislav Petkov
2010-07-09 19:08 ` Yinghai Lu [this message]
2010-07-09 19:52 ` Conny Seidel
2010-07-09 20:18 ` Yinghai Lu
2010-07-09 20:42 ` Conny Seidel
2010-07-09 22:07 ` Yinghai Lu
2010-07-09 23:51 ` Conny Seidel
2010-07-10 1:03 ` Yinghai Lu
2010-07-10 8:14 ` Conny Seidel
2010-07-10 18:40 ` [PATCH -v3] x86,nobootmem: make alloc_bootmem_node fall back to other node when 32bit numa are used Yinghai Lu
2010-07-20 18:35 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3773C4.1010609@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=borislav.petkov@amd.com \
--cc=conny.seidel@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.