From: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
Corrado Zoccolo <czoccolo@gmail.com>,
linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: [PATCH] CFQ: Don't store left slice when slice used up or for a idle workload
Date: Tue, 13 Jul 2010 10:21:21 +0800 [thread overview]
Message-ID: <4C3BCDA1.5040007@cn.fujitsu.com> (raw)
It doesn't make sence to store left time slice for an idle workload
or for the cfqq that uses up its slice.
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
block/cfq-iosched.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index eb4086f..d985e38 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -3418,7 +3418,7 @@ static void cfq_completed_request(struct request_queue *q, struct request *rq)
* - when there is a close cooperator
*/
if (cfq_slice_used(cfqq) || cfq_class_idle(cfqq))
- cfq_slice_expired(cfqd, 1);
+ cfq_slice_expired(cfqd, 0);
else if (sync && cfqq_empty &&
!cfq_close_cooperator(cfqd, cfqq)) {
cfqd->noidle_tree_requires_idle |=
--
1.5.4.rc3
next reply other threads:[~2010-07-13 2:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 2:21 Gui Jianfeng [this message]
2010-07-13 13:10 ` [PATCH] CFQ: Don't store left slice when slice used up or for a idle workload Jeff Moyer
2010-07-14 0:40 ` Gui Jianfeng
2010-07-14 13:23 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3BCDA1.5040007@cn.fujitsu.com \
--to=guijianfeng@cn.fujitsu.com \
--cc=czoccolo@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.