All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Vivek Goyal <vgoyal@redhat.com>,
	Corrado Zoccolo <czoccolo@gmail.com>,
	linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] CFQ: Don't store left slice when slice used up or for a idle workload
Date: Wed, 14 Jul 2010 08:40:02 +0800	[thread overview]
Message-ID: <4C3D0762.2060807@cn.fujitsu.com> (raw)
In-Reply-To: <x49r5j7plwy.fsf@segfault.boston.devel.redhat.com>

Jeff Moyer wrote:
> Gui Jianfeng <guijianfeng@cn.fujitsu.com> writes:
> 
>> It doesn't make sence to store left time slice for an idle workload
>> or for the cfqq that uses up its slice.
> 
> Did you actually observe any problems?  As I understand it, if you
> overrun your slice you get a negative offset, so I think we want to keep
> that.

Hi Jeff

If that's the case, do we also need to store the negative offset when slice
used up in cfq_select_queue() and cfq_idle_slice_timer()?

Thanks
Gui

> 
> Cheers,
> Jeff
> 
> 

  reply	other threads:[~2010-07-14  0:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13  2:21 [PATCH] CFQ: Don't store left slice when slice used up or for a idle workload Gui Jianfeng
2010-07-13 13:10 ` Jeff Moyer
2010-07-14  0:40   ` Gui Jianfeng [this message]
2010-07-14 13:23     ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3D0762.2060807@cn.fujitsu.com \
    --to=guijianfeng@cn.fujitsu.com \
    --cc=axboe@kernel.dk \
    --cc=czoccolo@gmail.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.