From: Yusuke Goda <yusuke.goda.sx@renesas.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mmc@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH] tmio_mmc: Revise a limit of the data size
Date: Tue, 13 Jul 2010 11:32:33 +0900 [thread overview]
Message-ID: <4C3BD041.3020705@renesas.com> (raw)
In-Reply-To: <20100708144647.1e77364b.akpm@linux-foundation.org>
Hi Andrew
Andrew Morton wrote:
> On Wed, 07 Jul 2010 11:01:20 +0900
> Yusuke Goda <yusuke.goda.sx@renesas.com> wrote:
>
>> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
>> ---
>> drivers/mmc/host/tmio_mmc.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
>> index ee7d0a5..cac1c97 100644
>> --- a/drivers/mmc/host/tmio_mmc.c
>> +++ b/drivers/mmc/host/tmio_mmc.c
>> @@ -661,7 +661,7 @@ static int tmio_mmc_start_data(struct tmio_mmc_host *host,
>> data->blksz, data->blocks);
>>
>> /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */
>> - if (data->blksz < 4 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) {
>> + if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) {
>> pr_err("%s: %d byte block unsupported in 4 bit mode\n",
>> mmc_hostname(host->mmc), data->blksz);
>> return -EINVAL;
>
> Again, please provide a suitable description for this change.
I think the data size is not limited by MMC_BUS_WIDTH_x.
I confirmed that data transmission of 2Byte was performed without a problem.
Thanks,
Goda
next prev parent reply other threads:[~2010-07-13 2:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 2:01 [PATCH] tmio_mmc: Revise a limit of the data size Yusuke Goda
2010-07-08 21:46 ` Andrew Morton
2010-07-13 2:32 ` Yusuke Goda [this message]
2010-08-25 21:52 ` Matt Fleming
2010-08-25 22:05 ` Andrew Morton
2010-08-25 22:19 ` Matt Fleming
2010-08-26 1:50 ` Ian Molton
2010-08-26 7:24 ` Matt Fleming
2010-08-26 7:26 ` Magnus Damm
2010-08-26 10:28 ` Ian Molton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3BD041.3020705@renesas.com \
--to=yusuke.goda.sx@renesas.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mmc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.