* [PATCH] tmio_mmc: Revise a limit of the data size @ 2010-07-07 2:01 Yusuke Goda 2010-07-08 21:46 ` Andrew Morton 0 siblings, 1 reply; 10+ messages in thread From: Yusuke Goda @ 2010-07-07 2:01 UTC (permalink / raw) To: linux-mmc; +Cc: Andrew Morton, Magnus Damm Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com> --- drivers/mmc/host/tmio_mmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c index ee7d0a5..cac1c97 100644 --- a/drivers/mmc/host/tmio_mmc.c +++ b/drivers/mmc/host/tmio_mmc.c @@ -661,7 +661,7 @@ static int tmio_mmc_start_data(struct tmio_mmc_host *host, data->blksz, data->blocks); /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */ - if (data->blksz < 4 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { + if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { pr_err("%s: %d byte block unsupported in 4 bit mode\n", mmc_hostname(host->mmc), data->blksz); return -EINVAL; -- 1.7.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] tmio_mmc: Revise a limit of the data size 2010-07-07 2:01 [PATCH] tmio_mmc: Revise a limit of the data size Yusuke Goda @ 2010-07-08 21:46 ` Andrew Morton 2010-07-13 2:32 ` Yusuke Goda 0 siblings, 1 reply; 10+ messages in thread From: Andrew Morton @ 2010-07-08 21:46 UTC (permalink / raw) To: Yusuke Goda; +Cc: linux-mmc, Magnus Damm On Wed, 07 Jul 2010 11:01:20 +0900 Yusuke Goda <yusuke.goda.sx@renesas.com> wrote: > Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com> > --- > drivers/mmc/host/tmio_mmc.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c > index ee7d0a5..cac1c97 100644 > --- a/drivers/mmc/host/tmio_mmc.c > +++ b/drivers/mmc/host/tmio_mmc.c > @@ -661,7 +661,7 @@ static int tmio_mmc_start_data(struct tmio_mmc_host *host, > data->blksz, data->blocks); > > /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */ > - if (data->blksz < 4 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { > + if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { > pr_err("%s: %d byte block unsupported in 4 bit mode\n", > mmc_hostname(host->mmc), data->blksz); > return -EINVAL; Again, please provide a suitable description for this change. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] tmio_mmc: Revise a limit of the data size 2010-07-08 21:46 ` Andrew Morton @ 2010-07-13 2:32 ` Yusuke Goda 2010-08-25 21:52 ` Matt Fleming 0 siblings, 1 reply; 10+ messages in thread From: Yusuke Goda @ 2010-07-13 2:32 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-mmc, Magnus Damm Hi Andrew Andrew Morton wrote: > On Wed, 07 Jul 2010 11:01:20 +0900 > Yusuke Goda <yusuke.goda.sx@renesas.com> wrote: > >> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com> >> --- >> drivers/mmc/host/tmio_mmc.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c >> index ee7d0a5..cac1c97 100644 >> --- a/drivers/mmc/host/tmio_mmc.c >> +++ b/drivers/mmc/host/tmio_mmc.c >> @@ -661,7 +661,7 @@ static int tmio_mmc_start_data(struct tmio_mmc_host *host, >> data->blksz, data->blocks); >> >> /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */ >> - if (data->blksz < 4 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { >> + if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { >> pr_err("%s: %d byte block unsupported in 4 bit mode\n", >> mmc_hostname(host->mmc), data->blksz); >> return -EINVAL; > > Again, please provide a suitable description for this change. I think the data size is not limited by MMC_BUS_WIDTH_x. I confirmed that data transmission of 2Byte was performed without a problem. Thanks, Goda ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] tmio_mmc: Revise a limit of the data size 2010-07-13 2:32 ` Yusuke Goda @ 2010-08-25 21:52 ` Matt Fleming 2010-08-25 22:05 ` Andrew Morton 0 siblings, 1 reply; 10+ messages in thread From: Matt Fleming @ 2010-08-25 21:52 UTC (permalink / raw) To: Yusuke Goda; +Cc: Andrew Morton, linux-mmc, Magnus Damm On Tue, 13 Jul 2010 11:32:33 +0900 Yusuke Goda <yusuke.goda.sx@renesas.com> wrote: > Hi Andrew > > Andrew Morton wrote: > > On Wed, 07 Jul 2010 11:01:20 +0900 > > Yusuke Goda <yusuke.goda.sx@renesas.com> wrote: > > > >> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com> > >> --- > >> drivers/mmc/host/tmio_mmc.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c > >> index ee7d0a5..cac1c97 100644 > >> --- a/drivers/mmc/host/tmio_mmc.c > >> +++ b/drivers/mmc/host/tmio_mmc.c > >> @@ -661,7 +661,7 @@ static int tmio_mmc_start_data(struct tmio_mmc_host *host, > >> data->blksz, data->blocks); > >> > >> /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */ > >> - if (data->blksz < 4 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { > >> + if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { > >> pr_err("%s: %d byte block unsupported in 4 bit mode\n", > >> mmc_hostname(host->mmc), data->blksz); > >> return -EINVAL; > > > > Again, please provide a suitable description for this change. > I think the data size is not limited by MMC_BUS_WIDTH_x. > I confirmed that data transmission of 2Byte was performed without a problem. This patch hasn't been picked up. I'm assuming that's because Andrew is still unhappy with the changelog. Andrew, how about something like, "When running in 4-bit bus width mode, it is entirely possible to transfer data in block sizes of 2 bytes and larger. Relax the conditional check to allow 2-byte data block transfers which were previously disallowed." Yusuke, have I interpreted your changelog correctly? Also note that your patch should remove the comment above the conditional that says, "Hardware cannot perform 1 and 2 byte requests in 4 bit mode". ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] tmio_mmc: Revise a limit of the data size 2010-08-25 21:52 ` Matt Fleming @ 2010-08-25 22:05 ` Andrew Morton 2010-08-25 22:19 ` Matt Fleming 2010-08-26 1:50 ` Ian Molton 0 siblings, 2 replies; 10+ messages in thread From: Andrew Morton @ 2010-08-25 22:05 UTC (permalink / raw) To: Matt Fleming; +Cc: Yusuke Goda, linux-mmc, Magnus Damm, Paul Mundt, Ian Molton On Wed, 25 Aug 2010 22:52:08 +0100 Matt Fleming <matt@console-pimps.org> wrote: > On Tue, 13 Jul 2010 11:32:33 +0900 > Yusuke Goda <yusuke.goda.sx@renesas.com> wrote: > > > Hi Andrew > > > > Andrew Morton wrote: > > > On Wed, 07 Jul 2010 11:01:20 +0900 > > > Yusuke Goda <yusuke.goda.sx@renesas.com> wrote: > > > > > >> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com> > > >> --- > > >> drivers/mmc/host/tmio_mmc.c | 2 +- > > >> 1 files changed, 1 insertions(+), 1 deletions(-) > > >> > > >> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c > > >> index ee7d0a5..cac1c97 100644 > > >> --- a/drivers/mmc/host/tmio_mmc.c > > >> +++ b/drivers/mmc/host/tmio_mmc.c > > >> @@ -661,7 +661,7 @@ static int tmio_mmc_start_data(struct tmio_mmc_host *host, > > >> data->blksz, data->blocks); > > >> > > >> /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */ > > >> - if (data->blksz < 4 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { > > >> + if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { > > >> pr_err("%s: %d byte block unsupported in 4 bit mode\n", > > >> mmc_hostname(host->mmc), data->blksz); > > >> return -EINVAL; > > > > > > Again, please provide a suitable description for this change. > > I think the data size is not limited by MMC_BUS_WIDTH_x. > > I confirmed that data transmission of 2Byte was performed without a problem. > > This patch hasn't been picked up. I'm assuming that's because Andrew is > still unhappy with the changelog. Actually I don't know what happened with this. I merged it on July 8 and appear to have dropped it on July 27, but I can't find its removed-from-mm email so I don't know why I dropped it. Weird. Oh well, I merged it again. Is 2.6.37 an appropriate merge schedule? Also, I tend not to handle tmio_mmc patches - usually Paul patches that driver. > Andrew, how about something like, > > "When running in 4-bit bus width mode, it is entirely possible to > transfer data in block sizes of 2 bytes and larger. Relax the > conditional check to allow 2-byte data block transfers which were > previously disallowed." thanks. > Yusuke, have I interpreted your changelog correctly? Also note that > your patch should remove the comment above the conditional that says, > "Hardware cannot perform 1 and 2 byte requests in 4 bit mode". this? --- a/drivers/mmc/host/tmio_mmc.c~tmio_mmc-revise-a-limit-of-the-data-size-fix +++ a/drivers/mmc/host/tmio_mmc.c @@ -660,7 +660,6 @@ static int tmio_mmc_start_data(struct tm pr_debug("setup data transfer: blocksize %08x nr_blocks %d\n", data->blksz, data->blocks); - /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */ if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { pr_err("%s: %d byte block unsupported in 4 bit mode\n", mmc_hostname(host->mmc), data->blksz); _ ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] tmio_mmc: Revise a limit of the data size 2010-08-25 22:05 ` Andrew Morton @ 2010-08-25 22:19 ` Matt Fleming 2010-08-26 1:50 ` Ian Molton 1 sibling, 0 replies; 10+ messages in thread From: Matt Fleming @ 2010-08-25 22:19 UTC (permalink / raw) To: Andrew Morton; +Cc: Yusuke Goda, linux-mmc, Magnus Damm, Paul Mundt, Ian Molton On Wed, 25 Aug 2010 15:05:02 -0700 Andrew Morton <akpm@linux-foundation.org> wrote: > Actually I don't know what happened with this. I merged it on July 8 > and appear to have dropped it on July 27, but I can't find its > removed-from-mm email so I don't know why I dropped it. Weird. Oh, interesting. > Oh well, I merged it again. Is 2.6.37 an appropriate merge schedule? I'll defer that to Goda and Paul but that seems reasonable to me. > > Yusuke, have I interpreted your changelog correctly? Also note that > > your patch should remove the comment above the conditional that says, > > "Hardware cannot perform 1 and 2 byte requests in 4 bit mode". > > this? > > --- a/drivers/mmc/host/tmio_mmc.c~tmio_mmc-revise-a-limit-of-the-data-size-fix > +++ a/drivers/mmc/host/tmio_mmc.c > @@ -660,7 +660,6 @@ static int tmio_mmc_start_data(struct tm > pr_debug("setup data transfer: blocksize %08x nr_blocks %d\n", > data->blksz, data->blocks); > > - /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */ > if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { > pr_err("%s: %d byte block unsupported in 4 bit mode\n", > mmc_hostname(host->mmc), data->blksz); > _ > I was thinking more like changing the comment to say "Hardware cannot perform 1 byte requests in 4 bit mode" but that's evident from the check. So sure, removing it seems sane. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] tmio_mmc: Revise a limit of the data size 2010-08-25 22:05 ` Andrew Morton 2010-08-25 22:19 ` Matt Fleming @ 2010-08-26 1:50 ` Ian Molton 2010-08-26 7:24 ` Matt Fleming 1 sibling, 1 reply; 10+ messages in thread From: Ian Molton @ 2010-08-26 1:50 UTC (permalink / raw) To: Andrew Morton Cc: Matt Fleming, Yusuke Goda, linux-mmc, Magnus Damm, Paul Mundt Probably dropped because I complained about two things, 1) The patch doesnt check what the hardware is underneath before arbitrarily changing the parameters relied on by some hardware 2) Removing a comment I put there for a good reason without explaining why. "It works on my hardware" is not a good enough excuse. -- Ian Molton Linux, Automotive, and other hacking: http://www.mnementh.co.uk/ On 25 August 2010 23:05, Andrew Morton <akpm@linux-foundation.org> wrote: > On Wed, 25 Aug 2010 22:52:08 +0100 > Matt Fleming <matt@console-pimps.org> wrote: > >> On Tue, 13 Jul 2010 11:32:33 +0900 >> Yusuke Goda <yusuke.goda.sx@renesas.com> wrote: >> >> > Hi Andrew >> > >> > Andrew Morton wrote: >> > > On Wed, 07 Jul 2010 11:01:20 +0900 >> > > Yusuke Goda <yusuke.goda.sx@renesas.com> wrote: >> > > >> > >> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com> >> > >> --- >> > >> drivers/mmc/host/tmio_mmc.c | 2 +- >> > >> 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> >> > >> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c >> > >> index ee7d0a5..cac1c97 100644 >> > >> --- a/drivers/mmc/host/tmio_mmc.c >> > >> +++ b/drivers/mmc/host/tmio_mmc.c >> > >> @@ -661,7 +661,7 @@ static int tmio_mmc_start_data(struct tmio_mmc_host *host, >> > >> data->blksz, data->blocks); >> > >> >> > >> /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */ >> > >> - if (data->blksz < 4 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { >> > >> + if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { >> > >> pr_err("%s: %d byte block unsupported in 4 bit mode\n", >> > >> mmc_hostname(host->mmc), data->blksz); >> > >> return -EINVAL; >> > > >> > > Again, please provide a suitable description for this change. >> > I think the data size is not limited by MMC_BUS_WIDTH_x. >> > I confirmed that data transmission of 2Byte was performed without a problem. >> >> This patch hasn't been picked up. I'm assuming that's because Andrew is >> still unhappy with the changelog. > > Actually I don't know what happened with this. I merged it on July 8 > and appear to have dropped it on July 27, but I can't find its > removed-from-mm email so I don't know why I dropped it. Weird. > > Oh well, I merged it again. Is 2.6.37 an appropriate merge schedule? > > Also, I tend not to handle tmio_mmc patches - usually Paul patches that > driver. > >> Andrew, how about something like, >> >> "When running in 4-bit bus width mode, it is entirely possible to >> transfer data in block sizes of 2 bytes and larger. Relax the >> conditional check to allow 2-byte data block transfers which were >> previously disallowed." > > thanks. > >> Yusuke, have I interpreted your changelog correctly? Also note that >> your patch should remove the comment above the conditional that says, >> "Hardware cannot perform 1 and 2 byte requests in 4 bit mode". > > this? > > --- a/drivers/mmc/host/tmio_mmc.c~tmio_mmc-revise-a-limit-of-the-data-size-fix > +++ a/drivers/mmc/host/tmio_mmc.c > @@ -660,7 +660,6 @@ static int tmio_mmc_start_data(struct tm > pr_debug("setup data transfer: blocksize %08x nr_blocks %d\n", > data->blksz, data->blocks); > > - /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */ > if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { > pr_err("%s: %d byte block unsupported in 4 bit mode\n", > mmc_hostname(host->mmc), data->blksz); > _ > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] tmio_mmc: Revise a limit of the data size 2010-08-26 1:50 ` Ian Molton @ 2010-08-26 7:24 ` Matt Fleming 2010-08-26 7:26 ` Magnus Damm 0 siblings, 1 reply; 10+ messages in thread From: Matt Fleming @ 2010-08-26 7:24 UTC (permalink / raw) To: Ian Molton; +Cc: Andrew Morton, Yusuke Goda, linux-mmc, Magnus Damm, Paul Mundt On Thu, Aug 26, 2010 at 02:50:09AM +0100, Ian Molton wrote: > Probably dropped because I complained about two things, > > 1) The patch doesnt check what the hardware is underneath before > arbitrarily changing the parameters relied on by some hardware Has anyone thought about adding a caps or flags field to the tmio_mmc_host structure so that platform code set a bit if it can't do 2-byte data block transfers? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] tmio_mmc: Revise a limit of the data size 2010-08-26 7:24 ` Matt Fleming @ 2010-08-26 7:26 ` Magnus Damm 2010-08-26 10:28 ` Ian Molton 0 siblings, 1 reply; 10+ messages in thread From: Magnus Damm @ 2010-08-26 7:26 UTC (permalink / raw) To: Matt Fleming Cc: Ian Molton, Andrew Morton, Yusuke Goda, linux-mmc, Paul Mundt On Thu, Aug 26, 2010 at 4:24 PM, Matt Fleming <matt@console-pimps.org> wrote: > On Thu, Aug 26, 2010 at 02:50:09AM +0100, Ian Molton wrote: >> Probably dropped because I complained about two things, >> >> 1) The patch doesnt check what the hardware is underneath before >> arbitrarily changing the parameters relied on by some hardware > > Has anyone thought about adding a caps or flags field to the > tmio_mmc_host structure so that platform code set a bit if it can't do > 2-byte data block transfers? Good idea! There is already a good place available: >From include/linux/mfd/tmio.h: ... /* tmio MMC platform flags */ #define TMIO_MMC_WRPROTECT_DISABLE (1 << 0) Cheers, / magnus ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] tmio_mmc: Revise a limit of the data size 2010-08-26 7:26 ` Magnus Damm @ 2010-08-26 10:28 ` Ian Molton 0 siblings, 0 replies; 10+ messages in thread From: Ian Molton @ 2010-08-26 10:28 UTC (permalink / raw) To: Magnus Damm Cc: Matt Fleming, Andrew Morton, Yusuke Goda, linux-mmc, Paul Mundt @Matt: yes, thats what I was suggesting before. @Magnus: that looks fine. -- Ian Molton Linux, Automotive, and other hacking: http://www.mnementh.co.uk/ On 26 August 2010 08:26, Magnus Damm <magnus.damm@gmail.com> wrote: > On Thu, Aug 26, 2010 at 4:24 PM, Matt Fleming <matt@console-pimps.org> wrote: >> On Thu, Aug 26, 2010 at 02:50:09AM +0100, Ian Molton wrote: >>> Probably dropped because I complained about two things, >>> >>> 1) The patch doesnt check what the hardware is underneath before >>> arbitrarily changing the parameters relied on by some hardware >> >> Has anyone thought about adding a caps or flags field to the >> tmio_mmc_host structure so that platform code set a bit if it can't do >> 2-byte data block transfers? > > Good idea! There is already a good place available: > > From include/linux/mfd/tmio.h: > ... > /* tmio MMC platform flags */ > #define TMIO_MMC_WRPROTECT_DISABLE (1 << 0) > > Cheers, > > / magnus > ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-08-26 10:28 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-07-07 2:01 [PATCH] tmio_mmc: Revise a limit of the data size Yusuke Goda 2010-07-08 21:46 ` Andrew Morton 2010-07-13 2:32 ` Yusuke Goda 2010-08-25 21:52 ` Matt Fleming 2010-08-25 22:05 ` Andrew Morton 2010-08-25 22:19 ` Matt Fleming 2010-08-26 1:50 ` Ian Molton 2010-08-26 7:24 ` Matt Fleming 2010-08-26 7:26 ` Magnus Damm 2010-08-26 10:28 ` Ian Molton
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.