All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Sheng-Hui <crosslonelyover@gmail.com>
To: kernel-janitors <kernel-janitors@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH]trivial: clear the comment on parameters for ext2_xattr_set
Date: Tue, 13 Jul 2010 15:03:31 +0000	[thread overview]
Message-ID: <4C3C8043.3030700@gmail.com> (raw)

 Hi,

The comment for ext2_xattr_get is confusing for it has
no parameter named "buffer". I checked the code and think the
description is suitable for the parameter "value".
Following patch is against 2.6.35-rc5. Please check it.


Signed-off-by: Wang Sheng-Hui <crosslonelyover@gmail.com>
---
fs/ext2/xattr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
index 5ecbbd8..f56b599 100644
--- a/fs/ext2/xattr.c
+++ b/fs/ext2/xattr.c
@@ -355,7 +355,7 @@ static void ext2_xattr_update_super_block(struct
super_block *sb)
/*
* ext2_xattr_set()
*
- * Create, replace or remove an extended attribute for this inode. Buffer
+ * Create, replace or remove an extended attribute for this inode. Value
* is NULL to remove an existing extended attribute, and non-NULL to
* either replace an existing extended attribute, or create a new extended
* attribute. The flags XATTR_REPLACE and XATTR_CREATE
-- 
1.7.1.1


-- 
Thanks and Regards,
shenghui


WARNING: multiple messages have this Message-ID (diff)
From: Wang Sheng-Hui <crosslonelyover@gmail.com>
To: kernel-janitors <kernel-janitors@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH]trivial: clear the comment on parameters for ext2_xattr_set
Date: Tue, 13 Jul 2010 23:03:31 +0800	[thread overview]
Message-ID: <4C3C8043.3030700@gmail.com> (raw)

 Hi,

The comment for ext2_xattr_get is confusing for it has
no parameter named "buffer". I checked the code and think the
description is suitable for the parameter "value".
Following patch is against 2.6.35-rc5. Please check it.


Signed-off-by: Wang Sheng-Hui <crosslonelyover@gmail.com>
---
fs/ext2/xattr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
index 5ecbbd8..f56b599 100644
--- a/fs/ext2/xattr.c
+++ b/fs/ext2/xattr.c
@@ -355,7 +355,7 @@ static void ext2_xattr_update_super_block(struct
super_block *sb)
/*
* ext2_xattr_set()
*
- * Create, replace or remove an extended attribute for this inode. Buffer
+ * Create, replace or remove an extended attribute for this inode. Value
* is NULL to remove an existing extended attribute, and non-NULL to
* either replace an existing extended attribute, or create a new extended
* attribute. The flags XATTR_REPLACE and XATTR_CREATE
-- 
1.7.1.1


-- 
Thanks and Regards,
shenghui


             reply	other threads:[~2010-07-13 15:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13 15:03 Wang Sheng-Hui [this message]
2010-07-13 15:03 ` [PATCH]trivial: clear the comment on parameters for ext2_xattr_set Wang Sheng-Hui
2010-07-13 19:24 ` [PATCH]trivial: clear the comment on parameters for Dan Carpenter
2010-07-13 19:24   ` [PATCH]trivial: clear the comment on parameters for ext2_xattr_set Dan Carpenter
2010-07-14  0:51 ` shenghui
2010-07-14  0:51   ` shenghui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3C8043.3030700@gmail.com \
    --to=crosslonelyover@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.