All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	KVM list <kvm@vger.kernel.org>,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 3/4] KVM: MMU: track dirty page in speculative path properly
Date: Wed, 14 Jul 2010 13:53:27 +0800	[thread overview]
Message-ID: <4C3D50D7.9010207@cn.fujitsu.com> (raw)
In-Reply-To: <4C3C35B7.50101@cn.fujitsu.com>



Xiao Guangrong wrote:

>  
>  		spte = rmap_next(kvm, rmapp, NULL);
> @@ -1879,9 +1877,9 @@ static int set_spte(struct kvm_vcpu *vcpu, u64 *sptep,
>  	 * whether the guest actually used the pte (in order to detect
>  	 * demand paging).
>  	 */
> -	spte = shadow_base_present_pte | shadow_dirty_mask;
> +	spte = shadow_base_present_pte;
>  	if (!speculative)
> -		spte |= shadow_accessed_mask;
> +		spte |= shadow_accessed_mask | shadow_dirty_mask;

It breaks read-only shadow page, i'll update it... please ignore this version...

  parent reply	other threads:[~2010-07-14  5:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13  9:42 [PATCH 1/4] KVM: MMU: fix forgot reserved bits check in speculative path Xiao Guangrong
2010-07-13  9:43 ` [PATCH 2/4] KVM: MMU: cleanup spte update path Xiao Guangrong
2010-07-13  9:45 ` [PATCH 3/4] KVM: MMU: track dirty page in speculative path properly Xiao Guangrong
2010-07-13 22:05   ` Marcelo Tosatti
2010-07-14  1:24     ` Xiao Guangrong
2010-07-14 11:09       ` Marcelo Tosatti
2010-07-14 13:18         ` Xiao Guangrong
2010-07-14 14:06           ` Marcelo Tosatti
2010-07-14 14:25             ` Avi Kivity
2010-07-15  7:44             ` Xiao Guangrong
2010-07-15 16:40               ` Marcelo Tosatti
2010-07-16  1:58                 ` Xiao Guangrong
2010-07-14  5:53   ` Xiao Guangrong [this message]
2010-07-13  9:46 ` [PATCH 4/4] KVM: MMU: remove valueless output message Xiao Guangrong
2010-07-13 21:28 ` [PATCH 1/4] KVM: MMU: fix forgot reserved bits check in speculative path Marcelo Tosatti
2010-07-14  1:08   ` Xiao Guangrong
2010-07-14 13:06 ` Avi Kivity
2010-07-14 13:24   ` Xiao Guangrong
2010-07-14 14:27     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3D50D7.9010207@cn.fujitsu.com \
    --to=xiaoguangrong@cn.fujitsu.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.