* Re:[Patch] configure --help message for grub-emu
@ 2010-07-14 3:23 Jason Butler
2010-07-14 12:31 ` [Patch] " Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 3+ messages in thread
From: Jason Butler @ 2010-07-14 3:23 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]
Here is a patch to have configure --help print the build instructions for grub-emu
--- On Tue, 7/13/10, Colin Watson <cjwatson@ubuntu.com> wrote:
> From: Colin Watson <cjwatson@ubuntu.com>
> Subject: Re: configure --help message for grub-emu
> To: "The development of GNU GRUB" <grub-devel@gnu.org>
> Received: Tuesday, July 13, 2010, 2:15 AM
> On Mon, Jul 12, 2010 at 06:59:10PM
> -0700, Jason Butler wrote:
> > I want to alter the configure script so the --help
> prints the
> > instructions for building grub-emu. I saw it was asked
> a couple times
> > in #grub where to get it. I think this means altering
> the configure.ac
> > file but some open source projects generate
> configure.ac from a
> > script.
>
> This is rare; configure.ac is normally a source file.
>
> > Is configure.ac the correct file to alter?
>
> Yes.
>
> --
> Colin Watson
>
> [cjwatson@ubuntu.com]
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: configureHelpPatch.patch --]
[-- Type: application/octet-stream, Size: 526 bytes --]
--- grub-1.98/configure.ac 2010-07-13 11:14:17.122937584 -0400
+++ grub-1.98/configure.new.ac 2010-07-12 12:09:38.227813199 -0400
@@ -68,7 +68,7 @@ esac
# Specify the platform (such as firmware).
AC_ARG_WITH([platform],
AS_HELP_STRING([--with-platform=PLATFORM],
- [select the host platform [[guessed]]]))
+ [select the host platform [[guessed]] for grub-emu use emu],[26],[65]))
# Guess the platform if not specified.
if test "x$with_platform" = x; then
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Patch] configure --help message for grub-emu
2010-07-14 3:23 Re:[Patch] configure --help message for grub-emu Jason Butler
@ 2010-07-14 12:31 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-07-15 15:40 ` Jason Butler
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2010-07-14 12:31 UTC (permalink / raw)
To: grub-devel
[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]
On 07/14/2010 05:23 AM, Jason Butler wrote:
> Here is a patch to have configure --help print the build instructions for grub-emu
>
>
I'm fine with the principle. However in your patch the syntax of help
message seems unclear for me. Is it 2 sentences? If it's the same
sentence as the punctuation suggests then it sounds like
"select the host platform for grub-emu"
I recommend asking someone with English native language to fix this.
> --- On Tue, 7/13/10, Colin Watson <cjwatson@ubuntu.com> wrote:
>
>
>> From: Colin Watson <cjwatson@ubuntu.com>
>> Subject: Re: configure --help message for grub-emu
>> To: "The development of GNU GRUB" <grub-devel@gnu.org>
>> Received: Tuesday, July 13, 2010, 2:15 AM
>> On Mon, Jul 12, 2010 at 06:59:10PM
>> -0700, Jason Butler wrote:
>>
>>> I want to alter the configure script so the --help
>>>
>> prints the
>>
>>> instructions for building grub-emu. I saw it was asked
>>>
>> a couple times
>>
>>> in #grub where to get it. I think this means altering
>>>
>> the configure.ac
>>
>>> file but some open source projects generate
>>>
>> configure.ac from a
>>
>>> script.
>>>
>> This is rare; configure.ac is normally a source file.
>>
>>
>>> Is configure.ac the correct file to alter?
>>>
>> Yes.
>>
>> --
>> Colin Watson
>>
>> [cjwatson@ubuntu.com]
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] configure --help message for grub-emu
2010-07-14 12:31 ` [Patch] " Vladimir 'φ-coder/phcoder' Serbinenko
@ 2010-07-15 15:40 ` Jason Butler
0 siblings, 0 replies; 3+ messages in thread
From: Jason Butler @ 2010-07-15 15:40 UTC (permalink / raw)
To: The development of GNU GRUB
What if it said "select the host platform [guessed]. To build grub-emu use the option --with-platform=emu"
It would just be a little long.
--- On Wed, 7/14/10, Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> wrote:
> From: Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com>
> Subject: Re: [Patch] configure --help message for grub-emu
> To: grub-devel@gnu.org
> Received: Wednesday, July 14, 2010, 12:31 PM
> On 07/14/2010 05:23 AM, Jason Butler
> wrote:
> > Here is a patch to have configure --help print the
> build instructions for grub-emu
> >
> >
> I'm fine with the principle. However in your patch the
> syntax of help
> message seems unclear for me. Is it 2 sentences? If it's
> the same
> sentence as the punctuation suggests then it sounds like
> "select the host platform for grub-emu"
> I recommend asking someone with English native language to
> fix this.
>
> > --- On Tue, 7/13/10, Colin Watson <cjwatson@ubuntu.com>
> wrote:
> >
> >
> >> From: Colin Watson <cjwatson@ubuntu.com>
> >> Subject: Re: configure --help message for
> grub-emu
> >> To: "The development of GNU GRUB" <grub-devel@gnu.org>
> >> Received: Tuesday, July 13, 2010, 2:15 AM
> >> On Mon, Jul 12, 2010 at 06:59:10PM
> >> -0700, Jason Butler wrote:
> >>
> >>> I want to alter the configure script so the
> --help
> >>>
> >> prints the
> >>
> >>> instructions for building grub-emu. I saw it
> was asked
> >>>
> >> a couple times
> >>
> >>> in #grub where to get it. I think this means
> altering
> >>>
> >> the configure.ac
> >>
> >>> file but some open source projects generate
> >>>
> >> configure.ac from a
> >>
> >>> script.
> >>>
> >> This is rare; configure.ac is normally a source
> file.
> >>
> >>
> >>> Is configure.ac the correct file to alter?
> >>>
> >> Yes.
> >>
> >> --
> >> Colin Watson
>
> >>
>
> >> [cjwatson@ubuntu.com]
> >>
> >> _______________________________________________
> >> Grub-devel mailing list
> >> Grub-devel@gnu.org
> >> http://lists.gnu.org/mailman/listinfo/grub-devel
> >>
> >>
> >
> >
> >
> > _______________________________________________
> > Grub-devel mailing list
> > Grub-devel@gnu.org
> > http://lists.gnu.org/mailman/listinfo/grub-devel
> >
>
>
> --
> Regards
> Vladimir 'φ-coder/phcoder' Serbinenko
>
>
>
> -----Inline Attachment Follows-----
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-15 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-14 3:23 Re:[Patch] configure --help message for grub-emu Jason Butler
2010-07-14 12:31 ` [Patch] " Vladimir 'φ-coder/phcoder' Serbinenko
2010-07-15 15:40 ` Jason Butler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.