From: Jiri Slaby <jirislaby@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org,
Javier Martinez Canillas <martinez.javier@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org,
Dominik Brodowski <linux@dominikbrodowski.net>,
Alexander Kurz <linux@kbdbabel.org>
Subject: Re: [PATCH 09/11] staging: comedi: formatting of pointers in printk()
Date: Thu, 15 Jul 2010 06:46:29 +0000 [thread overview]
Message-ID: <4C3EAEC5.8080908@gmail.com> (raw)
In-Reply-To: <1279176172-5609-1-git-send-email-segooon@gmail.com>
On 07/15/2010 08:42 AM, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index 8d16380..8b49cb1 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
The name and parameters suggest to remove the function completely. (And
use print_hex_dump_bytes instead.)
>
> for (i = 0; i < len; i++) {
> if (i % 16 = 0)
> - printk("\n0x%08x:", (unsigned int)cptr);
> + printk("\n%p:", cptr);
>
> printk(" %02x", *(cptr++));
> }
--
js
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org,
Javier Martinez Canillas <martinez.javier@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org,
Dominik Brodowski <linux@dominikbrodowski.net>,
Alexander Kurz <linux@kbdbabel.org>
Subject: Re: [PATCH 09/11] staging: comedi: formatting of pointers in printk()
Date: Thu, 15 Jul 2010 08:46:29 +0200 [thread overview]
Message-ID: <4C3EAEC5.8080908@gmail.com> (raw)
In-Reply-To: <1279176172-5609-1-git-send-email-segooon@gmail.com>
On 07/15/2010 08:42 AM, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
> ---
> drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index 8d16380..8b49cb1 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -208,7 +208,7 @@ static void hex_dump(char *str, void *ptr, int len)
The name and parameters suggest to remove the function completely. (And
use print_hex_dump_bytes instead.)
>
> for (i = 0; i < len; i++) {
> if (i % 16 == 0)
> - printk("\n0x%08x:", (unsigned int)cptr);
> + printk("\n%p:", cptr);
>
> printk(" %02x", *(cptr++));
> }
--
js
next prev parent reply other threads:[~2010-07-15 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 6:42 [PATCH 09/11] staging: comedi: formatting of pointers in printk() Kulikov Vasiliy
2010-07-15 6:42 ` Kulikov Vasiliy
2010-07-15 6:46 ` Jiri Slaby [this message]
2010-07-15 6:46 ` Jiri Slaby
2010-07-22 18:45 ` [PATCH 09/11] staging: comedi: formatting of pointers in Greg KH
2010-07-22 18:45 ` [PATCH 09/11] staging: comedi: formatting of pointers in printk() Greg KH
2010-07-22 18:51 ` [PATCH 09/11] staging: comedi: formatting of pointers in Joe Perches
2010-07-22 18:51 ` [PATCH 09/11] staging: comedi: formatting of pointers in printk() Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3EAEC5.8080908@gmail.com \
--to=jirislaby@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=linux@kbdbabel.org \
--cc=martinez.javier@gmail.com \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.