* [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk()
@ 2010-07-14 18:01 ` Kulikov Vasiliy
0 siblings, 0 replies; 8+ messages in thread
From: Kulikov Vasiliy @ 2010-07-14 18:01 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Ungerer, John Kacur, Tejun Heo, Maxim Kuvyrkov,
Thomas Gleixner, linux-kernel
Use %p instead of %08x in printk().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
arch/m68knommu/kernel/process.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
index 6aa6613..1096c0e 100644
--- a/arch/m68knommu/kernel/process.c
+++ b/arch/m68knommu/kernel/process.c
@@ -316,14 +316,14 @@ void dump(struct pt_regs *fp)
fp->d0, fp->d1, fp->d2, fp->d3);
printk(KERN_EMERG "d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
fp->d4, fp->d5, fp->a0, fp->a1);
- printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %08x\n",
- (unsigned int) rdusp(), (unsigned int) fp);
+ printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %p\n",
+ (unsigned int) rdusp(), fp);
printk(KERN_EMERG "\nCODE:");
tp = ((unsigned char *) fp->pc) - 0x20;
for (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) {
if ((i % 0x10) = 0)
- printk(KERN_EMERG "%08x: ", (int) (tp + i));
+ printk(KERN_EMERG "%p: ", tp + i);
printk("%08x ", (int) *sp++);
}
printk(KERN_EMERG "\n");
@@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)
tp = ((unsigned char *) fp) - 0x40;
for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {
if ((i % 0x10) = 0)
- printk(KERN_EMERG "%08x: ", (int) (tp + i));
+ printk(KERN_EMERG "%p: ", tp + i);
printk("%08x ", (int) *sp++);
}
printk(KERN_EMERG "\n");
@@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)
tp = (unsigned char *) (rdusp() - 0x10);
for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {
if ((i % 0x10) = 0)
- printk(KERN_EMERG "%08x: ", (int) (tp + i));
+ printk(KERN_EMERG "%p: ", tp + i);
printk("%08x ", (int) *sp++);
}
printk(KERN_EMERG "\n");
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk()
@ 2010-07-14 18:01 ` Kulikov Vasiliy
0 siblings, 0 replies; 8+ messages in thread
From: Kulikov Vasiliy @ 2010-07-14 18:01 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Ungerer, John Kacur, Tejun Heo, Maxim Kuvyrkov,
Thomas Gleixner, linux-kernel
Use %p instead of %08x in printk().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
arch/m68knommu/kernel/process.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
index 6aa6613..1096c0e 100644
--- a/arch/m68knommu/kernel/process.c
+++ b/arch/m68knommu/kernel/process.c
@@ -316,14 +316,14 @@ void dump(struct pt_regs *fp)
fp->d0, fp->d1, fp->d2, fp->d3);
printk(KERN_EMERG "d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
fp->d4, fp->d5, fp->a0, fp->a1);
- printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %08x\n",
- (unsigned int) rdusp(), (unsigned int) fp);
+ printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %p\n",
+ (unsigned int) rdusp(), fp);
printk(KERN_EMERG "\nCODE:");
tp = ((unsigned char *) fp->pc) - 0x20;
for (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) {
if ((i % 0x10) == 0)
- printk(KERN_EMERG "%08x: ", (int) (tp + i));
+ printk(KERN_EMERG "%p: ", tp + i);
printk("%08x ", (int) *sp++);
}
printk(KERN_EMERG "\n");
@@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)
tp = ((unsigned char *) fp) - 0x40;
for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {
if ((i % 0x10) == 0)
- printk(KERN_EMERG "%08x: ", (int) (tp + i));
+ printk(KERN_EMERG "%p: ", tp + i);
printk("%08x ", (int) *sp++);
}
printk(KERN_EMERG "\n");
@@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)
tp = (unsigned char *) (rdusp() - 0x10);
for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {
if ((i % 0x10) == 0)
- printk(KERN_EMERG "%08x: ", (int) (tp + i));
+ printk(KERN_EMERG "%p: ", tp + i);
printk("%08x ", (int) *sp++);
}
printk(KERN_EMERG "\n");
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of
2010-07-14 18:01 ` Kulikov Vasiliy
@ 2010-07-15 0:29 ` Greg Ungerer
-1 siblings, 0 replies; 8+ messages in thread
From: Greg Ungerer @ 2010-07-15 0:29 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Ungerer, John Kacur, Tejun Heo,
Maxim Kuvyrkov, Thomas Gleixner, linux-kernel
Hi Kulikov,
Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Acked-by: Greg Ungerer <gerg@uclinux.org>
Do you want me to push this to Linus via the m68knommu git tree?
Regards
Greg
> ---
> arch/m68knommu/kernel/process.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
> index 6aa6613..1096c0e 100644
> --- a/arch/m68knommu/kernel/process.c
> +++ b/arch/m68knommu/kernel/process.c
> @@ -316,14 +316,14 @@ void dump(struct pt_regs *fp)
> fp->d0, fp->d1, fp->d2, fp->d3);
> printk(KERN_EMERG "d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
> fp->d4, fp->d5, fp->a0, fp->a1);
> - printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %08x\n",
> - (unsigned int) rdusp(), (unsigned int) fp);
> + printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %p\n",
> + (unsigned int) rdusp(), fp);
>
> printk(KERN_EMERG "\nCODE:");
> tp = ((unsigned char *) fp->pc) - 0x20;
> for (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) {
> if ((i % 0x10) = 0)
> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
> + printk(KERN_EMERG "%p: ", tp + i);
> printk("%08x ", (int) *sp++);
> }
> printk(KERN_EMERG "\n");
> @@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)
> tp = ((unsigned char *) fp) - 0x40;
> for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {
> if ((i % 0x10) = 0)
> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
> + printk(KERN_EMERG "%p: ", tp + i);
> printk("%08x ", (int) *sp++);
> }
> printk(KERN_EMERG "\n");
> @@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)
> tp = (unsigned char *) (rdusp() - 0x10);
> for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {
> if ((i % 0x10) = 0)
> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
> + printk(KERN_EMERG "%p: ", tp + i);
> printk("%08x ", (int) *sp++);
> }
> printk(KERN_EMERG "\n");
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk()
@ 2010-07-15 0:29 ` Greg Ungerer
0 siblings, 0 replies; 8+ messages in thread
From: Greg Ungerer @ 2010-07-15 0:29 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Ungerer, John Kacur, Tejun Heo,
Maxim Kuvyrkov, Thomas Gleixner, linux-kernel
Hi Kulikov,
Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Acked-by: Greg Ungerer <gerg@uclinux.org>
Do you want me to push this to Linus via the m68knommu git tree?
Regards
Greg
> ---
> arch/m68knommu/kernel/process.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
> index 6aa6613..1096c0e 100644
> --- a/arch/m68knommu/kernel/process.c
> +++ b/arch/m68knommu/kernel/process.c
> @@ -316,14 +316,14 @@ void dump(struct pt_regs *fp)
> fp->d0, fp->d1, fp->d2, fp->d3);
> printk(KERN_EMERG "d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
> fp->d4, fp->d5, fp->a0, fp->a1);
> - printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %08x\n",
> - (unsigned int) rdusp(), (unsigned int) fp);
> + printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %p\n",
> + (unsigned int) rdusp(), fp);
>
> printk(KERN_EMERG "\nCODE:");
> tp = ((unsigned char *) fp->pc) - 0x20;
> for (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) {
> if ((i % 0x10) == 0)
> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
> + printk(KERN_EMERG "%p: ", tp + i);
> printk("%08x ", (int) *sp++);
> }
> printk(KERN_EMERG "\n");
> @@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)
> tp = ((unsigned char *) fp) - 0x40;
> for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {
> if ((i % 0x10) == 0)
> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
> + printk(KERN_EMERG "%p: ", tp + i);
> printk("%08x ", (int) *sp++);
> }
> printk(KERN_EMERG "\n");
> @@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)
> tp = (unsigned char *) (rdusp() - 0x10);
> for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {
> if ((i % 0x10) == 0)
> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
> + printk(KERN_EMERG "%p: ", tp + i);
> printk("%08x ", (int) *sp++);
> }
> printk(KERN_EMERG "\n");
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of
2010-07-15 0:29 ` [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk() Greg Ungerer
@ 2010-07-15 6:43 ` Kulikov Vasiliy
-1 siblings, 0 replies; 8+ messages in thread
From: Kulikov Vasiliy @ 2010-07-15 6:43 UTC (permalink / raw)
To: Greg Ungerer
Cc: kernel-janitors, Greg Ungerer, John Kacur, Tejun Heo,
Maxim Kuvyrkov, Thomas Gleixner, linux-kernel
On Thu, Jul 15, 2010 at 10:29 +1000, Greg Ungerer wrote:
> Hi Kulikov,
>
> Kulikov Vasiliy wrote:
> >Use %p instead of %08x in printk().
> >
> >Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>
> Acked-by: Greg Ungerer <gerg@uclinux.org>
>
> Do you want me to push this to Linus via the m68knommu git tree?
Yeah, it would be good.
>
> Regards
> Greg
>
>
>
> >---
> > arch/m68knommu/kernel/process.c | 10 +++++-----
> > 1 files changed, 5 insertions(+), 5 deletions(-)
> >
> >diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
> >index 6aa6613..1096c0e 100644
> >--- a/arch/m68knommu/kernel/process.c
> >+++ b/arch/m68knommu/kernel/process.c
> >@@ -316,14 +316,14 @@ void dump(struct pt_regs *fp)
> > fp->d0, fp->d1, fp->d2, fp->d3);
> > printk(KERN_EMERG "d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
> > fp->d4, fp->d5, fp->a0, fp->a1);
> >- printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %08x\n",
> >- (unsigned int) rdusp(), (unsigned int) fp);
> >+ printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %p\n",
> >+ (unsigned int) rdusp(), fp);
> > printk(KERN_EMERG "\nCODE:");
> > tp = ((unsigned char *) fp->pc) - 0x20;
> > for (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) {
> > if ((i % 0x10) = 0)
> >- printk(KERN_EMERG "%08x: ", (int) (tp + i));
> >+ printk(KERN_EMERG "%p: ", tp + i);
> > printk("%08x ", (int) *sp++);
> > }
> > printk(KERN_EMERG "\n");
> >@@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)
> > tp = ((unsigned char *) fp) - 0x40;
> > for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {
> > if ((i % 0x10) = 0)
> >- printk(KERN_EMERG "%08x: ", (int) (tp + i));
> >+ printk(KERN_EMERG "%p: ", tp + i);
> > printk("%08x ", (int) *sp++);
> > }
> > printk(KERN_EMERG "\n");
> >@@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)
> > tp = (unsigned char *) (rdusp() - 0x10);
> > for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {
> > if ((i % 0x10) = 0)
> >- printk(KERN_EMERG "%08x: ", (int) (tp + i));
> >+ printk(KERN_EMERG "%p: ", tp + i);
> > printk("%08x ", (int) *sp++);
> > }
> > printk(KERN_EMERG "\n");
>
>
> --
> ------------------------------------------------------------------------
> Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
> SnapGear Group, McAfee PHONE: +61 7 3435 2888
> 8 Gardner Close FAX: +61 7 3217 5323
> Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk()
@ 2010-07-15 6:43 ` Kulikov Vasiliy
0 siblings, 0 replies; 8+ messages in thread
From: Kulikov Vasiliy @ 2010-07-15 6:43 UTC (permalink / raw)
To: Greg Ungerer
Cc: kernel-janitors, Greg Ungerer, John Kacur, Tejun Heo,
Maxim Kuvyrkov, Thomas Gleixner, linux-kernel
On Thu, Jul 15, 2010 at 10:29 +1000, Greg Ungerer wrote:
> Hi Kulikov,
>
> Kulikov Vasiliy wrote:
> >Use %p instead of %08x in printk().
> >
> >Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>
> Acked-by: Greg Ungerer <gerg@uclinux.org>
>
> Do you want me to push this to Linus via the m68knommu git tree?
Yeah, it would be good.
>
> Regards
> Greg
>
>
>
> >---
> > arch/m68knommu/kernel/process.c | 10 +++++-----
> > 1 files changed, 5 insertions(+), 5 deletions(-)
> >
> >diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
> >index 6aa6613..1096c0e 100644
> >--- a/arch/m68knommu/kernel/process.c
> >+++ b/arch/m68knommu/kernel/process.c
> >@@ -316,14 +316,14 @@ void dump(struct pt_regs *fp)
> > fp->d0, fp->d1, fp->d2, fp->d3);
> > printk(KERN_EMERG "d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
> > fp->d4, fp->d5, fp->a0, fp->a1);
> >- printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %08x\n",
> >- (unsigned int) rdusp(), (unsigned int) fp);
> >+ printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %p\n",
> >+ (unsigned int) rdusp(), fp);
> > printk(KERN_EMERG "\nCODE:");
> > tp = ((unsigned char *) fp->pc) - 0x20;
> > for (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) {
> > if ((i % 0x10) == 0)
> >- printk(KERN_EMERG "%08x: ", (int) (tp + i));
> >+ printk(KERN_EMERG "%p: ", tp + i);
> > printk("%08x ", (int) *sp++);
> > }
> > printk(KERN_EMERG "\n");
> >@@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)
> > tp = ((unsigned char *) fp) - 0x40;
> > for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {
> > if ((i % 0x10) == 0)
> >- printk(KERN_EMERG "%08x: ", (int) (tp + i));
> >+ printk(KERN_EMERG "%p: ", tp + i);
> > printk("%08x ", (int) *sp++);
> > }
> > printk(KERN_EMERG "\n");
> >@@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)
> > tp = (unsigned char *) (rdusp() - 0x10);
> > for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {
> > if ((i % 0x10) == 0)
> >- printk(KERN_EMERG "%08x: ", (int) (tp + i));
> >+ printk(KERN_EMERG "%p: ", tp + i);
> > printk("%08x ", (int) *sp++);
> > }
> > printk(KERN_EMERG "\n");
>
>
> --
> ------------------------------------------------------------------------
> Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
> SnapGear Group, McAfee PHONE: +61 7 3435 2888
> 8 Gardner Close FAX: +61 7 3217 5323
> Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of
2010-07-15 6:43 ` [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk() Kulikov Vasiliy
@ 2010-07-15 6:52 ` Greg Ungerer
-1 siblings, 0 replies; 8+ messages in thread
From: Greg Ungerer @ 2010-07-15 6:52 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Ungerer, John Kacur, Tejun Heo,
Maxim Kuvyrkov, Thomas Gleixner, linux-kernel
Kulikov Vasiliy wrote:
> On Thu, Jul 15, 2010 at 10:29 +1000, Greg Ungerer wrote:
>> Hi Kulikov,
>>
>> Kulikov Vasiliy wrote:
>>> Use %p instead of %08x in printk().
>>>
>>> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>> Acked-by: Greg Ungerer <gerg@uclinux.org>
>>
>> Do you want me to push this to Linus via the m68knommu git tree?
> Yeah, it would be good.
OK, done.
Thanks
Greg
>> Regards
>> Greg
>>
>>
>>
>>> ---
>>> arch/m68knommu/kernel/process.c | 10 +++++-----
>>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
>>> index 6aa6613..1096c0e 100644
>>> --- a/arch/m68knommu/kernel/process.c
>>> +++ b/arch/m68knommu/kernel/process.c
>>> @@ -316,14 +316,14 @@ void dump(struct pt_regs *fp)
>>> fp->d0, fp->d1, fp->d2, fp->d3);
>>> printk(KERN_EMERG "d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
>>> fp->d4, fp->d5, fp->a0, fp->a1);
>>> - printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %08x\n",
>>> - (unsigned int) rdusp(), (unsigned int) fp);
>>> + printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %p\n",
>>> + (unsigned int) rdusp(), fp);
>>> printk(KERN_EMERG "\nCODE:");
>>> tp = ((unsigned char *) fp->pc) - 0x20;
>>> for (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) {
>>> if ((i % 0x10) = 0)
>>> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
>>> + printk(KERN_EMERG "%p: ", tp + i);
>>> printk("%08x ", (int) *sp++);
>>> }
>>> printk(KERN_EMERG "\n");
>>> @@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)
>>> tp = ((unsigned char *) fp) - 0x40;
>>> for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {
>>> if ((i % 0x10) = 0)
>>> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
>>> + printk(KERN_EMERG "%p: ", tp + i);
>>> printk("%08x ", (int) *sp++);
>>> }
>>> printk(KERN_EMERG "\n");
>>> @@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)
>>> tp = (unsigned char *) (rdusp() - 0x10);
>>> for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {
>>> if ((i % 0x10) = 0)
>>> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
>>> + printk(KERN_EMERG "%p: ", tp + i);
>>> printk("%08x ", (int) *sp++);
>>> }
>>> printk(KERN_EMERG "\n");
>>
>> --
>> ------------------------------------------------------------------------
>> Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
>> SnapGear Group, McAfee PHONE: +61 7 3435 2888
>> 8 Gardner Close FAX: +61 7 3217 5323
>> Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk()
@ 2010-07-15 6:52 ` Greg Ungerer
0 siblings, 0 replies; 8+ messages in thread
From: Greg Ungerer @ 2010-07-15 6:52 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Greg Ungerer, John Kacur, Tejun Heo,
Maxim Kuvyrkov, Thomas Gleixner, linux-kernel
Kulikov Vasiliy wrote:
> On Thu, Jul 15, 2010 at 10:29 +1000, Greg Ungerer wrote:
>> Hi Kulikov,
>>
>> Kulikov Vasiliy wrote:
>>> Use %p instead of %08x in printk().
>>>
>>> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
>> Acked-by: Greg Ungerer <gerg@uclinux.org>
>>
>> Do you want me to push this to Linus via the m68knommu git tree?
> Yeah, it would be good.
OK, done.
Thanks
Greg
>> Regards
>> Greg
>>
>>
>>
>>> ---
>>> arch/m68knommu/kernel/process.c | 10 +++++-----
>>> 1 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/m68knommu/kernel/process.c b/arch/m68knommu/kernel/process.c
>>> index 6aa6613..1096c0e 100644
>>> --- a/arch/m68knommu/kernel/process.c
>>> +++ b/arch/m68knommu/kernel/process.c
>>> @@ -316,14 +316,14 @@ void dump(struct pt_regs *fp)
>>> fp->d0, fp->d1, fp->d2, fp->d3);
>>> printk(KERN_EMERG "d4: %08lx d5: %08lx a0: %08lx a1: %08lx\n",
>>> fp->d4, fp->d5, fp->a0, fp->a1);
>>> - printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %08x\n",
>>> - (unsigned int) rdusp(), (unsigned int) fp);
>>> + printk(KERN_EMERG "\nUSP: %08x TRAPFRAME: %p\n",
>>> + (unsigned int) rdusp(), fp);
>>> printk(KERN_EMERG "\nCODE:");
>>> tp = ((unsigned char *) fp->pc) - 0x20;
>>> for (sp = (unsigned long *) tp, i = 0; (i < 0x40); i += 4) {
>>> if ((i % 0x10) == 0)
>>> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
>>> + printk(KERN_EMERG "%p: ", tp + i);
>>> printk("%08x ", (int) *sp++);
>>> }
>>> printk(KERN_EMERG "\n");
>>> @@ -332,7 +332,7 @@ void dump(struct pt_regs *fp)
>>> tp = ((unsigned char *) fp) - 0x40;
>>> for (sp = (unsigned long *) tp, i = 0; (i < 0xc0); i += 4) {
>>> if ((i % 0x10) == 0)
>>> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
>>> + printk(KERN_EMERG "%p: ", tp + i);
>>> printk("%08x ", (int) *sp++);
>>> }
>>> printk(KERN_EMERG "\n");
>>> @@ -341,7 +341,7 @@ void dump(struct pt_regs *fp)
>>> tp = (unsigned char *) (rdusp() - 0x10);
>>> for (sp = (unsigned long *) tp, i = 0; (i < 0x80); i += 4) {
>>> if ((i % 0x10) == 0)
>>> - printk(KERN_EMERG "%08x: ", (int) (tp + i));
>>> + printk(KERN_EMERG "%p: ", tp + i);
>>> printk("%08x ", (int) *sp++);
>>> }
>>> printk(KERN_EMERG "\n");
>>
>> --
>> ------------------------------------------------------------------------
>> Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
>> SnapGear Group, McAfee PHONE: +61 7 3435 2888
>> 8 Gardner Close FAX: +61 7 3217 5323
>> Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-07-15 6:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-14 18:01 [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk() Kulikov Vasiliy
2010-07-14 18:01 ` Kulikov Vasiliy
2010-07-15 0:29 ` [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of Greg Ungerer
2010-07-15 0:29 ` [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk() Greg Ungerer
2010-07-15 6:43 ` [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of Kulikov Vasiliy
2010-07-15 6:43 ` [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk() Kulikov Vasiliy
2010-07-15 6:52 ` [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of Greg Ungerer
2010-07-15 6:52 ` [PATCH 02/11] arch/m68knommu/kernel/process.c: formatting of pointers in printk() Greg Ungerer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.