* [PATCH 1/1] SQUASHME pnfs-submit pnfs operations use new nfs4_sequence_done
@ 2010-07-16 15:56 andros
2010-07-16 15:56 ` andros
0 siblings, 1 reply; 4+ messages in thread
From: andros @ 2010-07-16 15:56 UTC (permalink / raw)
To: bhalevy; +Cc: linux-nfs, Andy Adamson
From: Andy Adamson <andros@netapp.com>
Signed-off-by: Andy Adamson <andros@netapp.com>
---
fs/nfs/nfs4proc.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index f5779a1..17b0c31 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5448,7 +5448,7 @@ static void nfs4_pnfs_layoutget_done(struct rpc_task *task, void *calldata)
dprintk("--> %s\n", __func__);
- nfs4_sequence_done(server, &lgp->res.seq_res, task->tk_status);
+ nfs4_sequence_done(task, &lgp->res.seq_res);
if (RPC_ASSASSINATED(task))
return;
@@ -5558,7 +5558,7 @@ pnfs_layoutcommit_done(struct rpc_task *task, void *calldata)
(struct pnfs_layoutcommit_data *)calldata;
struct nfs_server *server = NFS_SERVER(data->args.inode);
- nfs4_sequence_done(server, &data->res.seq_res, task->tk_status);
+ nfs4_sequence_done(task, &data->res.seq_res);
if (RPC_ASSASSINATED(task))
return;
@@ -5666,7 +5666,7 @@ static void nfs4_pnfs_layoutreturn_done(struct rpc_task *task, void *calldata)
dprintk("--> %s\n", __func__);
- nfs4_sequence_done(server, &lrp->res.seq_res, task->tk_status);
+ nfs4_sequence_done(task, &lrp->res.seq_res);
if (RPC_ASSASSINATED(task))
return;
--
1.6.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 1/1] SQUASHME pnfs-submit pnfs operations use new nfs4_sequence_done
2010-07-16 15:56 [PATCH 1/1] SQUASHME pnfs-submit pnfs operations use new nfs4_sequence_done andros
@ 2010-07-16 15:56 ` andros
2010-07-19 8:46 ` Benny Halevy
0 siblings, 1 reply; 4+ messages in thread
From: andros @ 2010-07-16 15:56 UTC (permalink / raw)
To: bhalevy; +Cc: linux-nfs, Andy Adamson
From: Andy Adamson <andros@netapp.com>
Signed-off-by: Andy Adamson <andros@netapp.com>
---
fs/nfs/nfs4proc.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index f5779a1..17b0c31 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -5448,7 +5448,7 @@ static void nfs4_pnfs_layoutget_done(struct rpc_task *task, void *calldata)
dprintk("--> %s\n", __func__);
- nfs4_sequence_done(server, &lgp->res.seq_res, task->tk_status);
+ nfs4_sequence_done(task, &lgp->res.seq_res);
if (RPC_ASSASSINATED(task))
return;
@@ -5558,7 +5558,7 @@ pnfs_layoutcommit_done(struct rpc_task *task, void *calldata)
(struct pnfs_layoutcommit_data *)calldata;
struct nfs_server *server = NFS_SERVER(data->args.inode);
- nfs4_sequence_done(server, &data->res.seq_res, task->tk_status);
+ nfs4_sequence_done(task, &data->res.seq_res);
if (RPC_ASSASSINATED(task))
return;
@@ -5666,7 +5666,7 @@ static void nfs4_pnfs_layoutreturn_done(struct rpc_task *task, void *calldata)
dprintk("--> %s\n", __func__);
- nfs4_sequence_done(server, &lrp->res.seq_res, task->tk_status);
+ nfs4_sequence_done(task, &lrp->res.seq_res);
if (RPC_ASSASSINATED(task))
return;
--
1.6.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] SQUASHME pnfs-submit pnfs operations use new nfs4_sequence_done
2010-07-16 15:56 ` andros
@ 2010-07-19 8:46 ` Benny Halevy
2010-07-19 13:44 ` Andy Adamson
0 siblings, 1 reply; 4+ messages in thread
From: Benny Halevy @ 2010-07-19 8:46 UTC (permalink / raw)
To: andros; +Cc: linux-nfs
Andy, I've fixed this already in my tree, but with additionaly
checking on nfs4_sequence_done's status:
if (!nfs4_sequence_done(task, &res))
return 0;
Benny
On Jul. 16, 2010, 18:56 +0300, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
>
> Signed-off-by: Andy Adamson <andros@netapp.com>
> ---
> fs/nfs/nfs4proc.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index f5779a1..17b0c31 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -5448,7 +5448,7 @@ static void nfs4_pnfs_layoutget_done(struct rpc_task *task, void *calldata)
>
> dprintk("--> %s\n", __func__);
>
> - nfs4_sequence_done(server, &lgp->res.seq_res, task->tk_status);
> + nfs4_sequence_done(task, &lgp->res.seq_res);
>
> if (RPC_ASSASSINATED(task))
> return;
> @@ -5558,7 +5558,7 @@ pnfs_layoutcommit_done(struct rpc_task *task, void *calldata)
> (struct pnfs_layoutcommit_data *)calldata;
> struct nfs_server *server = NFS_SERVER(data->args.inode);
>
> - nfs4_sequence_done(server, &data->res.seq_res, task->tk_status);
> + nfs4_sequence_done(task, &data->res.seq_res);
> if (RPC_ASSASSINATED(task))
> return;
>
> @@ -5666,7 +5666,7 @@ static void nfs4_pnfs_layoutreturn_done(struct rpc_task *task, void *calldata)
>
> dprintk("--> %s\n", __func__);
>
> - nfs4_sequence_done(server, &lrp->res.seq_res, task->tk_status);
> + nfs4_sequence_done(task, &lrp->res.seq_res);
> if (RPC_ASSASSINATED(task))
> return;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] SQUASHME pnfs-submit pnfs operations use new nfs4_sequence_done
2010-07-19 8:46 ` Benny Halevy
@ 2010-07-19 13:44 ` Andy Adamson
0 siblings, 0 replies; 4+ messages in thread
From: Andy Adamson @ 2010-07-19 13:44 UTC (permalink / raw)
To: Benny Halevy; +Cc: linux-nfs
OK - Thanks for the heads up
-->Andy
On Jul 19, 2010, at 4:46 AM, Benny Halevy wrote:
> Andy, I've fixed this already in my tree, but with additionaly
> checking on nfs4_sequence_done's status:
>
> if (!nfs4_sequence_done(task, &res))
> return 0;
>
> Benny
>
> On Jul. 16, 2010, 18:56 +0300, andros@netapp.com wrote:
>> From: Andy Adamson <andros@netapp.com>
>>
>> Signed-off-by: Andy Adamson <andros@netapp.com>
>> ---
>> fs/nfs/nfs4proc.c | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
>> index f5779a1..17b0c31 100644
>> --- a/fs/nfs/nfs4proc.c
>> +++ b/fs/nfs/nfs4proc.c
>> @@ -5448,7 +5448,7 @@ static void nfs4_pnfs_layoutget_done(struct rpc_task *task, void *calldata)
>>
>> dprintk("--> %s\n", __func__);
>>
>> - nfs4_sequence_done(server, &lgp->res.seq_res, task->tk_status);
>> + nfs4_sequence_done(task, &lgp->res.seq_res);
>>
>> if (RPC_ASSASSINATED(task))
>> return;
>> @@ -5558,7 +5558,7 @@ pnfs_layoutcommit_done(struct rpc_task *task, void *calldata)
>> (struct pnfs_layoutcommit_data *)calldata;
>> struct nfs_server *server = NFS_SERVER(data->args.inode);
>>
>> - nfs4_sequence_done(server, &data->res.seq_res, task->tk_status);
>> + nfs4_sequence_done(task, &data->res.seq_res);
>> if (RPC_ASSASSINATED(task))
>> return;
>>
>> @@ -5666,7 +5666,7 @@ static void nfs4_pnfs_layoutreturn_done(struct rpc_task *task, void *calldata)
>>
>> dprintk("--> %s\n", __func__);
>>
>> - nfs4_sequence_done(server, &lrp->res.seq_res, task->tk_status);
>> + nfs4_sequence_done(task, &lrp->res.seq_res);
>> if (RPC_ASSASSINATED(task))
>> return;
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-19 13:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-16 15:56 [PATCH 1/1] SQUASHME pnfs-submit pnfs operations use new nfs4_sequence_done andros
2010-07-16 15:56 ` andros
2010-07-19 8:46 ` Benny Halevy
2010-07-19 13:44 ` Andy Adamson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.