From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Disable EFI cursor when switching to another terminal output
Date: Tue, 20 Jul 2010 20:06:49 +0200 [thread overview]
Message-ID: <4C45E5B9.8050802@gmail.com> (raw)
In-Reply-To: <20100720162616.GS21862@riva.ucam.org>
[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]
On 07/20/2010 06:26 PM, Colin Watson wrote:
> On my test hardware, the EFI cursor stays up when switching to gfxterm,
> which looks pretty odd. We should disable it when the EFI console stops
> being active.
>
> 2010-07-20 Colin Watson <cjwatson@ubuntu.com>
>
> Disable EFI cursor when the EFI console becomes inactive.
>
> * term/efi/console.c (grub_efi_console_init): New function.
> (grub_efi_console_fini): New function.
> (grub_console_term_output): Register init and fini methods.
>
>
Go ahead
> === modified file 'term/efi/console.c'
> --- term/efi/console.c 2010-05-09 11:20:35 +0000
> +++ term/efi/console.c 2010-07-20 15:35:42 +0000
> @@ -311,6 +311,20 @@ grub_console_setcursor (struct grub_term
> efi_call_2 (o->enable_cursor, o, on);
> }
>
> +static grub_err_t
> +grub_efi_console_init (struct grub_term_output *term)
> +{
> + grub_console_setcursor (term, 1);
> + return 0;
> +}
> +
> +static grub_err_t
> +grub_efi_console_fini (struct grub_term_output *term)
> +{
> + grub_console_setcursor (term, 0);
> + return 0;
> +}
> +
> static struct grub_term_input grub_console_term_input =
> {
> .name = "console",
> @@ -321,6 +335,8 @@ static struct grub_term_input grub_conso
> static struct grub_term_output grub_console_term_output =
> {
> .name = "console",
> + .init = grub_efi_console_init,
> + .fini = grub_efi_console_fini,
> .putchar = grub_console_putchar,
> .getwh = grub_console_getwh,
> .getxy = grub_console_getxy,
>
>
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2010-07-20 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 16:26 [PATCH] Disable EFI cursor when switching to another terminal output Colin Watson
2010-07-20 18:06 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C45E5B9.8050802@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.