From: Tejun Heo <tj@kernel.org>
To: Christian Dietrich <stettberger@dokucode.de>
Cc: David Howells <dhowells@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: Dead Config in mm/percpu.c
Date: Wed, 21 Jul 2010 17:12:41 +0200 [thread overview]
Message-ID: <4C470E69.7020900@kernel.org> (raw)
In-Reply-To: <861vaxjij8.fsf@peer.zerties.org>
On 07/21/2010 11:22 AM, Christian Dietrich wrote:
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we are looking at multiple integrity errors in linux'
> configuration system.
>
> I've been running a check on the mm/ sourcetree for
> config Items not defined in Kconfig and found 1 such case. Sourcecode
> blocks depending on these Items are not reachable from a vanilla
> kernel -- dead code. I've seen such dead blocks made on purpose
> e.g. while integrating new features into the kernel but generally
> they're just useless.
>
> We found, that CONFIG_NEED_PER_CPU_KM is a dead symbol, so it isn't defined
> anywhere. Cause of that the percpu_km.c is never included anywhere. Is
> this a intended dead symbol, for use in out of tree development, or is
> this just an error?
Oh, it's new code waiting to be used. It's for cases where SMP is
used w/o MMU. IIRC, it was blackfin.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Christian Dietrich <stettberger@dokucode.de>
Cc: David Howells <dhowells@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: Dead Config in mm/percpu.c
Date: Wed, 21 Jul 2010 17:12:41 +0200 [thread overview]
Message-ID: <4C470E69.7020900@kernel.org> (raw)
In-Reply-To: <861vaxjij8.fsf@peer.zerties.org>
On 07/21/2010 11:22 AM, Christian Dietrich wrote:
> Hi all!
>
> As part of the VAMOS[0] research project at the University of
> Erlangen we are looking at multiple integrity errors in linux'
> configuration system.
>
> I've been running a check on the mm/ sourcetree for
> config Items not defined in Kconfig and found 1 such case. Sourcecode
> blocks depending on these Items are not reachable from a vanilla
> kernel -- dead code. I've seen such dead blocks made on purpose
> e.g. while integrating new features into the kernel but generally
> they're just useless.
>
> We found, that CONFIG_NEED_PER_CPU_KM is a dead symbol, so it isn't defined
> anywhere. Cause of that the percpu_km.c is never included anywhere. Is
> this a intended dead symbol, for use in out of tree development, or is
> this just an error?
Oh, it's new code waiting to be used. It's for cases where SMP is
used w/o MMU. IIRC, it was blackfin.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-07-21 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 9:22 Dead Config in mm/percpu.c Christian Dietrich
2010-07-21 9:22 ` Christian Dietrich
2010-07-21 15:12 ` Tejun Heo [this message]
2010-07-21 15:12 ` Tejun Heo
2010-08-10 6:26 ` Mike Frysinger
2010-08-10 6:26 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C470E69.7020900@kernel.org \
--to=tj@kernel.org \
--cc=cl@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stettberger@dokucode.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.