From: Greg Bean <gbean@codeaurora.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: akpm@linux-foundation.org, david-b@pacbell.net,
khali@linux-fr.org, linux-i2c@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver.
Date: Thu, 22 Jul 2010 10:22:42 -0700 [thread overview]
Message-ID: <4C487E62.9080106@codeaurora.org> (raw)
In-Reply-To: <20100722101753.c73604eb.randy.dunlap@oracle.com>
>> + bool "Semtech SX150x I2C GPIO expander"
>> + depends on I2C=y
>> + default n
>> + help
>> + Say yes here to provide support for Semtech SX150-series I2C
>> + GPIO expanders. Compatible models include:
>
> Just curious, not complaining, but why does this driver (and some others)
> need to be built-in instead of having the option of being built as a
> loadable module?
It's that way because it requires unexported symbols from genirq and
I2C. If this driver is allowed to be a module, it can't find the
unexported genirq symbols, and if I2C is allowed to be a module, then a
bunch of i2c_smbus stuff can't be resolved...
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: Greg Bean <gbean-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Randy Dunlap <randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver.
Date: Thu, 22 Jul 2010 10:22:42 -0700 [thread overview]
Message-ID: <4C487E62.9080106@codeaurora.org> (raw)
In-Reply-To: <20100722101753.c73604eb.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>> + bool "Semtech SX150x I2C GPIO expander"
>> + depends on I2C=y
>> + default n
>> + help
>> + Say yes here to provide support for Semtech SX150-series I2C
>> + GPIO expanders. Compatible models include:
>
> Just curious, not complaining, but why does this driver (and some others)
> need to be built-in instead of having the option of being built as a
> loadable module?
It's that way because it requires unexported symbols from genirq and
I2C. If this driver is allowed to be a module, it can't find the
unexported genirq symbols, and if I2C is allowed to be a module, then a
bunch of i2c_smbus stuff can't be resolved...
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: gbean@codeaurora.org (Greg Bean)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver.
Date: Thu, 22 Jul 2010 10:22:42 -0700 [thread overview]
Message-ID: <4C487E62.9080106@codeaurora.org> (raw)
In-Reply-To: <20100722101753.c73604eb.randy.dunlap@oracle.com>
>> + bool "Semtech SX150x I2C GPIO expander"
>> + depends on I2C=y
>> + default n
>> + help
>> + Say yes here to provide support for Semtech SX150-series I2C
>> + GPIO expanders. Compatible models include:
>
> Just curious, not complaining, but why does this driver (and some others)
> need to be built-in instead of having the option of being built as a
> loadable module?
It's that way because it requires unexported symbols from genirq and
I2C. If this driver is allowed to be a module, it can't find the
unexported genirq symbols, and if I2C is allowed to be a module, then a
bunch of i2c_smbus stuff can't be resolved...
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-07-22 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 17:12 [PATCH v4] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver Gregory Bean
2010-07-22 17:12 ` Gregory Bean
2010-07-22 17:17 ` Randy Dunlap
2010-07-22 17:17 ` Randy Dunlap
2010-07-22 17:22 ` Greg Bean [this message]
2010-07-22 17:22 ` Greg Bean
2010-07-22 17:22 ` Greg Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C487E62.9080106@codeaurora.org \
--to=gbean@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.