* Can you guys please take a look at bko#16434?
@ 2010-07-24 8:47 Tejun Heo
2010-08-03 2:58 ` Mark Lord
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2010-07-24 8:47 UTC (permalink / raw)
To: Mark Lord, Saeed Bishara, linux-ide@vger.kernel.org
Hello,
It looks like sata_mv triggers BUG_ON() when a command it doesn't know
about is issued and discard support makes it happen. Can you guys
take a look? And please update it such that it doesn't trigger
BUG_ON() only because an unknown command is issued. That's way too
dangerous. If void return from qc_prep is a problem, just move the
whole qc_prep into qc_issue, the distinction is pretty arbitrary
anyway.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Can you guys please take a look at bko#16434?
2010-07-24 8:47 Can you guys please take a look at bko#16434? Tejun Heo
@ 2010-08-03 2:58 ` Mark Lord
0 siblings, 0 replies; 2+ messages in thread
From: Mark Lord @ 2010-08-03 2:58 UTC (permalink / raw)
To: Tejun Heo; +Cc: Saeed Bishara, linux-ide@vger.kernel.org
On 10-07-24 04:47 AM, Tejun Heo wrote:
> Hello,
>
> It looks like sata_mv triggers BUG_ON() when a command it doesn't know
> about is issued and discard support makes it happen. Can you guys
> take a look? And please update it such that it doesn't trigger
> BUG_ON() only because an unknown command is issued. That's way too
> dangerous. If void return from qc_prep is a problem, just move the
> whole qc_prep into qc_issue, the distinction is pretty arbitrary
> anyway.
..
I've been away on holiday for the past few weeks,
but I did make a note on the bugzilla entry for this
that there were two problems to be addressed.
Now that I'm back in the office, I'll have a look at this later
in the week, and see about getting TRIM working with sata_mv,
if possible.
Cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-03 2:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-24 8:47 Can you guys please take a look at bko#16434? Tejun Heo
2010-08-03 2:58 ` Mark Lord
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.