[PATCH] cifs: fsc should not default to "on"

[PATCH] cifs: fsc should not default to "on"

[Jeff Layton]

I'm not sure why this was merged with this flag hardcoded on, but it
seems quite dangerous. Turn it off.

Also, mount.cifs hands unrecognized options off to the kernel so there
should be no need for changes there in order to support this.

Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 fs/cifs/connect.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 85a994c..2a43a0a 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -846,9 +846,6 @@ cifs_parse_mount_options(char *options, const char *devname,
 	/* default to using server inode numbers where available */
 	vol->server_ino = 1;
 
-	/* XXX: default to fsc for testing until mount.cifs pieces are done */
-	vol->fsc = 1;
-
 	if (!options)
 		return 1;
 
-- 
1.7.1.1

Re: [PATCH] cifs: fsc should not default to "on"

[Steve French]

agreed - merged

On Mon, Jul 26, 2010 at 1:25 PM, Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> I'm not sure why this was merged with this flag hardcoded on, but it
> seems quite dangerous. Turn it off.
>
> Also, mount.cifs hands unrecognized options off to the kernel so there
> should be no need for changes there in order to support this.
>
> Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  fs/cifs/connect.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 85a994c..2a43a0a 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -846,9 +846,6 @@ cifs_parse_mount_options(char *options, const char *devname,
>        /* default to using server inode numbers where available */
>        vol->server_ino = 1;
>
> -       /* XXX: default to fsc for testing until mount.cifs pieces are done */
> -       vol->fsc = 1;
> -
>        if (!options)
>                return 1;
>
> --
> 1.7.1.1
>
>



-- 
Thanks,

Steve

Re: [PATCH] cifs: fsc should not default to "on"

[Suresh Jayaraman]

On 07/26/2010 11:55 PM, Jeff Layton wrote:
> I'm not sure why this was merged with this flag hardcoded on, but it
> seems quite dangerous. Turn it off.

Mea culpa.. I forgot to remove this during the second post.

> Also, mount.cifs hands unrecognized options off to the kernel so there
> should be no need for changes there in order to support this.

Yeah, it does not seem to require any handling - I had misunderstood.

> Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  fs/cifs/connect.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)

Reviewed-and-Tested-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>


Thanks,

-- 
Suresh Jayaraman