From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: devel@driverdev.osuosl.org,
Markus Grabner <grabner@icg.tugraz.at>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
gregkh@suse.de
Subject: [PATCH -next] staging/line6: needs to select SND_PCM
Date: Tue, 27 Jul 2010 12:21:19 -0700 [thread overview]
Message-ID: <4C4F31AF.2090701@oracle.com> (raw)
In-Reply-To: <20100727160708.722c39c1.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle.com>
line6 uses snd_pcm*() functions, so it should select SND_PCM.
ERROR: "snd_pcm_period_elapsed" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_set_ops" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_free_pages" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_ioctl" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_malloc_pages" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_hw_constraint_ratdens" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_format_physical_width" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_preallocate_pages_for_all" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_new" [drivers/staging/line6/line6usb.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Markus Grabner <grabner@icg.tugraz.at>
---
drivers/staging/line6/Kconfig | 1 +
1 file changed, 1 insertion(+)
Third patch to staging/line6/Kconfig. :(
Developers should know what kernel services their code needs
and how to configure for those needs.
--- linux-next-20100727.orig/drivers/staging/line6/Kconfig
+++ linux-next-20100727/drivers/staging/line6/Kconfig
@@ -2,6 +2,7 @@ config LINE6_USB
tristate "Line6 USB support"
depends on USB && SND
select SND_RAWMIDI
+ select SND_PCM
help
This is a driver for the guitar amp, cab, and effects modeller
PODxt Pro by Line6 (and similar devices), supporting the
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Markus Grabner <grabner@icg.tugraz.at>,
gregkh@suse.de, devel@driverdev.osuosl.org
Subject: [PATCH -next] staging/line6: needs to select SND_PCM
Date: Tue, 27 Jul 2010 12:21:19 -0700 [thread overview]
Message-ID: <4C4F31AF.2090701@oracle.com> (raw)
In-Reply-To: <20100727160708.722c39c1.sfr@canb.auug.org.au>
From: Randy Dunlap <randy.dunlap@oracle.com>
line6 uses snd_pcm*() functions, so it should select SND_PCM.
ERROR: "snd_pcm_period_elapsed" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_set_ops" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_free_pages" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_ioctl" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_malloc_pages" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_hw_constraint_ratdens" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_format_physical_width" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_lib_preallocate_pages_for_all" [drivers/staging/line6/line6usb.ko] undefined!
ERROR: "snd_pcm_new" [drivers/staging/line6/line6usb.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Markus Grabner <grabner@icg.tugraz.at>
---
drivers/staging/line6/Kconfig | 1 +
1 file changed, 1 insertion(+)
Third patch to staging/line6/Kconfig. :(
Developers should know what kernel services their code needs
and how to configure for those needs.
--- linux-next-20100727.orig/drivers/staging/line6/Kconfig
+++ linux-next-20100727/drivers/staging/line6/Kconfig
@@ -2,6 +2,7 @@ config LINE6_USB
tristate "Line6 USB support"
depends on USB && SND
select SND_RAWMIDI
+ select SND_PCM
help
This is a driver for the guitar amp, cab, and effects modeller
PODxt Pro by Line6 (and similar devices), supporting the
next prev parent reply other threads:[~2010-07-27 19:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 6:07 linux-next: Tree for July 27 Stephen Rothwell
2010-07-27 7:24 ` Jaswinder Singh Rajput
2010-07-27 7:28 ` Stephen Rothwell
2010-07-27 18:35 ` Alex Elder
2010-07-28 1:24 ` Stephen Rothwell
2010-07-27 18:38 ` linux-next: Tree for July 27 (xen) Randy Dunlap
2010-07-28 13:11 ` Stefano Stabellini
2010-07-28 14:48 ` Jeremy Fitzhardinge
2010-07-28 15:06 ` Stefano Stabellini
2010-07-28 15:47 ` Randy Dunlap
2010-07-27 19:21 ` Randy Dunlap [this message]
2010-07-27 19:21 ` [PATCH -next] staging/line6: needs to select SND_PCM Randy Dunlap
2010-07-28 13:59 ` Takashi Iwai
2010-07-28 15:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4F31AF.2090701@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=grabner@icg.tugraz.at \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.