From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: linux-kernel@vger.kernel.org, hpa@linux.intel.com,
tglx@linutronix.de, mingo@redhat.com
Cc: kaneshige.kenji@jp.fujitsu.com
Subject: Re: [PATCH] x86: ioremap: fix wrong physical address handling in PAT code
Date: Thu, 29 Jul 2010 14:58:57 +0900 [thread overview]
Message-ID: <4C5118A1.7030204@jp.fujitsu.com> (raw)
In-Reply-To: <4C47DDCF.80300@jp.fujitsu.com>
Hi,
Does anybody see the following patch? It's obviously a bug. Please apply it.
Thanks,
Yasuaki Ishimatsu
> From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>
> The following two commits fixed a problem that x86 ioremap() doesn't handle
> physical address higher than 32-bit properly in X86_32 PAE mode.
>
> ffa71f33a820d1ab3f2fc5723819ac60fb76080b (x86, ioremap: Fix incorrect physical address handling in
> PAE mode)
> 35be1b716a475717611b2dc04185e9d80b9cb693 (x86, ioremap: Fix normal ram range check)
>
> But these fixes are not enough, since pat_pagerange_is_ram() in PAT code
> also has a same problem. This patch fixes it.
>
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>
> ---
>
> It is for -tip tree.
>
> Index: linux-2.6-x86/arch/x86/mm/pat.c
> ===================================================================
> --- linux-2.6-x86.orig/arch/x86/mm/pat.c 2010-07-22 03:04:38.000000000 +0900
> +++ linux-2.6-x86/arch/x86/mm/pat.c 2010-07-22 03:47:36.000000000 +0900
> @@ -158,7 +158,7 @@ static unsigned long pat_x_mtrr_type(u64
> return req_type;
> }
>
> -static int pat_pagerange_is_ram(unsigned long start, unsigned long end)
> +static int pat_pagerange_is_ram(resource_size_t start, resource_size_t end)
> {
> int ram_page = 0, not_rampage = 0;
> unsigned long page_nr;
>
next prev parent reply other threads:[~2010-07-29 5:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 5:57 [PATCH] x86: ioremap: fix wrong physical address handling in PAT code Yasuaki Ishimatsu
2010-07-22 15:13 ` Kenji Kaneshige
2010-07-29 5:58 ` Yasuaki Ishimatsu [this message]
2010-07-29 13:27 ` [tip:x86/mm] x86: Ioremap: " tip-bot for Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5118A1.7030204@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=hpa@linux.intel.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.