From: Anand Gadiyar <gadiyar-l0cyMroinI0@public.gmane.org>
To: Colin Cross <ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] [ARM] tegra: Add i2c support
Date: Fri, 30 Jul 2010 18:06:54 +0530 [thread overview]
Message-ID: <4C52C766.7040709@ti.com> (raw)
In-Reply-To: <1280450180-25016-1-git-send-email-ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On 07/30/2010 06:06 AM, Colin Cross wrote:
> +/* i2c_writel and i2c_readl will offset the register if necessary to talk
> + * to the I2C block inside the DVC block
> + */
Minor coding-style comment. Documentation/CodingStyle says the preferred
format for multi-line comments is to do:
/*
* i2c_writel and i2c_readl ...
* to the I2C block ...
*/
Not sure if you need to fix this in this patch, but it's probably a good
idea to follow for future patches.
- Anand
WARNING: multiple messages have this Message-ID (diff)
From: gadiyar@ti.com (Anand Gadiyar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [ARM] tegra: Add i2c support
Date: Fri, 30 Jul 2010 18:06:54 +0530 [thread overview]
Message-ID: <4C52C766.7040709@ti.com> (raw)
In-Reply-To: <1280450180-25016-1-git-send-email-ccross@google.com>
On 07/30/2010 06:06 AM, Colin Cross wrote:
> +/* i2c_writel and i2c_readl will offset the register if necessary to talk
> + * to the I2C block inside the DVC block
> + */
Minor coding-style comment. Documentation/CodingStyle says the preferred
format for multi-line comments is to do:
/*
* i2c_writel and i2c_readl ...
* to the I2C block ...
*/
Not sure if you need to fix this in this patch, but it's probably a good
idea to follow for future patches.
- Anand
next prev parent reply other threads:[~2010-07-30 12:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 0:36 [PATCH] [ARM] tegra: Add i2c support Colin Cross
2010-07-30 0:36 ` Colin Cross
[not found] ` <1280450180-25016-1-git-send-email-ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2010-07-30 12:36 ` Anand Gadiyar [this message]
2010-07-30 12:36 ` Anand Gadiyar
[not found] ` <4C52C766.7040709-l0cyMroinI0@public.gmane.org>
2010-09-02 22:07 ` Colin Cross
2010-09-02 22:07 ` Colin Cross
2010-07-30 20:44 ` Mike Rapoport
2010-07-30 20:44 ` Mike Rapoport
[not found] ` <AANLkTi=mC9jM7_U_KoAQ=Ec3Z5wefP-hii9M=_5ATo1i-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-02 21:42 ` Colin Cross
2010-09-02 21:42 ` Colin Cross
2010-08-10 14:57 ` Mike Rapoport
2010-08-10 14:57 ` Mike Rapoport
2010-09-02 21:54 ` Colin Cross
2010-09-02 21:54 ` Colin Cross
[not found] ` <AANLkTimd2D+_xQ_CH-e+jgn+rZgMpJY6Zkc-SSVdFzMt-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-02 22:17 ` Colin Cross
2010-09-02 22:17 ` Colin Cross
-- strict thread matches above, loose matches on Subject: below --
2010-09-02 22:21 Colin Cross
2010-09-02 22:21 ` Colin Cross
2010-09-02 22:21 ` Colin Cross
[not found] ` <1283466103-20889-1-git-send-email-ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
2010-12-22 0:11 ` Colin Cross
2010-12-22 0:11 ` Colin Cross
2010-12-22 0:11 ` Colin Cross
[not found] ` <AANLkTimYURYGix-0Xk3wdf1A-XEAJbBXR_JDn1BFw_uq-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-01-31 22:48 ` Stephen Warren
2011-01-31 22:48 ` Stephen Warren
2011-01-31 22:48 ` Stephen Warren
2011-02-07 17:45 ` Stephen Warren
2011-02-07 17:45 ` Stephen Warren
2011-02-07 17:45 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C52C766.7040709@ti.com \
--to=gadiyar-l0cymroini0@public.gmane.org \
--cc=ccross-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.