From: Jiri Slaby <jirislaby@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Randy Dunlap <randy.dunlap@oracle.com>,
devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH 1/9] staging: dt3155: check put_user() return value
Date: Fri, 30 Jul 2010 12:44:37 +0000 [thread overview]
Message-ID: <4C52C935.5020900@gmail.com> (raw)
In-Reply-To: <1280488030-20697-1-git-send-email-segooon@gmail.com>
On 07/30/2010 01:07 PM, Kulikov Vasiliy wrote:
> put_user() may fail, if so return -EFAULT.
> Also compare count with copied data size, not size of struct with these
> fields.
Please do whitespace cleanup separately. We cannot review this.
--
js
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Randy Dunlap <randy.dunlap@oracle.com>,
devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH 1/9] staging: dt3155: check put_user() return value
Date: Fri, 30 Jul 2010 14:44:37 +0200 [thread overview]
Message-ID: <4C52C935.5020900@gmail.com> (raw)
In-Reply-To: <1280488030-20697-1-git-send-email-segooon@gmail.com>
On 07/30/2010 01:07 PM, Kulikov Vasiliy wrote:
> put_user() may fail, if so return -EFAULT.
> Also compare count with copied data size, not size of struct with these
> fields.
Please do whitespace cleanup separately. We cannot review this.
--
js
next prev parent reply other threads:[~2010-07-30 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 11:07 [PATCH 1/9] staging: dt3155: check put_user() return value Kulikov Vasiliy
2010-07-30 11:07 ` Kulikov Vasiliy
2010-07-30 12:44 ` Jiri Slaby [this message]
2010-07-30 12:44 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C52C935.5020900@gmail.com \
--to=jirislaby@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=horms@verge.net.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.