* [PATCH 1/2] cifs: show features compiled in as part of DebugData
@ 2010-07-30 12:55 Suresh Jayaraman
2010-07-30 13:04 ` Jeff Layton
2010-07-30 14:39 ` Steve French
0 siblings, 2 replies; 9+ messages in thread
From: Suresh Jayaraman @ 2010-07-30 12:55 UTC (permalink / raw)
To: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: Jeff Layton, linux-cifs-u79uwXL29TY76Z2rM5mHXA
Fixed the nit pointed out by Jeff.
From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
Subject: [PATCH 1/2] cifs: show features compiled in as part of DebugData
This patch adds the features that are compiled in to the CIFS debugging data
as shown below:
$cat /proc/fs/cifs/DebugData
Display Internal CIFS Data Structures for Debugging
---------------------------------------------------
CIFS Version 1.64
Features: dfs fscache posix spnego xattr
Active VFS Requests: 0
...
This patch provides a definitive way to tell what features are currently
enabled in the running kernel. This could also help debugging.
Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
fs/cifs/cifs_debug.c | 25 +++++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
index 4fce6e6..eb1ba49 100644
--- a/fs/cifs/cifs_debug.c
+++ b/fs/cifs/cifs_debug.c
@@ -119,6 +119,31 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
"Display Internal CIFS Data Structures for Debugging\n"
"---------------------------------------------------\n");
seq_printf(m, "CIFS Version %s\n", CIFS_VERSION);
+ seq_printf(m, "Features: ");
+#ifdef CONFIG_CIFS_DFS_UPCALL
+ seq_printf(m, "dfs");
+ seq_putc(m, ' ');
+#endif
+#ifdef CONFIG_CIFS_FSCACHE
+ seq_printf(m, "fscache");
+ seq_putc(m, ' ');
+#endif
+#ifdef CONFIG_CIFS_WEAK_PW_HASH
+ seq_printf(m, "lanman");
+ seq_putc(m, ' ');
+#endif
+#ifdef CONFIG_CIFS_POSIX
+ seq_printf(m, "posix");
+ seq_putc(m, ' ');
+#endif
+#ifdef CONFIG_CIFS_UPCALL
+ seq_printf(m, "spnego");
+ seq_putc(m, ' ');
+#endif
+#ifdef CONFIG_CIFS_XATTR
+ seq_printf(m, "xattr");
+#endif
+ seq_putc(m, '\n');
seq_printf(m, "Active VFS Requests: %d\n", GlobalTotalActiveXid);
seq_printf(m, "Servers:");
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] cifs: show features compiled in as part of DebugData
2010-07-30 12:55 [PATCH 1/2] cifs: show features compiled in as part of DebugData Suresh Jayaraman
@ 2010-07-30 13:04 ` Jeff Layton
2010-07-30 14:39 ` Steve French
1 sibling, 0 replies; 9+ messages in thread
From: Jeff Layton @ 2010-07-30 13:04 UTC (permalink / raw)
To: Suresh Jayaraman
Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA
On Fri, 30 Jul 2010 18:25:56 +0530
Suresh Jayaraman <sjayaraman-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org> wrote:
> Fixed the nit pointed out by Jeff.
>
> From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> Subject: [PATCH 1/2] cifs: show features compiled in as part of DebugData
>
> This patch adds the features that are compiled in to the CIFS debugging data
> as shown below:
>
> $cat /proc/fs/cifs/DebugData
> Display Internal CIFS Data Structures for Debugging
> ---------------------------------------------------
> CIFS Version 1.64
> Features: dfs fscache posix spnego xattr
> Active VFS Requests: 0
> ...
>
> This patch provides a definitive way to tell what features are currently
> enabled in the running kernel. This could also help debugging.
>
> Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> fs/cifs/cifs_debug.c | 25 +++++++++++++++++++++++++
> 1 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
> index 4fce6e6..eb1ba49 100644
> --- a/fs/cifs/cifs_debug.c
> +++ b/fs/cifs/cifs_debug.c
> @@ -119,6 +119,31 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
> "Display Internal CIFS Data Structures for Debugging\n"
> "---------------------------------------------------\n");
> seq_printf(m, "CIFS Version %s\n", CIFS_VERSION);
> + seq_printf(m, "Features: ");
> +#ifdef CONFIG_CIFS_DFS_UPCALL
> + seq_printf(m, "dfs");
> + seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_FSCACHE
> + seq_printf(m, "fscache");
> + seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_WEAK_PW_HASH
> + seq_printf(m, "lanman");
> + seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_POSIX
> + seq_printf(m, "posix");
> + seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_UPCALL
> + seq_printf(m, "spnego");
> + seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_XATTR
> + seq_printf(m, "xattr");
> +#endif
> + seq_putc(m, '\n');
> seq_printf(m, "Active VFS Requests: %d\n", GlobalTotalActiveXid);
> seq_printf(m, "Servers:");
>
>
>
Acked-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] cifs: show features compiled in as part of DebugData
2010-07-30 12:55 [PATCH 1/2] cifs: show features compiled in as part of DebugData Suresh Jayaraman
2010-07-30 13:04 ` Jeff Layton
@ 2010-07-30 14:39 ` Steve French
[not found] ` <AANLkTikgA8mXTcX-i3avjuQygrekicntcy3P2NBW5QuB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
1 sibling, 1 reply; 9+ messages in thread
From: Steve French @ 2010-07-30 14:39 UTC (permalink / raw)
To: Suresh Jayaraman; +Cc: Jeff Layton, linux-cifs-u79uwXL29TY76Z2rM5mHXA
If someone ever wants a script to parse this - seems like your
(original?) idea of putting this in /proc/fs/cifs/features instead of
/proc/fs/cifs/DebugData (which has various other pieces of debug
information) could be easier.
On Fri, Jul 30, 2010 at 7:55 AM, Suresh Jayaraman <sjayaraman-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org> wrote:
> Fixed the nit pointed out by Jeff.
>
> From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> Subject: [PATCH 1/2] cifs: show features compiled in as part of DebugData
>
> This patch adds the features that are compiled in to the CIFS debugging data
> as shown below:
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] cifs: show features compiled in as part of DebugData
@ 2010-07-30 12:27 Suresh Jayaraman
2010-07-30 12:39 ` Jeff Layton
0 siblings, 1 reply; 9+ messages in thread
From: Suresh Jayaraman @ 2010-07-30 12:27 UTC (permalink / raw)
To: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: Jeff Layton, linux-cifs-u79uwXL29TY76Z2rM5mHXA
From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
Subject: [PATCH 1/2] cifs: show features compiled in as part of DebugData
This patch adds the features that are compiled in to the CIFS debugging data
as shown below:
$cat /proc/fs/cifs/DebugData
Display Internal CIFS Data Structures for Debugging
---------------------------------------------------
CIFS Version 1.64
Features: dfs fscache posix spnego xattr
Active VFS Requests: 0
...
This patch provides a definitive way to tell what features are currently
enabled in the running kernel. This could also help debugging.
Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
fs/cifs/cifs_debug.c | 26 ++++++++++++++++++++++++++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
index 4fce6e6..fdb2db5 100644
--- a/fs/cifs/cifs_debug.c
+++ b/fs/cifs/cifs_debug.c
@@ -119,6 +119,32 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
"Display Internal CIFS Data Structures for Debugging\n"
"---------------------------------------------------\n");
seq_printf(m, "CIFS Version %s\n", CIFS_VERSION);
+ seq_printf(m, "Features: ");
+#ifdef CONFIG_CIFS_DFS_UPCALL
+ seq_printf(m, "dfs");
+ seq_putc(m, ' ');
+#endif
+#ifdef CONFIG_CIFS_FSCACHE
+ seq_printf(m, "fscache");
+ seq_putc(m, ' ');
+#endif
+#ifdef CONFIG_CIFS_WEAK_PW_HASH
+ seq_printf(m, "lanman");
+ seq_putc(m, ' ');
+#endif
+#ifdef CONFIG_CIFS_POSIX
+ seq_printf(m, "posix");
+ seq_putc(m, ' ');
+#endif
+#ifdef CONFIG_CIFS_UPCALL
+ seq_printf(m, "spnego");
+ seq_putc(m, ' ');
+#endif
+#ifdef CONFIG_CIFS_XATTR
+ seq_printf(m, "xattr");
+ seq_putc(m, ' ');
+#endif
+ seq_putc(m, '\n');
seq_printf(m, "Active VFS Requests: %d\n", GlobalTotalActiveXid);
seq_printf(m, "Servers:");
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] cifs: show features compiled in as part of DebugData
2010-07-30 12:27 Suresh Jayaraman
@ 2010-07-30 12:39 ` Jeff Layton
0 siblings, 0 replies; 9+ messages in thread
From: Jeff Layton @ 2010-07-30 12:39 UTC (permalink / raw)
To: Suresh Jayaraman
Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA
On Fri, 30 Jul 2010 17:57:22 +0530
Suresh Jayaraman <sjayaraman-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org> wrote:
> From: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> Subject: [PATCH 1/2] cifs: show features compiled in as part of DebugData
>
> This patch adds the features that are compiled in to the CIFS debugging data
> as shown below:
>
> $cat /proc/fs/cifs/DebugData
> Display Internal CIFS Data Structures for Debugging
> ---------------------------------------------------
> CIFS Version 1.64
> Features: dfs fscache posix spnego xattr
> Active VFS Requests: 0
> ...
>
> This patch provides a definitive way to tell what features are currently
> enabled in the running kernel. This could also help debugging.
>
> Signed-off-by: Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>
> Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
> fs/cifs/cifs_debug.c | 26 ++++++++++++++++++++++++++
> 1 files changed, 26 insertions(+), 0 deletions(-)
>
> diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
> index 4fce6e6..fdb2db5 100644
> --- a/fs/cifs/cifs_debug.c
> +++ b/fs/cifs/cifs_debug.c
> @@ -119,6 +119,32 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
> "Display Internal CIFS Data Structures for Debugging\n"
> "---------------------------------------------------\n");
> seq_printf(m, "CIFS Version %s\n", CIFS_VERSION);
> + seq_printf(m, "Features: ");
> +#ifdef CONFIG_CIFS_DFS_UPCALL
> + seq_printf(m, "dfs");
> + seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_FSCACHE
> + seq_printf(m, "fscache");
> + seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_WEAK_PW_HASH
> + seq_printf(m, "lanman");
> + seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_POSIX
> + seq_printf(m, "posix");
> + seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_UPCALL
> + seq_printf(m, "spnego");
> + seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_XATTR
> + seq_printf(m, "xattr");
> + seq_putc(m, ' ');
^^^^^^
Nit -- this space isn't needed.
> +#endif
> + seq_putc(m, '\n');
> seq_printf(m, "Active VFS Requests: %d\n", GlobalTotalActiveXid);
> seq_printf(m, "Servers:");
>
>
>
Other than that, looks good.
--
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-08-04 4:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-30 12:55 [PATCH 1/2] cifs: show features compiled in as part of DebugData Suresh Jayaraman
2010-07-30 13:04 ` Jeff Layton
2010-07-30 14:39 ` Steve French
[not found] ` <AANLkTikgA8mXTcX-i3avjuQygrekicntcy3P2NBW5QuB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-30 14:57 ` Jeff Layton
[not found] ` <20100730105734.0827c057-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2010-07-30 17:53 ` Steve French
[not found] ` <AANLkTinyH4qiEBwtULoen8xSypaWxWCr3MQhDWf-Ftz4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-04 4:28 ` Steve French
2010-07-30 16:45 ` Suresh Jayaraman
-- strict thread matches above, loose matches on Subject: below --
2010-07-30 12:27 Suresh Jayaraman
2010-07-30 12:39 ` Jeff Layton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.