From: Yinghai Lu <yinghai@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: kexec@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86,setup: add serial_console_port_base in boot_params
Date: Sat, 31 Jul 2010 22:20:28 -0700 [thread overview]
Message-ID: <4C55041C.1030008@kernel.org> (raw)
In-Reply-To: <m14offuk8p.fsf@fess.ebiederm.org>
On 07/31/2010 07:42 PM, Eric W. Biederman wrote:
> Yinghai Lu <yinghai@kernel.org> writes:
>
>> On 07/31/2010 02:02 PM, H. Peter Anvin wrote:
>>> On 07/31/2010 11:32 AM, Cyrill Gorcunov wrote:
>>>>>
>>>>> No, this is the internal part of the boot protocol, so it's not an issue.
>>>>>
>>>>
>>>> Peter, I didn't mean any issue here, I meant that bootloaders don't know about
>>>> this field yet and they will have to update own sources to pass port value
>>>> at proper place of boot params. Or I miss something?
>>>>
>>>
>>> Boot loaders that use the 16-bit entry point are unaffected.
>>>
>>> Boot loaders which use the 32-bit entry point but properly clears the
>>> zero page simply will not have the feature.
>>>
>>> Boot loaders which use the 32-bit entry point but doesn't clear the zero
>>> page are broken.
>>>
>> can you if this one is right for kexec path?
>
> I am walking out the door, but this seems like nonsense to me.
>
> Further I don't see why we would add something to the zero page
> when we have a perfectly good way to pass this information via
> the kernel command line. strstr and strtoul are trivial little
> functions so I don't see why anything would need to parse anything
> other than console= or early_printk=. The difference in code size
> is negligible.
>
so you prefer to check command line for console info in arch/x86/boot/compressed/misc.c again?
that commandline is analyzed in arch/x86/boot/tty.c already.
Yinghai
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Yinghai Lu <yinghai@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Pekka Enberg <penberg@cs.helsinki.fi>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kexec@lists.infradead.org
Subject: Re: [PATCH] x86,setup: add serial_console_port_base in boot_params
Date: Sat, 31 Jul 2010 22:20:28 -0700 [thread overview]
Message-ID: <4C55041C.1030008@kernel.org> (raw)
In-Reply-To: <m14offuk8p.fsf@fess.ebiederm.org>
On 07/31/2010 07:42 PM, Eric W. Biederman wrote:
> Yinghai Lu <yinghai@kernel.org> writes:
>
>> On 07/31/2010 02:02 PM, H. Peter Anvin wrote:
>>> On 07/31/2010 11:32 AM, Cyrill Gorcunov wrote:
>>>>>
>>>>> No, this is the internal part of the boot protocol, so it's not an issue.
>>>>>
>>>>
>>>> Peter, I didn't mean any issue here, I meant that bootloaders don't know about
>>>> this field yet and they will have to update own sources to pass port value
>>>> at proper place of boot params. Or I miss something?
>>>>
>>>
>>> Boot loaders that use the 16-bit entry point are unaffected.
>>>
>>> Boot loaders which use the 32-bit entry point but properly clears the
>>> zero page simply will not have the feature.
>>>
>>> Boot loaders which use the 32-bit entry point but doesn't clear the zero
>>> page are broken.
>>>
>> can you if this one is right for kexec path?
>
> I am walking out the door, but this seems like nonsense to me.
>
> Further I don't see why we would add something to the zero page
> when we have a perfectly good way to pass this information via
> the kernel command line. strstr and strtoul are trivial little
> functions so I don't see why anything would need to parse anything
> other than console= or early_printk=. The difference in code size
> is negligible.
>
so you prefer to check command line for console info in arch/x86/boot/compressed/misc.c again?
that commandline is analyzed in arch/x86/boot/tty.c already.
Yinghai
next prev parent reply other threads:[~2010-08-01 5:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 22:27 [PATCH] x86,setup: add serial_console_port_base in boot_params Yinghai Lu
2010-07-16 0:12 ` H. Peter Anvin
2010-07-16 1:30 ` Yinghai Lu
2010-07-31 8:34 ` Cyrill Gorcunov
2010-07-31 18:21 ` H. Peter Anvin
2010-07-31 18:32 ` Cyrill Gorcunov
2010-07-31 21:02 ` H. Peter Anvin
2010-07-31 21:31 ` Cyrill Gorcunov
2010-08-01 1:53 ` Yinghai Lu
2010-08-01 1:53 ` Yinghai Lu
2010-08-01 2:42 ` Eric W. Biederman
2010-08-01 2:42 ` Eric W. Biederman
2010-08-01 5:20 ` Yinghai Lu [this message]
2010-08-01 5:20 ` Yinghai Lu
2010-08-03 2:03 ` Eric W. Biederman
2010-08-03 2:03 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C55041C.1030008@kernel.org \
--to=yinghai@kernel.org \
--cc=ebiederm@xmission.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.