All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: Jerone Young <jerone.young@canonical.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] [RESEND] FIX to not expose SPDIF on Thinkpad X301, since it does not have the ability to use SPDIF
Date: Tue, 03 Aug 2010 08:16:59 +0200	[thread overview]
Message-ID: <4C57B45B.8030709@canonical.com> (raw)
In-Reply-To: <1280815520.2529.157.camel@laptop>

I think Takashi wants you to use "git format-patch" to generate the
patch. At least I do so and that has been working well so far.

// David

2010-08-03 08:05, Jerone Young skrev:
> The Lenovo X301 does not have the ability to connect to a docking
> station to use the SPDIF port. It also does not have the ability to do
> SPDIF though the headphone jack or Display Port jacks.
> 
> This patch fixes it so this is not exposed for the X301 and users do
> think it has the ability to do SPDIF.
> 
> I tested both headphone & display port jacks and it is not there. I have
> tested this patch and it works great.
> 
> Also to add the other Thinkpads have different subsystem codec IDs. 
> Here are examples:
> 
> X301:
> http://launchpadlibrarian.net/31561902/Card0.Codecs.codec.0.txt
> 
> X200:
> http://launchpadlibrarian.net/49055036/Card0.Codecs.codec.0.txt
> 
> W500:
> http://launchpadlibrarian.net/36276057/Card0.Codecs.codec.0.txt
> 
> 
> Signed-off-by: Jerone Young <jerone.young@canonical.com>
> 
> diff --git a/pci/hda/patch_conexant.c b/pci/hda/patch_conexant.c
> index c49030b..abc320a 100644
> @@ -2004,6 +2006,11 @@ static int patch_cxt5051(struct hda_codec *codec)
>  		break;
>  	case CXT5051_LENOVO_X200:
>  		spec->init_verbs[0] = cxt5051_lenovo_x200_init_verbs;
> +		/* Thinkpad X301 does not have S/PDIF wired and no ability
> +		   to use a docking station. */
> +		if (codec->subsystem_id == 0x17aa211f) {
> +			spec->multiout.dig_out_nid = 0; 
> +		}
>  		break;
>  	case CXT5051_F700:
>  		spec->init_verbs[0] = cxt5051_f700_init_verbs;
> 
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 


-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

  reply	other threads:[~2010-08-03  6:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03  6:05 [PATCH] [RESEND] FIX to not expose SPDIF on Thinkpad X301, since it does not have the ability to use SPDIF Jerone Young
2010-08-03  6:16 ` David Henningsson [this message]
2010-08-03  6:21   ` Takashi Iwai
2010-08-03  6:37     ` Jerone Young
2010-08-03  6:20 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C57B45B.8030709@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jerone.young@canonical.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.