Re: [PATCH] tar: Upgrade to v1.23

[Scott Garman <sgarman@zenlinux.com>]

On 08/02/2010 11:14 PM, Frans Meulenbroeks wrote:
> 2010/8/3 Scott Garman<sgarman@zenlinux.com>
>
>> From: Scott Garman<scott.a.garman@intel.com>
>>
>> * Addresses CVE-2010-0624
>>
>
> Please have a look at http://wiki.openembedded.net/index.php/Commit_Policy
>
> And especially this section:

Hi Frans,

Thanks for sending me these pointers. However, I'm a bit unclear on what 
needs improvement. The subject line of this patch email corresponds to 
the first line of the commit message, doesn't it?

To go case-by-case:

>   * Have a clear commit message (example
> <http://wiki.openembedded.net/index.php/Commit_log_example>):
>      - The first line of commit is a summary of the changes.

Which in this case is:

tar: Upgrade to v1.23

>      - The first line should start with the name of the recipe the
> change affects.

tar: <- that's the name of the recipe

>      - The rest of the message should give more details on the change
> as appropriate.

Given how trivial the change is, there's not much else to say. I did 
make mention of the security advisory the upgrade fixes:

* Addresses CVE-2010-0624

>      - Mention the affected bug numbers if appropriate.

N/A

>      - Give credit where credit is due. If you commit someone else's
> work more or
>        less verbatim, you should use *git commit --author
> $mail-of-author*. If pulling
>        changes from somewhere like Poky or OpenMoko there is no problem with that
>        but mention where the changes came from.

Again, with something this trivial, I doubt anyone would consider me 
taking credit for something inappropriately.

>      - Include a Signed-off-by: line indicating the change has valid certificate
>        of origin as per the Linux kernel<http://lwn.net/Articles/139916/>

and indeed, I ended my commit with:

Signed-off-by: Scott Garman <sgarman@zenlinux.com>

I'm happy to respin the patch if needed, but I'm still unsure what needs 
to be changed.

Thanks,

Scott

-- 
Scott Garman
sgarman at zenlinux dot com