[PATCH] tar: Upgrade to v1.23

[PATCH] tar: Upgrade to v1.23

[Scott Garman]

From: Scott Garman <scott.a.garman@intel.com>

* Addresses CVE-2010-0624

Signed-off-by: Scott Garman <sgarman@zenlinux.com>
---
 recipes/tar/tar_1.22.bb |    4 ----
 recipes/tar/tar_1.23.bb |    4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)
 delete mode 100644 recipes/tar/tar_1.22.bb
 create mode 100644 recipes/tar/tar_1.23.bb

diff --git a/recipes/tar/tar_1.22.bb b/recipes/tar/tar_1.22.bb
deleted file mode 100644
index 4863e84..0000000
--- a/recipes/tar/tar_1.22.bb
+++ /dev/null
@@ -1,4 +0,0 @@
-require tar.inc
-
-SRC_URI[md5sum] = "07fa517027f426bb80f5f5ff91b63585"
-SRC_URI[sha256sum] = "3cefb67f197a3f8f5235999fe749ced0889466a71ddcbc96fddca84e5d53aa4d"
diff --git a/recipes/tar/tar_1.23.bb b/recipes/tar/tar_1.23.bb
new file mode 100644
index 0000000..89a0243
--- /dev/null
+++ b/recipes/tar/tar_1.23.bb
@@ -0,0 +1,4 @@
+require tar.inc
+
+SRC_URI[md5sum] = "41e2ca4b924ec7860e51b43ad06cdb7e"
+SRC_URI[sha256sum] = "c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36"
-- 
1.7.0.4

Re: [PATCH] tar: Upgrade to v1.23

[Scott Garman]

On 08/02/2010 09:01 PM, Scott Garman wrote:
> From: Scott Garman<scott.a.garman@intel.com>
>
> * Addresses CVE-2010-0624
>
> Signed-off-by: Scott Garman<sgarman@zenlinux.com>

Please do not include the first line of that commit log. Apparently 
updating my email address within ~/.gitinfo is insufficient to actually 
change my email address - go figure. :-/

Scott

Re: [PATCH] tar: Upgrade to v1.23

[Frans Meulenbroeks]

2010/8/3 Scott Garman <sgarman@zenlinux.com>

> From: Scott Garman <scott.a.garman@intel.com>
>
> * Addresses CVE-2010-0624
>

Please have a look at http://wiki.openembedded.net/index.php/Commit_Policy

And especially this section:

 * Have a clear commit message (example
<http://wiki.openembedded.net/index.php/Commit_log_example>):
    - The first line of commit is a summary of the changes.
    - The first line should start with the name of the recipe the
change affects.
    - The rest of the message should give more details on the change
as appropriate.
    - Mention the affected bug numbers if appropriate.
    - Give credit where credit is due. If you commit someone else's
work more or
      less verbatim, you should use *git commit --author
$mail-of-author*. If pulling
      changes from somewhere like Poky or OpenMoko there is no problem with that
      but mention where the changes came from.
    - Include a Signed-off-by: line indicating the change has valid certificate
      of origin as per the Linux kernel <http://lwn.net/Articles/139916/>



>
> Signed-off-by: Scott Garman <sgarman@zenlinux.com>
> ---
>  recipes/tar/tar_1.22.bb |    4 ----
>  recipes/tar/tar_1.23.bb |    4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
>  delete mode 100644 recipes/tar/tar_1.22.bb
>  create mode 100644 recipes/tar/tar_1.23.bb
>
> diff --git a/recipes/tar/tar_1.22.bb b/recipes/tar/tar_1.22.bb
> deleted file mode 100644
> index 4863e84..0000000
> --- a/recipes/tar/tar_1.22.bb
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -require tar.inc
> -
> -SRC_URI[md5sum] = "07fa517027f426bb80f5f5ff91b63585"
> -SRC_URI[sha256sum] =
> "3cefb67f197a3f8f5235999fe749ced0889466a71ddcbc96fddca84e5d53aa4d"
> diff --git a/recipes/tar/tar_1.23.bb b/recipes/tar/tar_1.23.bb
> new file mode 100644
> index 0000000..89a0243
> --- /dev/null
> +++ b/recipes/tar/tar_1.23.bb
> @@ -0,0 +1,4 @@
> +require tar.inc
> +
> +SRC_URI[md5sum] = "41e2ca4b924ec7860e51b43ad06cdb7e"
> +SRC_URI[sha256sum] =
> "c9328372db62fbb1d94c9e4e3cefc961111af46de47085b635359c00a0eebe36"
>

The rest looks good to me.

Frans

> --
> 1.7.0.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] tar: Upgrade to v1.23

[Scott Garman]

On 08/02/2010 11:14 PM, Frans Meulenbroeks wrote:
> 2010/8/3 Scott Garman<sgarman@zenlinux.com>
>
>> From: Scott Garman<scott.a.garman@intel.com>
>>
>> * Addresses CVE-2010-0624
>>
>
> Please have a look at http://wiki.openembedded.net/index.php/Commit_Policy
>
> And especially this section:

Hi Frans,

Thanks for sending me these pointers. However, I'm a bit unclear on what 
needs improvement. The subject line of this patch email corresponds to 
the first line of the commit message, doesn't it?

To go case-by-case:

>   * Have a clear commit message (example
> <http://wiki.openembedded.net/index.php/Commit_log_example>):
>      - The first line of commit is a summary of the changes.

Which in this case is:

tar: Upgrade to v1.23

>      - The first line should start with the name of the recipe the
> change affects.

tar: <- that's the name of the recipe

>      - The rest of the message should give more details on the change
> as appropriate.

Given how trivial the change is, there's not much else to say. I did 
make mention of the security advisory the upgrade fixes:

* Addresses CVE-2010-0624

>      - Mention the affected bug numbers if appropriate.

N/A

>      - Give credit where credit is due. If you commit someone else's
> work more or
>        less verbatim, you should use *git commit --author
> $mail-of-author*. If pulling
>        changes from somewhere like Poky or OpenMoko there is no problem with that
>        but mention where the changes came from.

Again, with something this trivial, I doubt anyone would consider me 
taking credit for something inappropriately.

>      - Include a Signed-off-by: line indicating the change has valid certificate
>        of origin as per the Linux kernel<http://lwn.net/Articles/139916/>

and indeed, I ended my commit with:

Signed-off-by: Scott Garman <sgarman@zenlinux.com>

I'm happy to respin the patch if needed, but I'm still unsure what needs 
to be changed.

Thanks,

Scott

-- 
Scott Garman
sgarman at zenlinux dot com

Re: [PATCH] tar: Upgrade to v1.23

[Frans Meulenbroeks]

2010/8/3 Scott Garman <sgarman@zenlinux.com>

> On 08/02/2010 11:14 PM, Frans Meulenbroeks wrote:
>
>> 2010/8/3 Scott Garman<sgarman@zenlinux.com>
>>
>>  From: Scott Garman<scott.a.garman@intel.com>
>>>
>>> * Addresses CVE-2010-0624
>>>
>>>
>> Please have a look at
>> http://wiki.openembedded.net/index.php/Commit_Policy
>>
>> And especially this section:
>>
>
> Hi Frans,
>
> Thanks for sending me these pointers. However, I'm a bit unclear on what
> needs improvement. The subject line of this patch email corresponds to the
> first line of the commit message, doesn't it?
>
> To go case-by-case:
>
>   * Have a clear commit message (example
>> <http://wiki.openembedded.net/index.php/Commit_log_example>):
>>     - The first line of commit is a summary of the changes.
>>
>
> Which in this case is:
>
> tar: Upgrade to v1.23
>
>      - The first line should start with the name of the recipe the
>> change affects.
>>
>
Ah ofcourse actually that was what I was missing.
Will push it in a few minutes if not done yet.

Frans

Re: [PATCH] tar: Upgrade to v1.23

[Scott Garman]

On 08/03/2010 09:07 AM, Frans Meulenbroeks wrote:
>> tar: Upgrade to v1.23
>>
>>       - The first line should start with the name of the recipe the
>>> change affects.
>>>
>>
> Ah ofcourse actually that was what I was missing.
> Will push it in a few minutes if not done yet.

Much appreciated, Frans!

Thanks,

Scott

-- 
Scott Garman
sgarman at zenlinux dot com