Add CDMA/EVDO into TODO

Add CDMA/EVDO into TODO

[Wang, Pengzhuo]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

Hello All
       I have a plan to add CDMA/EVDO support into ofono. The
attachement is TODO patch I get ready to submit into ofono.
In this patch file is  a simple description about what CDMA/EVDO
features will be covered.   I'd love to have your thoughts about this.

Best Regards
 
pengzhuo wang(bobwang)
Professional Service | WindRiver P.R.China Room3-H,New JinQiao Plaza,
No.585 Xizhang Rd(M),Shanghai,200003,P.R.C Tel:86-21-63585586/87/89/90
ext.208 Fax:86-21-63585591


[-- Attachment #2: 0001-Update-TODO-to-add-CDMA-EVDO-support.patch --]
[-- Type: application/octet-stream, Size: 1075 bytes --]

From 9af61f4d2546ff28a8b1ed9546c41f5f3c945f5a Mon Sep 17 00:00:00 2001
From: Pengzhuo wang <pengzhuo.wang0@windriver.com>
Date: Tue, 3 Aug 2010 19:53:32 +0800
Subject: [PATCH] Update TODO to add CDMA/EVDO support

---
 TODO |   25 +++++++++++++++++++++++++
 1 files changed, 25 insertions(+), 0 deletions(-)

diff --git a/TODO b/TODO
index 5221324..b9130d3 100644
--- a/TODO
+++ b/TODO
@@ -567,3 +567,28 @@ Miscellaneous
 
   Priority: High
   Complexity: C1
+
+CDMA/EVDO
+=========
+
+- Extend modem interface with a 'Type' property to indicate the modem type. 
+
+  Priority: High
+  Complexity: C1
+
+- Disable CDMA unsupport feature for CDMA modem. Include USSD, supplementary services, 
+  SSN, PDP context.  
+  
+  Priority: High
+  Complexity: C2
+  
+- Add call forwarding, call waiting, network registration implementation for CDMA.
+  
+  Priority: High
+  Complexity: C4
+
+- Change radio setting, SIM manager, SMS manager, voice call manager, Data Connection
+  Manager to make them support both GSM and CDMA
+  
+  Priority: High
+  Complexity: C8
-- 
1.6.5.2

Re: Add CDMA/EVDO into TODO

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 2110 bytes --]

Hi Penghuo,

I am not fully against submitting patches as attachments, but if you do
expect reviews, then we do prefer inline patches. I would advise to
start using git send-email for patch submission.

> From 9af61f4d2546ff28a8b1ed9546c41f5f3c945f5a Mon Sep 17 00:00:00 2001
> From: Pengzhuo wang <pengzhuo.wang0@windriver.com>
> Date: Tue, 3 Aug 2010 19:53:32 +0800
> Subject: [PATCH] Update TODO to add CDMA/EVDO support
> 
> ---
>  TODO |   25 +++++++++++++++++++++++++
>  1 files changed, 25 insertions(+), 0 deletions(-)
> 
> diff --git a/TODO b/TODO
> index 5221324..b9130d3 100644
> --- a/TODO
> +++ b/TODO
> @@ -567,3 +567,28 @@ Miscellaneous
>  
>    Priority: High
>    Complexity: C1
> +
> +CDMA/EVDO
> +=========
> +
> +- Extend modem interface with a 'Type' property to indicate the modem
> type. 
> +
> +  Priority: High
> +  Complexity: C1

We need to discuss this with Denis. Either we do it here on the mailing
list or on #ofono IRC channel on Freenode.

> +- Disable CDMA unsupport feature for CDMA modem. Include USSD,
> supplementary services, 
> +  SSN, PDP context.  
> +  
> +  Priority: High
> +  Complexity: C2

Actually this is not a TODO item. That is a modem plugin specific
detail. If your modem (CDMA or not) doesn't supports such features, then
don't enable the atoms for it.

So I say that this already supported ;)

> +- Add call forwarding, call waiting, network registration
> implementation for CDMA.
> +  
> +  Priority: High
> +  Complexity: C4

This is more like add CDMA specific atom drivers for netreg etc. That
these are CDMA specific is more a minor detail.

I like to hear Denis comment on his, but first guess would be that this
should be done as drivers/cdmamodem/...

> +- Change radio setting, SIM manager, SMS manager, voice call manager,
> Data Connection
> +  Manager to make them support both GSM and CDMA
> +  
> +  Priority: High
> +  Complexity: C8

I think you have to be a bit more specific here. Maybe it is a good idea
to split them into separate items.

Regards

Marcel

RE: Add CDMA/EVDO into TODO

[Zhang, Caiwen]

[-- Attachment #1: Type: text/plain, Size: 3277 bytes --]

Hi Marcel,

> -----Original Message-----
> From: Marcel Holtmann [mailto:marcel(a)holtmann.org]
> Sent: Tuesday, August 03, 2010 1:30 PM
> To: ofono(a)ofono.org
> Cc: Zhang, Caiwen; Schoppa, Chris
> Subject: Re: Add CDMA/EVDO into TODO
> 
> Hi Penghuo,
> 
> I am not fully against submitting patches as attachments, but if you do
> expect reviews, then we do prefer inline patches. I would advise to
> start using git send-email for patch submission.
> 
> > From 9af61f4d2546ff28a8b1ed9546c41f5f3c945f5a Mon Sep 17 00:00:00
> 2001
> > From: Pengzhuo wang <pengzhuo.wang0@windriver.com>
> > Date: Tue, 3 Aug 2010 19:53:32 +0800
> > Subject: [PATCH] Update TODO to add CDMA/EVDO support
> >
> > ---
> >  TODO |   25 +++++++++++++++++++++++++
> >  1 files changed, 25 insertions(+), 0 deletions(-)
> >
> > diff --git a/TODO b/TODO
> > index 5221324..b9130d3 100644
> > --- a/TODO
> > +++ b/TODO
> > @@ -567,3 +567,28 @@ Miscellaneous
> >
> >    Priority: High
> >    Complexity: C1
> > +
> > +CDMA/EVDO
> > +=========
> > +
> > +- Extend modem interface with a 'Type' property to indicate the
> modem
> > type.
> > +
> > +  Priority: High
> > +  Complexity: C1
> 
> We need to discuss this with Denis. Either we do it here on the mailing
> list or on #ofono IRC channel on Freenode.
> 
> > +- Disable CDMA unsupport feature for CDMA modem. Include USSD,
> > supplementary services,
> > +  SSN, PDP context.
> > +
> > +  Priority: High
> > +  Complexity: C2
> 
> Actually this is not a TODO item. That is a modem plugin specific
> detail. If your modem (CDMA or not) doesn't supports such features,
> then
> don't enable the atoms for it.
> 
> So I say that this already supported ;)
> 

I do agree, besides, some atoms such as call-barring, call-setting ...
Need do a little change, we need to disable the USSD watch and SSN watch etc.

> > +- Add call forwarding, call waiting, network registration
> > implementation for CDMA.
> > +
> > +  Priority: High
> > +  Complexity: C4
> 
> This is more like add CDMA specific atom drivers for netreg etc. That
> these are CDMA specific is more a minor detail.
> 
> I like to hear Denis comment on his, but first guess would be that this
> should be done as drivers/cdmamodem/...
> 
These features in CDMA are very different from that in GSM. Call forwarding and call waiting
are achieved by dial a specified number(feature code). In CDMA system, the modem 
will always auto register network, but in GSM system, there are different register modes,
and can scan neighbor networks. 

So we would like implement them in separate files such as cdma_call-forwarding.c ...
But not base on current implementation.

> > +- Change radio setting, SIM manager, SMS manager, voice call manager,
> > Data Connection
> > +  Manager to make them support both GSM and CDMA
> > +
> > +  Priority: High
> > +  Complexity: C8
> 
> I think you have to be a bit more specific here. Maybe it is a good
> idea
> to split them into separate items.
> 
> Regards
> 
> Marcel
> 

Yes, we do agree. We will do it. 

Generally, before do any change, we will sent out the proposed solution,
and collect the suggestion first.


Best regard,

Caiwen 

Re: Add CDMA/EVDO into TODO

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 3092 bytes --]

Hi Caiwen,

>>> +- Disable CDMA unsupport feature for CDMA modem. Include USSD,
>>> supplementary services,
>>> +  SSN, PDP context.
>>> +
>>> +  Priority: High
>>> +  Complexity: C2
>>
>> Actually this is not a TODO item. That is a modem plugin specific
>> detail. If your modem (CDMA or not) doesn't supports such features,
>> then
>> don't enable the atoms for it.
>>
>> So I say that this already supported ;)
>>
> 
> I do agree, besides, some atoms such as call-barring, call-setting ...
> Need do a little change, we need to disable the USSD watch and SSN watch etc.
> 

Just to nitpick, but if you don't create the SSN/USSD atoms, then the
atom watch will never fire.

Can you include descriptions of what needs to change in these atoms in
your TODO list as well?

>>> +- Add call forwarding, call waiting, network registration
>>> implementation for CDMA.
>>> +
>>> +  Priority: High
>>> +  Complexity: C4
>>
>> This is more like add CDMA specific atom drivers for netreg etc. That
>> these are CDMA specific is more a minor detail.
>>
>> I like to hear Denis comment on his, but first guess would be that this
>> should be done as drivers/cdmamodem/...
>>
> These features in CDMA are very different from that in GSM. Call forwarding and call waiting
> are achieved by dial a specified number(feature code). In CDMA system, the modem 
> will always auto register network, but in GSM system, there are different register modes,
> and can scan neighbor networks. 
> 
> So we would like implement them in separate files such as cdma_call-forwarding.c ...
> But not base on current implementation.
> 

I'm not against this in general, but please start sharing with us more
details.  E.g. why these are different, why the current atom cannot be
extended, etc.  In some respect you will have to educate us about CDMA
first.

It would also be very helpful if you posted a table with CDMA feature
break down and the relevant CDMA specs.  E.g. like SMS in 3GPP is
covered in 23.040, CBS in 23.041, etc.  This way we can go straight to
the spec to help us understand why a particular solution was proposed.
I believe that would shorten our ramp up time considerably.  I've
updated doc/standards.txt to give you an idea of what I'd like to see.

>>> +- Change radio setting, SIM manager, SMS manager, voice call manager,
>>> Data Connection
>>> +  Manager to make them support both GSM and CDMA
>>> +
>>> +  Priority: High
>>> +  Complexity: C8
>>
>> I think you have to be a bit more specific here. Maybe it is a good
>> idea
>> to split them into separate items.
>>
>> Regards
>>
>> Marcel
>>
> 
> Yes, we do agree. We will do it. 
> 
> Generally, before do any change, we will sent out the proposed solution,
> and collect the suggestion first.
> 

I'd also like you to greatly expand your TODO item descriptions.  The
current level of detail is not enough.  Think of TODO as a sort of
high-level design document, but targeted at developers.  The more detail
you add here, the better.

Regards,
-Denis