All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Ohlstein <johlstei@codeaurora.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-msm@vger.kernel.org, smuckle@codeaurora.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: hotplug and init section
Date: Tue, 03 Aug 2010 17:51:34 -0700	[thread overview]
Message-ID: <4C58B996.3000601@codeaurora.org> (raw)
In-Reply-To: <20100803230541.GA30769@n2100.arm.linux.org.uk>

Russell King - ARM Linux wrote:
> Try this - I've only build-tested this so far:
>
> diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
> index b9505aa..98949b2 100644
> --- a/arch/arm/kernel/head-common.S
> +++ b/arch/arm/kernel/head-common.S
> @@ -143,7 +143,7 @@ __error:
>  	b	1b
>  ENDPROC(__error)
>  
> -
> +	__CPUINIT
>  /*
>   * Read processor ID register (CP#15, CR0), and look up in the linker-built
>   * supported processor list.  Note that we can't use the absolute addresses
> @@ -235,6 +235,7 @@ ENTRY(lookup_machine_type)
>  	ldmfd	sp!, {r4 - r6, pc}
>  ENDPROC(lookup_machine_type)
>  
> +	__HEAD
>  /* Determine validity of the r2 atags pointer.  The heuristic requires
>   * that the pointer be aligned, in the first 16k of physical RAM and
>   * that the ATAG_CORE marker is first and present.  Future revisions
> diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S
> index eb62bf9..7e0a673 100644
> --- a/arch/arm/kernel/head.S
> +++ b/arch/arm/kernel/head.S
> @@ -104,6 +104,7 @@ ENTRY(stext)
>  ENDPROC(stext)
>  
>  #if defined(CONFIG_SMP)
> +	__CPUINIT
>  ENTRY(secondary_startup)
>  	/*
>  	 * Common entry point for secondary CPUs.
> @@ -202,7 +203,7 @@ __turn_mmu_on:
>  	mov	pc, r3
>  ENDPROC(__turn_mmu_on)
>  
> -
> +	__HEAD
>  /*
>   * Setup the initial page tables.  We only setup the barest
>   * amount which are required to get the kernel running, which
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>   
This doesn't boot for me, I will look into it further. I am using a 
2.6.32 kernel, but I think commit 
a1c29fa34b6be6b7c1d9075f4057c3995c993e8c or  "ARM: convert to use __HEAD 
and HEAD_TEXT macros" should be sufficient.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


WARNING: multiple messages have this Message-ID (diff)
From: johlstei@codeaurora.org (Jeff Ohlstein)
To: linux-arm-kernel@lists.infradead.org
Subject: hotplug and init section
Date: Tue, 03 Aug 2010 17:51:34 -0700	[thread overview]
Message-ID: <4C58B996.3000601@codeaurora.org> (raw)
In-Reply-To: <20100803230541.GA30769@n2100.arm.linux.org.uk>

Russell King - ARM Linux wrote:
> Try this - I've only build-tested this so far:
>
> diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
> index b9505aa..98949b2 100644
> --- a/arch/arm/kernel/head-common.S
> +++ b/arch/arm/kernel/head-common.S
> @@ -143,7 +143,7 @@ __error:
>  	b	1b
>  ENDPROC(__error)
>  
> -
> +	__CPUINIT
>  /*
>   * Read processor ID register (CP#15, CR0), and look up in the linker-built
>   * supported processor list.  Note that we can't use the absolute addresses
> @@ -235,6 +235,7 @@ ENTRY(lookup_machine_type)
>  	ldmfd	sp!, {r4 - r6, pc}
>  ENDPROC(lookup_machine_type)
>  
> +	__HEAD
>  /* Determine validity of the r2 atags pointer.  The heuristic requires
>   * that the pointer be aligned, in the first 16k of physical RAM and
>   * that the ATAG_CORE marker is first and present.  Future revisions
> diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S
> index eb62bf9..7e0a673 100644
> --- a/arch/arm/kernel/head.S
> +++ b/arch/arm/kernel/head.S
> @@ -104,6 +104,7 @@ ENTRY(stext)
>  ENDPROC(stext)
>  
>  #if defined(CONFIG_SMP)
> +	__CPUINIT
>  ENTRY(secondary_startup)
>  	/*
>  	 * Common entry point for secondary CPUs.
> @@ -202,7 +203,7 @@ __turn_mmu_on:
>  	mov	pc, r3
>  ENDPROC(__turn_mmu_on)
>  
> -
> +	__HEAD
>  /*
>   * Setup the initial page tables.  We only setup the barest
>   * amount which are required to get the kernel running, which
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>   
This doesn't boot for me, I will look into it further. I am using a 
2.6.32 kernel, but I think commit 
a1c29fa34b6be6b7c1d9075f4057c3995c993e8c or  "ARM: convert to use __HEAD 
and HEAD_TEXT macros" should be sufficient.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  reply	other threads:[~2010-08-04  0:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22 19:33 hotplug and init section smuckle
2010-07-22 19:33 ` smuckle at codeaurora.org
2010-07-22 20:57 ` Russell King - ARM Linux
2010-07-22 20:57   ` Russell King - ARM Linux
2010-08-03 22:31   ` Jeff Ohlstein
2010-08-03 22:31     ` Jeff Ohlstein
2010-08-03 23:05     ` Russell King - ARM Linux
2010-08-03 23:05       ` Russell King - ARM Linux
2010-08-04  0:51       ` Jeff Ohlstein [this message]
2010-08-04  0:51         ` Jeff Ohlstein
2010-08-04 17:56         ` Russell King - ARM Linux
2010-08-04 17:56           ` Russell King - ARM Linux
2010-07-23  5:20 ` Shilimkar, Santosh
2010-07-23  5:20   ` Shilimkar, Santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C58B996.3000601@codeaurora.org \
    --to=johlstei@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=smuckle@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.