Re: [PATCH 2/2] recipe for scli-0.4.0

[Henri Bragge <henri.bragge@dcombus.com>]

Frans Meulenbroeks wrote:
> 2010/8/4 Henri Bragge <henri.bragge@dcombus.com>
>
>   
>> Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
>> ---
>>  recipes/scli/scli.inc    |    6 ++++++
>>  recipes/scli/scli_svn.bb |    8 ++++++++
>>  2 files changed, 14 insertions(+), 0 deletions(-)
>>  create mode 100644 recipes/scli/scli.inc
>>  create mode 100644 recipes/scli/scli_svn.bb
>>
>> diff --git a/recipes/scli/scli.inc b/recipes/scli/scli.inc
>> new file mode 100644
>> index 0000000..abe341d
>> --- /dev/null
>> +++ b/recipes/scli/scli.inc
>> @@ -0,0 +1,6 @@
>> +DESCRIPTION = "SNMP Command Line Interface"
>> +LICENSE = "GPLv2"
>> +SECTION = "console/network"
>> +DEPENDS = "gsnmp readline libxml2 ncurses"
>> +
>> +inherit autotools
>> diff --git a/recipes/scli/scli_svn.bb b/recipes/scli/scli_svn.bb
>> new file mode 100644
>> index 0000000..45bd08e
>> --- /dev/null
>> +++ b/recipes/scli/scli_svn.bb
>> @@ -0,0 +1,8 @@
>> +require scli.inc
>> +
>> +SRCREV = "3285"
>> +PV = "0.4.0+svnr${SRCREV}"
>> +PR = "r1"
>>
>>     
> +
>   
>> +SRC_URI = "svn://
>> cnds.eecs.jacobs-university.de/svn/schoenw/src/scli;module=trunk;proto=https
>> "
>> +S = "${WORKDIR}/trunk"
>>
>>     
>
> Same remarks as for the other one.
> Also, do we need the .inc file. If I look at the content it is hardly worth
> putting it in a separate file.
>
> Then again *if* you insist on an inc file you should also have an INC_PR.
>
> This also holds for the other recipe.
>   

Thanks for the comments, sent v2 of the patches.

Just thought .inc would be a good idea to separate generic stuff from 
svn-specific, but indeed there's very little of the generic part to 
justify its own file. Fixed the PRs also.

Btw, only https seems to be available.

- Henri