From: Henri Bragge <henri.bragge@dcombus.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros
Date: Mon, 09 Aug 2010 15:05:31 +0300 [thread overview]
Message-ID: <4C5FEF0B.2070600@dcombus.com> (raw)
In-Reply-To: <1281354725.3767.25.camel@mattotaupa>
Paul Menzel wrote:
> Is there an upstream bug for this? If not, it would be great if you
> could sent it upstream.
>
The bug is still present in upstream too, but I will send this patch to
the gsnmp maintainer if it does the trick (or should it be the other way
around?).
> Am Montag, den 09.08.2010, 14:36 +0300 schrieb Henri Bragge:
>
>> Signed-off-by: Henri Bragge <henri.bragge@dcombus.com>
>> ---
>> recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch | 24 ++++++++++++++++++++++++
>> recipes/gsnmp/gsnmp_0.3.0.bb | 3 ++-
>> 2 files changed, 26 insertions(+), 1 deletions(-)
>> create mode 100644 recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
>>
>> diff --git a/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
>> new file mode 100644
>> index 0000000..138c9e6
>> --- /dev/null
>> +++ b/recipes/gsnmp/gsnmp-0.3.0/quote-fix.patch
>> @@ -0,0 +1,24 @@
>> +diff -Nurd gsnmp-0.3.0.orig/acinclude.m4 gsnmp-0.3.0/acinclude.m4
>> +--- gsnmp-0.3.0.orig/acinclude.m4 2010-02-19 10:35:29.000000000 +0200
>> ++++ gsnmp-0.3.0/acinclude.m4 2010-08-09 13:30:32.000000000 +0300
>> +@@ -6,7 +6,7 @@
>> + dnl usually in <utime.h>.
>> + dnl Some systems have utime.h but don't declare the struct anywhere.
>> +
>> +-AC_DEFUN(jm_CHECK_TYPE_STRUCT_UTIMBUF,
>> ++AC_DEFUN([jm_CHECK_TYPE_STRUCT_UTIMBUF],
>> + [
>> + AC_CHECK_HEADERS(utime.h)
>> + AC_REQUIRE([AC_HEADER_TIME])
>> +diff -Nurd gsnmp-0.3.0.orig/gsnmp.m4 gsnmp-0.3.0/gsnmp.m4
>> +--- gsnmp-0.3.0.orig/gsnmp.m4 2010-02-19 10:35:29.000000000 +0200
>> ++++ gsnmp-0.3.0/gsnmp.m4 2010-08-09 13:30:46.000000000 +0300
>> +@@ -1,7 +1,7 @@
>> + dnl AM_PATH_GSNMP()
>> + dnl
>> +
>> +-AC_DEFUN(AM_PATH_GSNMP,
>> ++AC_DEFUN([AM_PATH_GSNMP],
>> + [
>> + PKG_CHECK_MODULES(GSNMP, glib-2.0 >= 2.0.1)
>> + ])
>>
>
> Why is this check needed? Maybe add a note to the commit message or
> split the patch.
>
About that I've no idea, notice that I just added the brackets there.
>
>> diff --git a/recipes/gsnmp/gsnmp_0.3.0.bb b/recipes/gsnmp/gsnmp_0.3.0.bb
>> index b191762..6287010 100644
>> --- a/recipes/gsnmp/gsnmp_0.3.0.bb
>> +++ b/recipes/gsnmp/gsnmp_0.3.0.bb
>> @@ -4,7 +4,8 @@ LICENSE = "GPLv2"
>> DEPENDS = "glib-2.0 gnet"
>> PR = "r0"
>>
>
> I guess you need to increase `PR`.
>
> […]
>
Will do.
- Henri
next prev parent reply other threads:[~2010-08-09 12:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 10:43 recipes for gsnmp and scli Henri Bragge
2010-08-04 10:43 ` [PATCH 1/2] recipe for gsnmp-0.3.0 Henri Bragge
2010-08-04 10:43 ` [PATCH 2/2] recipe for scli-0.4.0 Henri Bragge
2010-08-04 11:54 ` Frans Meulenbroeks
2010-08-04 12:48 ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
2010-08-04 12:48 ` [PATCH v2 2/2] recipe for scli-0.4.0 Henri Bragge
2010-08-04 17:43 ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Frans Meulenbroeks
2010-08-05 8:53 ` Henri Bragge
2010-08-05 10:05 ` Frans Meulenbroeks
2010-08-05 18:49 ` Frans Meulenbroeks
2010-08-06 9:32 ` Frans Meulenbroeks
2010-08-06 10:05 ` Henri Bragge
2010-08-06 14:08 ` Frans Meulenbroeks
2010-08-09 11:36 ` [PATCH 1/1] gsnmp-0.3.0: fix quoting in autoconf macros Henri Bragge
2010-08-09 11:52 ` Paul Menzel
2010-08-09 12:05 ` Henri Bragge [this message]
2010-08-09 12:36 ` Paul Menzel
2010-08-09 15:31 ` [PATCH v3 " Henri Bragge
2010-08-09 15:43 ` [PATCH " Henri Bragge
2010-08-09 19:16 ` Frans Meulenbroeks
2010-08-09 11:43 ` [PATCH v2 1/2] recipe for gsnmp-0.3.0 Henri Bragge
2010-08-09 12:20 ` [PATCH v2 1/1] gsnmp-0.3.0: fix quoting in autoconf macros Henri Bragge
2010-08-04 12:54 ` [PATCH 2/2] recipe for scli-0.4.0 Henri Bragge
2010-08-05 8:44 ` [PATCH v3 1/2] recipe for gsnmp-0.3.0 Henri Bragge
2010-08-05 8:44 ` [PATCH v3 2/2] recipe for scli-0.4.0 Henri Bragge
2010-08-05 18:47 ` Frans Meulenbroeks
2010-08-04 11:51 ` [PATCH 1/2] recipe for gsnmp-0.3.0 Frans Meulenbroeks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5FEF0B.2070600@dcombus.com \
--to=henri.bragge@dcombus.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.