Re: [PATCH] x86 emulator: Add stc instruction (opcode 0xf9)

[Avi Kivity <avi@redhat.com>]

  On 08/05/2010 04:01 PM, Mohammed Gamal wrote:
> On Thu, Aug 5, 2010 at 3:49 PM, Gleb Natapov<gleb@redhat.com>  wrote:
>> On Thu, Aug 05, 2010 at 03:42:49PM +0300, Mohammed Gamal wrote:
>>> Signed-off-by: Mohammed Gamal<m.gamal005@gmail.com>
>>> ---
>>>   arch/x86/kvm/emulate.c |    6 +++++-
>>>   1 files changed, 5 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
>>> index f0f4a43..f345df0 100644
>>> --- a/arch/x86/kvm/emulate.c
>>> +++ b/arch/x86/kvm/emulate.c
>>> @@ -2269,7 +2269,7 @@ static struct opcode opcode_table[256] = {
>>>        N, N, N, N,
>>>        D(ImplicitOps | Priv), D(ImplicitOps), G(ByteOp, group3), G(0, group3),
>>>        /* 0xF8 - 0xFF */
>>> -     D(ImplicitOps), N, D(ImplicitOps), D(ImplicitOps),
>>> +     D(ImplicitOps), D(ImplicitOps), D(ImplicitOps), D(ImplicitOps),
>>>        D(ImplicitOps), D(ImplicitOps), G(0, group4), G(0, group5),
>>>   };
>>>
>>> @@ -3129,6 +3129,10 @@ special_insn:
>>>                ctxt->eflags&= ~EFLG_CF;
>>>                c->dst.type = OP_NONE;  /* Disable writeback. */
>>>                break;
>>> +     case 0xf9: /* stc */
>>> +             ctxt->eflags |= EFLG_CF;
>>> +             c->dst.type = OP_NONE;  /* Disable writeback */
>> With "disable writeback when decode dest operand" patch (which should be
>> applied already) this is no longer needed.
> Right. Should I wait for it to be merged and resend?

It's merged (in next branch), but I'll just drop that line when applying.

-- 
error compiling committee.c: too many arguments to function