From: Jens Axboe <jaxboe@fusionio.com>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH 3/3 v2] mm: Avoid resetting wb_start after each writeback round
Date: Thu, 5 Aug 2010 21:38:39 +0200 [thread overview]
Message-ID: <4C5B133F.60109@fusionio.com> (raw)
In-Reply-To: <1281034399-13055-4-git-send-email-jack@suse.cz>
On 08/05/2010 08:53 PM, Jan Kara wrote:
> WB_SYNC_NONE writeback is done in rounds of 1024 pages so that we don't write
> out some huge inode for too long while starving writeout of other inodes. To
> avoid livelocks, we record time we started writeback in wbc->wb_start and do
> not write out inodes which were dirtied after this time. But currently,
> writeback_inodes_wb() resets wb_start each time it is called thus effectively
> invalidating this logic and making any WB_SYNC_NONE writeback prone to
> livelocks.
>
> This patch makes sure wb_start is set only once when we start writeback.
Acked-by: Jens Axboe <jaxboe@fusionio.com>
--
Jens Axboe
Confidentiality Notice: This e-mail message, its contents and any attachments to it are confidential to the intended recipient, and may contain information that is privileged and/or exempt from disclosure under applicable law. If you are not the intended recipient, please immediately notify the sender and destroy the original e-mail message and any attachments (and any copies that may have been made) from your system or otherwise. Any unauthorized use, copying, disclosure or distribution of this information is strictly prohibited.
next prev parent reply other threads:[~2010-08-05 19:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 18:53 [PATCH 0/3 v2] Three writeback fixes to stop sync(1) livelocks Jan Kara
2010-08-05 18:53 ` [PATCH 1/3 v2] mm: Stop background writeback if there is other work queued for the thread Jan Kara
2010-08-05 19:38 ` Jens Axboe
2010-08-05 23:45 ` Andrew Morton
2010-08-07 16:04 ` Wu Fengguang
2010-08-08 2:43 ` Jan Kara
2010-08-08 3:10 ` Wu Fengguang
2010-08-08 4:12 ` Dave Chinner
2010-08-08 7:29 ` Wu Fengguang
2010-08-08 11:07 ` Jens Axboe
2010-08-08 13:59 ` Jan Kara
2010-08-08 22:55 ` Wu Fengguang
2010-08-05 18:53 ` [PATCH 2/3 v2] mm: Fix writeback_in_progress() Jan Kara
2010-08-05 19:37 ` Jens Axboe
2010-08-05 23:06 ` Wu Fengguang
2010-08-06 0:10 ` Andrew Morton
2010-08-08 2:25 ` Jan Kara
2010-08-05 18:53 ` [PATCH 3/3 v2] mm: Avoid resetting wb_start after each writeback round Jan Kara
2010-08-05 19:38 ` Jens Axboe [this message]
2010-08-06 0:21 ` Andrew Morton
2010-08-07 22:45 ` Jan Kara
2010-08-06 12:23 ` [PATCH 0/3 v2] Three writeback fixes to stop sync(1) livelocks Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5B133F.60109@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.