From: Tilman Schmidt <tilman@imap.cc>
To: Dan Carpenter <error27@gmail.com>
Cc: Hansjoerg Lipp <hjlipp@web.de>,
Karsten Keil <isdn@linux-pingi.de>,
"David S. Miller" <davem@davemloft.net>,
Andy Shevchenko <ext-andriy.shevchenko@nokia.com>,
gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] isdn: gigaset: add missing unlock
Date: Sun, 08 Aug 2010 12:50:02 +0000 [thread overview]
Message-ID: <4C5EA7FA.9020504@imap.cc> (raw)
In-Reply-To: <20100806082323.GU9031@bicker>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
Am 06.08.2010 10:23 schrieb Dan Carpenter:
> We should unlock here. This is the only place where we return from the
> function with the lock held. The caller isn't expecting it.
Thanks, good catch.
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Tilman Schmidt <tilman@imap.cc>
>
> diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
> index e5ea344..bcc174e 100644
> --- a/drivers/isdn/gigaset/capi.c
> +++ b/drivers/isdn/gigaset/capi.c
> @@ -1052,6 +1052,7 @@ static inline void remove_appl_from_channel(struct bc_state *bcs,
> do {
> if (bcap->bcnext == ap) {
> bcap->bcnext = bcap->bcnext->bcnext;
> + spin_unlock_irqrestore(&bcs->aplock, flags);
> return;
> }
> bcap = bcap->bcnext;
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tilman Schmidt <tilman@imap.cc>
To: Dan Carpenter <error27@gmail.com>
Cc: Hansjoerg Lipp <hjlipp@web.de>,
Karsten Keil <isdn@linux-pingi.de>,
"David S. Miller" <davem@davemloft.net>,
Andy Shevchenko <ext-andriy.shevchenko@nokia.com>,
gigaset307x-common@lists.sourceforge.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] isdn: gigaset: add missing unlock
Date: Sun, 08 Aug 2010 14:50:02 +0200 [thread overview]
Message-ID: <4C5EA7FA.9020504@imap.cc> (raw)
In-Reply-To: <20100806082323.GU9031@bicker>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
Am 06.08.2010 10:23 schrieb Dan Carpenter:
> We should unlock here. This is the only place where we return from the
> function with the lock held. The caller isn't expecting it.
Thanks, good catch.
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Tilman Schmidt <tilman@imap.cc>
>
> diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
> index e5ea344..bcc174e 100644
> --- a/drivers/isdn/gigaset/capi.c
> +++ b/drivers/isdn/gigaset/capi.c
> @@ -1052,6 +1052,7 @@ static inline void remove_appl_from_channel(struct bc_state *bcs,
> do {
> if (bcap->bcnext == ap) {
> bcap->bcnext = bcap->bcnext->bcnext;
> + spin_unlock_irqrestore(&bcs->aplock, flags);
> return;
> }
> bcap = bcap->bcnext;
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2010-08-08 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 8:23 [patch] isdn: gigaset: add missing unlock Dan Carpenter
2010-08-06 8:23 ` Dan Carpenter
2010-08-08 6:04 ` David Miller
2010-08-08 6:04 ` David Miller
2010-08-08 12:50 ` Tilman Schmidt [this message]
2010-08-08 12:50 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5EA7FA.9020504@imap.cc \
--to=tilman@imap.cc \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=ext-andriy.shevchenko@nokia.com \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=hjlipp@web.de \
--cc=isdn@linux-pingi.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.