All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] sheepdog: remove unnecessary includes
@ 2010-08-08  9:31 Izumi Tsutsui
  2010-08-08 17:19 ` Kevin Wolf
  0 siblings, 1 reply; 2+ messages in thread
From: Izumi Tsutsui @ 2010-08-08  9:31 UTC (permalink / raw)
  To: qemu-devel; +Cc: Izumi Tsutsui

"qemu_socket.h" includes all necessary files and
including <netinet/tcp.h> without <netinet/in.h>
could cause errors on some systems.

Signed-off-by: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
---
 block/sheepdog.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/block/sheepdog.c b/block/sheepdog.c
index 81aa564..e62820a 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -8,16 +8,6 @@
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  */
-#ifdef _WIN32
-#include <windows.h>
-#include <winsock2.h>
-#include <ws2tcpip.h>
-#else
-#include <netdb.h>
-#include <netinet/tcp.h>
-
-#define closesocket(s) close(s)
-#endif
 
 #include "qemu-common.h"
 #include "qemu-error.h"
-- 
1.7.0.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] sheepdog: remove unnecessary includes
  2010-08-08  9:31 [Qemu-devel] [PATCH] sheepdog: remove unnecessary includes Izumi Tsutsui
@ 2010-08-08 17:19 ` Kevin Wolf
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Wolf @ 2010-08-08 17:19 UTC (permalink / raw)
  To: Izumi Tsutsui; +Cc: qemu-devel

Am 08.08.2010 11:31, schrieb Izumi Tsutsui:
> "qemu_socket.h" includes all necessary files and
> including <netinet/tcp.h> without <netinet/in.h>
> could cause errors on some systems.
> 
> Signed-off-by: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>

Thanks, applied to the block branch.

Kevin

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-08 17:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-08  9:31 [Qemu-devel] [PATCH] sheepdog: remove unnecessary includes Izumi Tsutsui
2010-08-08 17:19 ` Kevin Wolf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.