All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <james.smart@emulex.com>
To: Dan Carpenter <error27@gmail.com>,
	James Smart <james.smart@emulex.com>,
	"James E.J. Bottomley" <James.Bottomley@suse.de>,
	Alex Iannicelli <alex.iannicelli@emulex.com>,
	linux-scsi@v
Subject: Re: [patch] lpfc: change spin_lock_irq() to spin_lock()
Date: Mon, 09 Aug 2010 14:03:26 +0000	[thread overview]
Message-ID: <4C600AAE.8030507@emulex.com> (raw)
In-Reply-To: <20100807221517.GC9031@bicker>



Dan Carpenter wrote:
> In lpfc_cleanup_pending_mbox() we already have IRQs disabled so we don't
> need to disable them again.
> 
> Also in lpfc_sli_intr_handler() there is a typo where it has
> spin_unlock_irq() instead of just spin_unlock().
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> 
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c

Acked-by: James Smart <james.smart@emulex.com>

Thank You.

-- james s

WARNING: multiple messages have this Message-ID (diff)
From: James Smart <james.smart@emulex.com>
To: Dan Carpenter <error27@gmail.com>,
	James Smart <james.smart@emulex.com>,
	"James E.J. Bottomley" <James.Bottomley@suse.de>,
	Alex Iannicelli <alex.iannicelli@emulex.com>,
	linux-scsi@v
Subject: Re: [patch] lpfc: change spin_lock_irq() to spin_lock()
Date: Mon, 9 Aug 2010 10:03:26 -0400	[thread overview]
Message-ID: <4C600AAE.8030507@emulex.com> (raw)
In-Reply-To: <20100807221517.GC9031@bicker>



Dan Carpenter wrote:
> In lpfc_cleanup_pending_mbox() we already have IRQs disabled so we don't
> need to disable them again.
> 
> Also in lpfc_sli_intr_handler() there is a typo where it has
> spin_unlock_irq() instead of just spin_unlock().
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> 
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c

Acked-by: James Smart <james.smart@emulex.com>

Thank You.

-- james s

WARNING: multiple messages have this Message-ID (diff)
From: James Smart <james.smart@emulex.com>
To: Dan Carpenter <error27@gmail.com>,
	James Smart <james.smart@emulex.com>,
	"James E.J. Bottomley" <James.Bottomley@suse.de>,
	Alex Iannicelli <alex.iannicelli@emulex.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] lpfc: change spin_lock_irq() to spin_lock()
Date: Mon, 9 Aug 2010 10:03:26 -0400	[thread overview]
Message-ID: <4C600AAE.8030507@emulex.com> (raw)
In-Reply-To: <20100807221517.GC9031@bicker>



Dan Carpenter wrote:
> In lpfc_cleanup_pending_mbox() we already have IRQs disabled so we don't
> need to disable them again.
> 
> Also in lpfc_sli_intr_handler() there is a typo where it has
> spin_unlock_irq() instead of just spin_unlock().
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> 
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c

Acked-by: James Smart <james.smart@emulex.com>

Thank You.

-- james s

  reply	other threads:[~2010-08-09 14:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-07 22:15 [patch] lpfc: change spin_lock_irq() to spin_lock() Dan Carpenter
2010-08-07 22:15 ` Dan Carpenter
2010-08-09 14:03 ` James Smart [this message]
2010-08-09 14:03   ` James Smart
2010-08-09 14:03   ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C600AAE.8030507@emulex.com \
    --to=james.smart@emulex.com \
    --cc=James.Bottomley@suse.de \
    --cc=alex.iannicelli@emulex.com \
    --cc=error27@gmail.com \
    --cc=linux-scsi@v \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.