From: Avi Kivity <avi@redhat.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [RFC PATCH 3/3] VMX: Emulated real mode interrupt injection
Date: Tue, 10 Aug 2010 18:52:47 -0400 [thread overview]
Message-ID: <4C61D83F.8050305@redhat.com> (raw)
In-Reply-To: <AANLkTi=wyYv1JhH-0=BiRUdobhptM=nLvBMrtKnn1KM1@mail.gmail.com>
On 08/10/2010 01:13 PM, Mohammed Gamal wrote:
>
>>
>>> - vmcs_write32(VM_ENTRY_INTR_INFO_FIELD,
>>> - irq | INTR_TYPE_SOFT_INTR |
>>> INTR_INFO_VALID_MASK);
>>> - vmcs_write32(VM_ENTRY_INSTRUCTION_LEN, 1);
>>> - kvm_rip_write(vcpu, vmx->rmode.irq.rip - 1);
>>> + inject_realmode_interrupt(vcpu, irq);
>>> return;
>>> }
>> Error checks?
> We return anyway. Is there somwhere in the vmcs where an error is
> indicated (e.g. setting some flag or variable)? Or should we probably
> let vmx_inject_irq() return an integer return value?
That's too complicated for now. I guess you can KVM_REQ_TRIPLE_FAULT,
and the guest will reset.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-08-10 22:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-08 19:24 [RFC PATCH 0/3] Real mode interrupt injection Mohammed Gamal
2010-08-08 19:24 ` [RFC PATCH 1/3] x86 emulator: Expose emulate_int_real() Mohammed Gamal
2010-08-08 19:24 ` [RFC PATCH 2/3] x86: Add inject_realmode_interrupt() wrapper Mohammed Gamal
2010-08-10 2:57 ` Avi Kivity
2010-08-08 19:24 ` [RFC PATCH 3/3] VMX: Emulated real mode interrupt injection Mohammed Gamal
2010-08-10 3:03 ` Avi Kivity
2010-08-10 17:13 ` Mohammed Gamal
2010-08-10 22:52 ` Avi Kivity [this message]
2010-08-10 2:52 ` [RFC PATCH 0/3] Real " Avi Kivity
2010-08-10 17:06 ` Mohammed Gamal
2010-08-10 23:02 ` Avi Kivity
2010-08-11 1:19 ` Mohammed Gamal
[not found] ` <AANLkTimmhvH2q7cCJZ+AV0OYhbvz=AZ_LLA3jU-nLdF1@mail.gmail.com>
2010-08-11 11:04 ` Avi Kivity
2010-08-11 11:20 ` Avi Kivity
2010-08-11 12:08 ` Avi Kivity
2010-08-11 23:22 ` Mohammed Gamal
2010-08-12 0:48 ` Avi Kivity
2010-08-12 1:07 ` Mohammed Gamal
2010-08-15 12:23 ` Avi Kivity
2010-08-15 12:30 ` Mohammed Gamal
2010-08-11 11:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C61D83F.8050305@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.