* kernel version 2.6.35-git10 build failure
@ 2010-08-11 7:21 divya
2010-08-11 7:51 ` Stephen Rothwell
2010-08-11 7:53 ` Sripathi Kodi
0 siblings, 2 replies; 7+ messages in thread
From: divya @ 2010-08-11 7:21 UTC (permalink / raw)
To: LKML, linuxppc-dev, sripathik
Hi,
Today kernel(version 2.6.35-git10 -commitid 3d30701b58970) build fails with following error on both system x and p
fs/9p/vfs_inode.c: In function 'v9fs_vfs_setattr_dotl':
fs/9p/vfs_inode.c:1267: error: implicit declaration of function 'inode_setattr'
make[2]: *** [fs/9p/vfs_inode.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [fs/9p] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [fs] Error 2
make: *** Waiting for unfinished jobs....
Seems like the commit 87d7845aa0b is the corrupt which added the function v9fs_vfs_setattr_dotl()
Thanks
Divya
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: kernel version 2.6.35-git10 build failure
2010-08-11 7:21 kernel version 2.6.35-git10 build failure divya
@ 2010-08-11 7:51 ` Stephen Rothwell
2010-08-11 7:53 ` Sripathi Kodi
1 sibling, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2010-08-11 7:51 UTC (permalink / raw)
To: divya; +Cc: linuxppc-dev, sripathik, LKML
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
Hi Divya,
On Wed, 11 Aug 2010 12:51:35 +0530 divya <dipraksh@linux.vnet.ibm.com> wrote:
>
> Today kernel(version 2.6.35-git10 -commitid 3d30701b58970) build fails with following error on both system x and p
>
> fs/9p/vfs_inode.c: In function 'v9fs_vfs_setattr_dotl':
> fs/9p/vfs_inode.c:1267: error: implicit declaration of function 'inode_setattr'
This is known about and a fix is pending. Thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: kernel version 2.6.35-git10 build failure
2010-08-11 7:21 kernel version 2.6.35-git10 build failure divya
@ 2010-08-11 7:53 ` Sripathi Kodi
2010-08-11 7:53 ` Sripathi Kodi
1 sibling, 0 replies; 7+ messages in thread
From: Sripathi Kodi @ 2010-08-11 7:53 UTC (permalink / raw)
To: divya; +Cc: linuxppc-dev, LKML, Stephen Rothwell
On Wed, 11 Aug 2010 12:51:35 +0530
divya <dipraksh@linux.vnet.ibm.com> wrote:
> Hi,
>
> Today kernel(version 2.6.35-git10 -commitid 3d30701b58970) build fails with following error on both system x and p
>
> fs/9p/vfs_inode.c: In function 'v9fs_vfs_setattr_dotl':
> fs/9p/vfs_inode.c:1267: error: implicit declaration of function 'inode_setattr'
> make[2]: *** [fs/9p/vfs_inode.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [fs/9p] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [fs] Error 2
> make: *** Waiting for unfinished jobs....
>
> Seems like the commit 87d7845aa0b is the corrupt which added the function v9fs_vfs_setattr_dotl()
Yes, it is a problem I created. Stephen Rothwell has already fixed it.
Al Viro has sent a git pull request to Linus today with the fix in it.
Here is the patch you need: http://lkml.org/lkml/2010/6/21/442
Thanks,
Sripathi.
>
> Thanks
> Divya
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: kernel version 2.6.35-git10 build failure
@ 2010-08-11 7:53 ` Sripathi Kodi
0 siblings, 0 replies; 7+ messages in thread
From: Sripathi Kodi @ 2010-08-11 7:53 UTC (permalink / raw)
To: divya; +Cc: LKML, linuxppc-dev, Stephen Rothwell
On Wed, 11 Aug 2010 12:51:35 +0530
divya <dipraksh@linux.vnet.ibm.com> wrote:
> Hi,
>
> Today kernel(version 2.6.35-git10 -commitid 3d30701b58970) build fails with following error on both system x and p
>
> fs/9p/vfs_inode.c: In function 'v9fs_vfs_setattr_dotl':
> fs/9p/vfs_inode.c:1267: error: implicit declaration of function 'inode_setattr'
> make[2]: *** [fs/9p/vfs_inode.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [fs/9p] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [fs] Error 2
> make: *** Waiting for unfinished jobs....
>
> Seems like the commit 87d7845aa0b is the corrupt which added the function v9fs_vfs_setattr_dotl()
Yes, it is a problem I created. Stephen Rothwell has already fixed it.
Al Viro has sent a git pull request to Linus today with the fix in it.
Here is the patch you need: http://lkml.org/lkml/2010/6/21/442
Thanks,
Sripathi.
>
> Thanks
> Divya
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: kernel version 2.6.35-git10 build failure
2010-08-11 7:53 ` Sripathi Kodi
@ 2010-08-11 8:59 ` Piotr Hosowicz
-1 siblings, 0 replies; 7+ messages in thread
From: Piotr Hosowicz @ 2010-08-11 8:59 UTC (permalink / raw)
To: Sripathi Kodi; +Cc: linuxppc-dev, Stephen Rothwell, LKML, divya
On 11.08.2010 09:53, Sripathi Kodi wrote:
> On Wed, 11 Aug 2010 12:51:35 +0530
> divya<dipraksh@linux.vnet.ibm.com> wrote:
>
>> Hi,
>>
>> Today kernel(version 2.6.35-git10 -commitid 3d30701b58970) build fails with following error on both system x and p
>>
>> fs/9p/vfs_inode.c: In function 'v9fs_vfs_setattr_dotl':
>> fs/9p/vfs_inode.c:1267: error: implicit declaration of function 'inode_setattr'
>> make[2]: *** [fs/9p/vfs_inode.o] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> make[1]: *** [fs/9p] Error 2
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [fs] Error 2
>> make: *** Waiting for unfinished jobs....
>>
>> Seems like the commit 87d7845aa0b is the corrupt which added the function v9fs_vfs_setattr_dotl()
>
> Yes, it is a problem I created. Stephen Rothwell has already fixed it.
> Al Viro has sent a git pull request to Linus today with the fix in it.
> Here is the patch you need: http://lkml.org/lkml/2010/6/21/442
I fail to apply the patch.
aapi205:/usr/src/linux# patch -p1 < ../9p-patch.txt
patching file fs/9p/vfs_inode.c
Hunk #1 FAILED at 1052.
1 out of 1 hunk FAILED -- saving rejects to file fs/9p/vfs_inode.c.rej
aapi205:/usr/src/linux# cat fs/9p/vfs_inode.c.rej
--- fs/9p/vfs_inode.c
+++ fs/9p/vfs_inode.c
@@ -1052,10 +1052,19 @@
return PTR_ERR(fid);
retval = p9_client_setattr(fid, &p9attr);
- if (retval >= 0)
- retval = inode_setattr(dentry->d_inode, iattr);
+ if (retval < 0)
+ return retval;
- return retval;
+ if ((iattr->ia_valid & ATTR_SIZE) &&
+ iattr->ia_size != i_size_read(dentry->d_inode)) {
+ retval = vmtruncate(dentry->d_inode, iattr->ia_size);
+ if (retval)
+ return retval;
+ }
+
+ setattr_copy(dentry->d_inode, iattr);
+ mark_inode_dirty(dentry->d_inode);
+ return 0;
}
/**
I must be doing something wrong way.
Regards,
Piotr Hosowicz
--
Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach:
- Jaką walutę mają Indie?
- Ramadan.
NP: Patrick O'Hearn - Approaching Summit
NB: 2.6.35-git9
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: kernel version 2.6.35-git10 build failure
@ 2010-08-11 8:59 ` Piotr Hosowicz
0 siblings, 0 replies; 7+ messages in thread
From: Piotr Hosowicz @ 2010-08-11 8:59 UTC (permalink / raw)
To: Sripathi Kodi; +Cc: divya, LKML, linuxppc-dev, Stephen Rothwell
On 11.08.2010 09:53, Sripathi Kodi wrote:
> On Wed, 11 Aug 2010 12:51:35 +0530
> divya<dipraksh@linux.vnet.ibm.com> wrote:
>
>> Hi,
>>
>> Today kernel(version 2.6.35-git10 -commitid 3d30701b58970) build fails with following error on both system x and p
>>
>> fs/9p/vfs_inode.c: In function 'v9fs_vfs_setattr_dotl':
>> fs/9p/vfs_inode.c:1267: error: implicit declaration of function 'inode_setattr'
>> make[2]: *** [fs/9p/vfs_inode.o] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> make[1]: *** [fs/9p] Error 2
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [fs] Error 2
>> make: *** Waiting for unfinished jobs....
>>
>> Seems like the commit 87d7845aa0b is the corrupt which added the function v9fs_vfs_setattr_dotl()
>
> Yes, it is a problem I created. Stephen Rothwell has already fixed it.
> Al Viro has sent a git pull request to Linus today with the fix in it.
> Here is the patch you need: http://lkml.org/lkml/2010/6/21/442
I fail to apply the patch.
aapi205:/usr/src/linux# patch -p1 < ../9p-patch.txt
patching file fs/9p/vfs_inode.c
Hunk #1 FAILED at 1052.
1 out of 1 hunk FAILED -- saving rejects to file fs/9p/vfs_inode.c.rej
aapi205:/usr/src/linux# cat fs/9p/vfs_inode.c.rej
--- fs/9p/vfs_inode.c
+++ fs/9p/vfs_inode.c
@@ -1052,10 +1052,19 @@
return PTR_ERR(fid);
retval = p9_client_setattr(fid, &p9attr);
- if (retval >= 0)
- retval = inode_setattr(dentry->d_inode, iattr);
+ if (retval < 0)
+ return retval;
- return retval;
+ if ((iattr->ia_valid & ATTR_SIZE) &&
+ iattr->ia_size != i_size_read(dentry->d_inode)) {
+ retval = vmtruncate(dentry->d_inode, iattr->ia_size);
+ if (retval)
+ return retval;
+ }
+
+ setattr_copy(dentry->d_inode, iattr);
+ mark_inode_dirty(dentry->d_inode);
+ return 0;
}
/**
I must be doing something wrong way.
Regards,
Piotr Hosowicz
--
Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach:
- Jaką walutę mają Indie?
- Ramadan.
NP: Patrick O'Hearn - Approaching Summit
NB: 2.6.35-git9
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-08-11 9:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-11 7:21 kernel version 2.6.35-git10 build failure divya
2010-08-11 7:51 ` Stephen Rothwell
2010-08-11 7:51 ` Stephen Rothwell
2010-08-11 7:53 ` Sripathi Kodi
2010-08-11 7:53 ` Sripathi Kodi
2010-08-11 8:59 ` Piotr Hosowicz
2010-08-11 8:59 ` Piotr Hosowicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.