Re: [PATCH -next] quota: fix QUOTACTL kconfig for gfs2

[Randy Dunlap <randy.dunlap@oracle.com>]

On 08/11/10 19:46, Jan Kara wrote:
> On Wed 11-08-10 16:24:35, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> warning: (GFS2_FS && BLOCK && EXPERIMENTAL && (64BIT || LBDAF)) selects QUOTACTL which has unmet direct dependencies (XFS_QUOTA || QUOTA)
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc:	Steven Whitehouse <swhiteho@redhat.com>
>> Cc:	cluster-devel@redhat.com
>> ---
>>  fs/quota/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> However, the "depends on" line here seems like overkill to me.
>   OK, so do you mean that making QUOTACTL default to 'n', removing the
> depends on line and letting QUOTA, XFS_QUOTA, and GFS2_QUOTA select
> QUOTACTL would be better?

Yes, I think that would be better.

However, if you like the patch below, we should also kill the 'select QUOTACTL'
in fs/gfs2/Kconfig.

>> --- linux-next-20100810.orig/fs/quota/Kconfig
>> +++ linux-next-20100810/fs/quota/Kconfig
>> @@ -65,7 +65,7 @@ config QFMT_V2
>>  
>>  config QUOTACTL
>>  	bool
>> -	depends on XFS_QUOTA || QUOTA
>> +	depends on XFS_QUOTA || QUOTA || GFS2_FS
>>  	default y
>>  
>>  config QUOTACTL_COMPAT


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***