From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH -next] quota: fix QUOTACTL kconfig for gfs2
Date: Tue, 17 Aug 2010 08:03:25 -0700 [thread overview]
Message-ID: <4C6AA4BD.30809@oracle.com> (raw)
In-Reply-To: <20100817102202.GB3557@quack.suse.cz>
On 08/17/10 03:22, Jan Kara wrote:
> On Thu 12-08-10 08:39:45, Randy Dunlap wrote:
>> On 08/11/10 19:46, Jan Kara wrote:
>>> On Wed 11-08-10 16:24:35, Randy Dunlap wrote:
>>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>>
>>>> warning: (GFS2_FS && BLOCK && EXPERIMENTAL && (64BIT || LBDAF)) selects QUOTACTL which has unmet direct dependencies (XFS_QUOTA || QUOTA)
>>>>
>>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>>> Cc: Steven Whitehouse <swhiteho@redhat.com>
>>>> Cc: cluster-devel@redhat.com
>>>> ---
>>>> fs/quota/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> However, the "depends on" line here seems like overkill to me.
>>> OK, so do you mean that making QUOTACTL default to 'n', removing the
>>> depends on line and letting QUOTA, XFS_QUOTA, and GFS2_QUOTA select
>>> QUOTACTL would be better?
>>
>> Yes, I think that would be better.
> OK, I've pushed the patch below to my tree.
Thanks. Looks good.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2010-08-17 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 23:24 [PATCH -next] quota: fix QUOTACTL kconfig for gfs2 Randy Dunlap
2010-08-12 2:46 ` Jan Kara
2010-08-12 15:39 ` Randy Dunlap
2010-08-12 15:57 ` Steven Whitehouse
2010-08-12 16:03 ` Randy Dunlap
2010-08-12 16:14 ` Christoph Hellwig
2010-08-12 16:34 ` Steven Whitehouse
2010-08-12 16:41 ` Randy Dunlap
2010-08-17 10:22 ` Jan Kara
2010-08-17 15:03 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6AA4BD.30809@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.