From: "Michael Büsch" <mb@bu3sch.de>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: "John Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
"Larry Finger" <larry.finger@lwfinger.net>,
"Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH 4/4] b43: N-PHY: Implement RX core state setting for rev.2 and earlier PHYs
Date: Mon, 16 Aug 2010 22:47:32 +0200 [thread overview]
Message-ID: <4C69A3E4.1080807@bu3sch.de> (raw)
In-Reply-To: <1281991157-1557-4-git-send-email-netrolller.3d@gmail.com> (sfid-20100816_223927_806858_FFFFFFFFDFC5176A)
On 08/16/2010 10:39 PM, G?bor Stefanik wrote:
> +static void b43_nphy_set_rx_core_state(struct b43_wldev *dev, u8 mask)
> +{
> + struct b43_phy *phy =&dev->phy;
> + struct b43_phy_n *nphy = phy->n;
> + u16 buf[16];
> + if (maskbits& 0x3 != 0x3) {
Does this even compile? I don't see maskbits being defined.
--
Greetings Michael.
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Büsch" <mb@bu3sch.de>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: "John Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
"Larry Finger" <larry.finger@lwfinger.net>,
"Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: [PATCH 4/4] b43: N-PHY: Implement RX core state setting for rev.2 and earlier PHYs
Date: Mon, 16 Aug 2010 22:47:32 +0200 [thread overview]
Message-ID: <4C69A3E4.1080807@bu3sch.de> (raw)
In-Reply-To: <1281991157-1557-4-git-send-email-netrolller.3d@gmail.com> (sfid-20100816_223927_806858_FFFFFFFFDFC5176A)
On 08/16/2010 10:39 PM, Gábor Stefanik wrote:
> +static void b43_nphy_set_rx_core_state(struct b43_wldev *dev, u8 mask)
> +{
> + struct b43_phy *phy =&dev->phy;
> + struct b43_phy_n *nphy = phy->n;
> + u16 buf[16];
> + if (maskbits& 0x3 != 0x3) {
Does this even compile? I don't see maskbits being defined.
--
Greetings Michael.
next prev parent reply other threads:[~2010-08-16 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 20:39 [PATCH 1/4] b43: N-PHY: Implement Host Flags write during device init Gábor Stefanik
2010-08-16 20:39 ` Gábor Stefanik
2010-08-16 20:39 ` [PATCH 2/4] b43: N-PHY: Fix typo in function name (gain_crtl -> gain_ctrl) Gábor Stefanik
2010-08-16 20:39 ` Gábor Stefanik
2010-08-16 20:39 ` [PATCH 3/4] b43: N-PHY: Implement MAC PHY clock set Gábor Stefanik
2010-08-16 20:39 ` Gábor Stefanik
2010-08-16 20:39 ` [PATCH 4/4] b43: N-PHY: Implement RX core state setting for rev.2 and earlier PHYs Gábor Stefanik
2010-08-16 20:39 ` Gábor Stefanik
2010-08-16 20:47 ` Michael Büsch [this message]
2010-08-16 20:47 ` Michael Büsch
2010-08-17 6:37 ` Gábor Stefanik
2010-08-17 6:37 ` Gábor Stefanik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C69A3E4.1080807@bu3sch.de \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netrolller.3d@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.