All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Thomas Gleixner <tglx@linutronix.de>,
	Don Zickus <dzickus@redhat.com>
Subject: Re: [PATCH] lockup_detector: Make DETECT_HUNT_TASK default depend on LOCKUP_DETECTOR
Date: Tue, 17 Aug 2010 14:03:04 +0800	[thread overview]
Message-ID: <4C6A2618.2050403@cn.fujitsu.com> (raw)
In-Reply-To: <20100808195839.GA5387@nowhere>

(Just came back from vacation)

>> Maybe a better change would be to make it more generally available - right now 
>> it's:
>>
>>  config LOCKUP_DETECTOR
>>          bool "Detect Hard and Soft Lockups"
>>          depends on DEBUG_KERNEL && !S390
>>
>> which means that it cannot be enabled when DEBUG_KERNEL is off.
>>
>> So i think we should:
>>
>>  - Remove the s390 hack and add an ARCH_HAS_LOCKUP_DETECTOR flag
> 
> If we do this, we'll need to add this config on every archs but s390.
> We should better have ARCH_WANT_NO_LOCKUP_DETECTOR. I know that
> "negative" meaning configs suck, but otherwise we would lose this
> support on many archs.
> 
> Why s390 doesn't want the softlockup detector to begin with?
> 
>>  - Remove the DEBUG_KERNEL dependency
> 
> Yeah.
> 

Seems we haven't come to an agreement yet? I don't know much about the
lockup detector code, so please take care of this. :)


      parent reply	other threads:[~2010-08-17  5:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-04  1:53 [PATCH] lockup_detector: Make DETECT_HUNT_TASK default depend on LOCKUP_DETECTOR Li Zefan
2010-08-06  0:58 ` Frederic Weisbecker
2010-08-07  7:01   ` Ingo Molnar
2010-08-08 19:58     ` Frederic Weisbecker
2010-08-08 21:23       ` Ingo Molnar
2010-08-08 21:47         ` Frederic Weisbecker
2010-08-09  8:07       ` Heiko Carstens
2010-08-09 13:49         ` Don Zickus
2010-08-09 14:21           ` Heiko Carstens
2010-08-17  6:03       ` Li Zefan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6A2618.2050403@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dzickus@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.