All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: [PATCH 2/2] b43: N-PHY: add sub calls of band width setting
Date: Sun, 22 Aug 2010 15:29:55 -0500	[thread overview]
Message-ID: <4C7188C3.90702@lwfinger.net> (raw)
In-Reply-To: <AANLkTi=ELhn1sFmpYn5a1-GcWqVBAeRGC6Kc7OBDLmZw@mail.gmail.com>

On 08/22/2010 03:04 PM, G?bor Stefanik wrote:
> 
> Sorry, I'm on a Windows-only machine right now.
> However, the general rule of translation is:
> mhf(a, b, c, d) -> b43_hf_write(dev, (b43_hf_read(dev) & (~b <<
> (a*16))) | (c << (a*16)))
> (Yes, the last parameter is ignored; it seems to be just Broadcrap -
> crap written by Broadcom.)
> 

IIRC, the d part is a flag used to save the state and avoid writes if the code
is setting a state already available. As these writes are not very expensive,
this part can indeed be called Broadcrap.

Larry

WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [PATCH 2/2] b43: N-PHY: add sub calls of band width setting
Date: Sun, 22 Aug 2010 15:29:55 -0500	[thread overview]
Message-ID: <4C7188C3.90702@lwfinger.net> (raw)
In-Reply-To: <AANLkTi=ELhn1sFmpYn5a1-GcWqVBAeRGC6Kc7OBDLmZw@mail.gmail.com>

On 08/22/2010 03:04 PM, Gábor Stefanik wrote:
> 
> Sorry, I'm on a Windows-only machine right now.
> However, the general rule of translation is:
> mhf(a, b, c, d) -> b43_hf_write(dev, (b43_hf_read(dev) & (~b <<
> (a*16))) | (c << (a*16)))
> (Yes, the last parameter is ignored; it seems to be just Broadcrap -
> crap written by Broadcom.)
> 

IIRC, the d part is a flag used to save the state and avoid writes if the code
is setting a state already available. As these writes are not very expensive,
this part can indeed be called Broadcrap.

Larry

  parent reply	other threads:[~2010-08-22 20:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-22 19:49 [PATCH 1/2] b43: N-PHY: band width setting with dumb clock control call Rafał Miłecki
2010-08-22 19:49 ` Rafał Miłecki
2010-08-22 19:49 ` [PATCH 2/2] b43: N-PHY: add sub calls of band width setting Rafał Miłecki
2010-08-22 19:49   ` Rafał Miłecki
2010-08-22 19:52   ` Gábor Stefanik
2010-08-22 19:52     ` Gábor Stefanik
2010-08-22 19:58     ` Rafał Miłecki
2010-08-22 19:58       ` Rafał Miłecki
2010-08-22 20:04       ` Gábor Stefanik
2010-08-22 20:04         ` Gábor Stefanik
2010-08-22 20:14         ` Rafał Miłecki
2010-08-22 20:14           ` Rafał Miłecki
2010-08-22 20:29         ` Larry Finger [this message]
2010-08-22 20:29           ` Larry Finger
2010-08-25 19:07         ` Michael Büsch
2010-08-25 19:07           ` Michael Büsch
2010-08-22 23:20 ` [PATCH 1/2] b43: N-PHY: band width setting with dumb clock control call Julian Calaby
2010-08-22 23:30   ` Gábor Stefanik
2010-08-22 23:30     ` Gábor Stefanik
2010-08-22 23:37     ` Rafał Miłecki
2010-08-22 23:37       ` Rafał Miłecki
2010-08-23 22:53     ` Rafał Miłecki
2010-08-23 22:53       ` Rafał Miłecki
2010-08-23 23:17       ` Larry Finger
2010-08-23 23:17         ` Larry Finger
2010-08-23 23:56         ` Gábor Stefanik
2010-08-23 23:56           ` Gábor Stefanik
2010-08-22 23:35   ` Rafał Miłecki
2010-08-22 23:35     ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7188C3.90702@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netrolller.3d@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.