From: Avi Kivity <avi@redhat.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Miguel Di Ciurcio Filho <miguel.filho@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments
Date: Sun, 22 Aug 2010 23:36:03 +0300 [thread overview]
Message-ID: <4C718A33.60100@redhat.com> (raw)
In-Reply-To: <4C7186A6.7030107@redhat.com>
On 08/22/2010 11:20 PM, Jes Sorensen wrote:
>
>> I happen to like the single line braces rule. That is, I don't like how
>> the code looks (I dislike punctuation generally), but I like the
>> consistency and I like how patches that add or remove a line are easy to
>> read.
>>
>> My preference would be: new code has to adhere to the new style.
> Agreed, once we pick something, make the new stuff stick to that. The
> main issue is when you make mods to a file that is using a different
> style. It's not ideal that you add one line of the new style and the
> rest is the old way.
I happen not to care too much but that's a personal thing I guess.
>> Perhaps we can have a bot subscribed to the list issue auto-reviews if
>> things are incorrect.
> That might work.
Anyone for a Google Weekend of Code?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2010-08-22 20:36 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 17:49 [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments Blue Swirl
2010-08-12 18:56 ` malc
2010-08-13 15:22 ` Miguel Di Ciurcio Filho
2010-08-13 18:02 ` Blue Swirl
2010-08-17 8:04 ` Jes Sorensen
2010-08-17 13:21 ` Anthony Liguori
2010-08-17 13:55 ` Jes Sorensen
2010-08-17 18:56 ` Blue Swirl
2010-08-19 13:32 ` Jes Sorensen
2010-08-19 18:29 ` Blue Swirl
2010-08-22 20:15 ` Avi Kivity
2010-08-22 20:20 ` Jes Sorensen
2010-08-22 20:36 ` Avi Kivity [this message]
2010-08-20 13:47 ` Markus Armbruster
2010-08-20 18:44 ` Blue Swirl
2010-08-20 20:24 ` Blue Swirl
2010-08-21 9:54 ` Markus Armbruster
2010-08-21 10:47 ` Blue Swirl
2010-08-21 12:24 ` Markus Armbruster
2010-08-21 14:03 ` Blue Swirl
2010-08-22 16:49 ` Jes Sorensen
2010-08-22 17:00 ` malc
2010-08-22 18:32 ` Blue Swirl
2010-08-22 18:35 ` malc
2010-08-23 8:02 ` Jes Sorensen
2010-08-23 14:07 ` john cooper
2010-08-22 18:18 ` Blue Swirl
2010-08-22 18:36 ` malc
2010-08-22 18:42 ` Anthony Liguori
2010-08-22 20:03 ` Avi Kivity
2010-08-23 8:33 ` Kevin Wolf
2010-08-23 13:52 ` Jes Sorensen
2010-08-24 12:34 ` Markus Armbruster
2010-08-22 18:41 ` Anthony Liguori
2010-08-22 18:56 ` Blue Swirl
2010-08-22 19:28 ` Anthony Liguori
2010-08-22 19:44 ` malc
2010-08-22 19:50 ` Blue Swirl
2010-08-22 20:28 ` malc
2010-08-22 20:39 ` Avi Kivity
2010-08-23 13:55 ` Jes Sorensen
2010-08-23 14:03 ` Avi Kivity
2010-08-23 14:07 ` Jes Sorensen
2010-08-23 14:15 ` Avi Kivity
2010-08-22 19:47 ` Blue Swirl
2010-08-22 20:09 ` Avi Kivity
2010-08-22 20:15 ` Blue Swirl
2010-08-22 20:17 ` Anthony Liguori
2010-08-22 20:41 ` Avi Kivity
2010-08-23 7:17 ` [Qemu-devel] " Paolo Bonzini
2010-08-22 16:40 ` [Qemu-devel] " Jes Sorensen
2010-08-22 18:13 ` Blue Swirl
2010-08-22 18:39 ` malc
2010-08-23 8:14 ` Jes Sorensen
2010-08-23 14:04 ` john cooper
2010-08-23 8:09 ` Jes Sorensen
2010-08-22 20:12 ` Avi Kivity
2010-08-22 20:16 ` Blue Swirl
2010-08-22 20:43 ` Avi Kivity
2010-08-23 11:01 ` Markus Armbruster
2010-08-23 11:07 ` Avi Kivity
2010-08-17 18:51 ` Blue Swirl
2010-08-13 17:52 ` Blue Swirl
2010-08-13 20:54 ` malc
2010-08-15 14:04 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C718A33.60100@redhat.com \
--to=avi@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=miguel.filho@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.