Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments

[Kevin Wolf <kwolf@redhat.com>]

Am 22.08.2010 20:42, schrieb Anthony Liguori:
> On 08/22/2010 01:36 PM, malc wrote:
>>>>>
>>>>> But how would you do that? Drop the CODING_STYLE (and accept
>>>>> anything)? Switch to a new CODING_STYLE that is widely appreciated and
>>>>> so all bikeshedding will cease? Enforce current style?
>>>>>          
>>>> I would suggest we either clean up the existing rule, or switch to the
>>>> Linux kernel style, with the explicit exemption that existing code can
>>>> keep the 4-char indentation, unless the whole file is converted. I'd
>>>> like to avoid a total reformatting of the codebase, but we could look at
>>>> it on a file by file base if it becomes relevant.
>>>>        
>>> Sounds reasonable.
>>>
>>>      
>> Doesn't to me.
>>    
> 
> I'm strongly opposed to any reformatting of the tree.
> 
> All it does is break git blame which makes debugging harder without 
> offering any real benefits.

Thanks, Anthony. I fully agree. (And Avi added another good reason.)

And while I'm posting my hopefully only post to this thread, let me
mention that I'm fine with our current CODING_STYLE and can't see a
reason for another switch.

Kevin