From: Alexander Graf <agraf@suse.de>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: virtualization@lists.linux-foundation.org,
Rusty Russell <rusty@rustcorp.com.au>,
Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>,
Carsten Otte <carsteno@de.ibm.com>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/2] S390: take a full byte as ext_param indicator
Date: Tue, 24 Aug 2010 14:06:25 +0200 [thread overview]
Message-ID: <4C73B5C1.5040603@suse.de> (raw)
In-Reply-To: <4C736EAF.9020107@de.ibm.com>
Christian Borntraeger wrote:
> Am 23.08.2010 23:31, schrieb Alexander Graf:
>
>> Currenty the ext_param field only distinguishes between "config change" and
>> "vring interrupt". We can do a lot more with it though, so let's enable a
>> full byte of possible values and constants to #defines while at it.
>>
>
> Makes a lot of sense.
> [...]
>
>
>> #define VIRTIO_SUBCODE_64 0x0D00
>> +#define VIRTIO_PARAM_MASK 0xff
>> +#define VIRTIO_PARAM_VRING_INTERRUPT 0x0
>> +#define VIRTIO_PARAM_CONFIG_CHANGED 0x1
>>
>
> Maybe this should be exported in a header, something like
> arch/s390/include/asm/kvm_virtio.h? In that case this file
> must be added to Kbuild for make headers_install.
>
While that thought sounds good at first, it's really no use for anyone,
right? I mean - in qemu we need to define the defines manually anyways
because we need to potentially be able to build the s390x target on
non-s390x, possibly on non-Linux.
Alex
next prev parent reply other threads:[~2010-08-24 12:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 21:31 [PATCH 1/2] S390: take a full byte as ext_param indicator Alexander Graf
2010-08-23 21:31 ` [PATCH 2/2] S390: Add virtio hotplug add support Alexander Graf
2010-08-23 21:31 ` Alexander Graf
2010-08-24 7:13 ` Christian Borntraeger
2010-08-24 7:13 ` Christian Borntraeger
2010-08-24 7:03 ` [PATCH 1/2] S390: take a full byte as ext_param indicator Christian Borntraeger
2010-08-24 7:03 ` Christian Borntraeger
2010-08-24 12:06 ` Alexander Graf [this message]
2010-08-24 12:14 ` Christian Borntraeger
2010-08-24 12:14 ` Christian Borntraeger
2010-08-24 12:22 ` Avi Kivity
2010-08-24 12:25 ` Alexander Graf
2010-08-24 12:25 ` Alexander Graf
2010-08-24 12:30 ` Avi Kivity
2010-08-24 12:32 ` Alexander Graf
2010-08-24 12:32 ` Alexander Graf
2010-08-24 12:35 ` Avi Kivity
2010-08-24 12:35 ` Avi Kivity
2010-08-24 12:30 ` Avi Kivity
2010-08-24 13:24 ` Christian Borntraeger
2010-08-24 13:24 ` Christian Borntraeger
2010-08-24 12:22 ` Avi Kivity
2010-08-24 12:06 ` Alexander Graf
-- strict thread matches above, loose matches on Subject: below --
2010-08-23 21:31 Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C73B5C1.5040603@suse.de \
--to=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=carsteno@de.ibm.com \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.