From: Alexander Graf <agraf@suse.de>
To: Avi Kivity <avi@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
virtualization@lists.linux-foundation.org,
Rusty Russell <rusty@rustcorp.com.au>,
Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>,
Carsten Otte <carsteno@de.ibm.com>,
KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/2] S390: take a full byte as ext_param indicator
Date: Tue, 24 Aug 2010 14:25:06 +0200 [thread overview]
Message-ID: <4C73BA22.4000902@suse.de> (raw)
In-Reply-To: <4C73B97E.2060303@redhat.com>
Avi Kivity wrote:
> On 08/24/2010 03:14 PM, Christian Borntraeger wrote:
>>
>> I have no strong opinion on that, but I think its more a matter of where
>> to put an interface description. A header file seems just the right
>> place.
>> I will let you (or Rusty) decide.
>
> First of all we need a virtio/s390 specification, like we have a
> virtio/pci spec.
Sure, go ahead and write one :). All the bits are open.
No seriously, I've wanted to write one for quite a while but this is not
the right patch set for this.
> Second, I agree it should be in an exported header file, even if qemu
> doesn't make use of it. It's an interface and should be exported.
Hrm. *shrug* if you think it makes sense. I'm reasonably indifferent
either way, but I don't see value-add in it.
Alex
next prev parent reply other threads:[~2010-08-24 12:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 21:31 [PATCH 1/2] S390: take a full byte as ext_param indicator Alexander Graf
2010-08-23 21:31 ` [PATCH 2/2] S390: Add virtio hotplug add support Alexander Graf
2010-08-24 7:13 ` Christian Borntraeger
2010-08-24 7:13 ` Christian Borntraeger
2010-08-23 21:31 ` Alexander Graf
2010-08-24 7:03 ` [PATCH 1/2] S390: take a full byte as ext_param indicator Christian Borntraeger
2010-08-24 12:06 ` Alexander Graf
2010-08-24 12:06 ` Alexander Graf
2010-08-24 12:14 ` Christian Borntraeger
2010-08-24 12:14 ` Christian Borntraeger
2010-08-24 12:22 ` Avi Kivity
2010-08-24 12:25 ` Alexander Graf [this message]
2010-08-24 12:30 ` Avi Kivity
2010-08-24 12:32 ` Alexander Graf
2010-08-24 12:32 ` Alexander Graf
2010-08-24 12:35 ` Avi Kivity
2010-08-24 12:35 ` Avi Kivity
2010-08-24 12:30 ` Avi Kivity
2010-08-24 12:25 ` Alexander Graf
2010-08-24 13:24 ` Christian Borntraeger
2010-08-24 13:24 ` Christian Borntraeger
2010-08-24 12:22 ` Avi Kivity
2010-08-24 7:03 ` Christian Borntraeger
-- strict thread matches above, loose matches on Subject: below --
2010-08-23 21:31 Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C73BA22.4000902@suse.de \
--to=agraf@suse.de \
--cc=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=carsteno@de.ibm.com \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.